From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id qIqPKUu8hWBCOQAAgWs5BA (envelope-from ) for ; Sun, 25 Apr 2021 21:00:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id aAAVJUu8hWC5fQAAbx9fmQ (envelope-from ) for ; Sun, 25 Apr 2021 19:00:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D576D1937C for ; Sun, 25 Apr 2021 21:00:26 +0200 (CEST) Received: from localhost ([::1]:48126 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lajzV-0001H5-Ob for larch@yhetil.org; Sun, 25 Apr 2021 15:00:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lajz9-0001EX-8y for guix-patches@gnu.org; Sun, 25 Apr 2021 15:00:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60490) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lajz9-0006u2-0i for guix-patches@gnu.org; Sun, 25 Apr 2021 15:00:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lajz8-0004bz-VD for guix-patches@gnu.org; Sun, 25 Apr 2021 15:00:02 -0400 Subject: bug#47976: [PATCH v2 10/10] gnu: Add orange. Resent-From: Leo Famulari Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sun, 25 Apr 2021 19:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 47976 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego Cc: 47976-done@debbugs.gnu.org Mail-Followup-To: 47976@debbugs.gnu.org, leo@famulari.name, monego@posteo.net Received: via spool by 47976-done@debbugs.gnu.org id=D47976.161937718217659 (code D ref 47976); Sun, 25 Apr 2021 19:00:02 +0000 Received: (at 47976-done) by debbugs.gnu.org; 25 Apr 2021 18:59:42 +0000 Received: from localhost ([127.0.0.1]:43803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lajyn-0004al-LN for submit@debbugs.gnu.org; Sun, 25 Apr 2021 14:59:41 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:53469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lajym-0004aZ-B6 for 47976-done@debbugs.gnu.org; Sun, 25 Apr 2021 14:59:41 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 04F4A5C00B2; Sun, 25 Apr 2021 14:59:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 25 Apr 2021 14:59:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=p0+F03mTlc7zTKygisBPb0KY 0Z0Z2VVXNZBhnIkaP0o=; b=PMa18rgdkW4qboh+0WWSdvhXk5WBczdo276rlxE2 ZoFgRRzQ/1clb5stJHI0EvbaexTcauYO+9g/cNiHQXvEl7tHgymEG4X4VXpNeAj8 ibezBi3w+zoYbn8DkdfEMdeJ6Hrp2xPBymB5HP/8GbiNP+9+UWddSUUh1HJV5RFJ 6rw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=p0+F03 mTlc7zTKygisBPb0KY0Z0Z2VVXNZBhnIkaP0o=; b=UK3Us6N8RD7W0FG63nlc8G cT6mXq45KOp+2M1j26fbHvPak06IGOIHKj4YQdAhnKaABwOAaVLMzkVaja7CB8LH sVpi6Psi795JOhasi5C/59EDbufV9m2EMmkx/GZPo1CqhCeB/xyZiGB7hsCeR/WP DjBPSw7jFlRrjLgFP9U1GDIBvsCv2VJ1H9mBnBPXTJxzefnRkz2iD66XVhSOTsus 3hrM5yGr6hsmB7TUWhT8xR2epC70qZneGrd3bE/YQv0NOl4is4NikO3ybVMg4gum +B/nCwuh+0f7/LEEMy7jUeOFoNK0P7fgzgHYwX8FMZDbJBr+1E+4zt6Sn29l8jLA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdduiedgudefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepueekkedtffdvtddugeejgedtvefhueefiedvjeeitdeigedtveejvdejheff vefgnecukfhppedutddtrdduuddrudeiledruddukeenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA id 4CED81080068; Sun, 25 Apr 2021 14:59:34 -0400 (EDT) Date: Sun, 25 Apr 2021 14:59:32 -0400 From: Leo Famulari Message-ID: References: <20210425032608.124210-1-monego@posteo.net> <20210425032608.124210-10-monego@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210425032608.124210-10-monego@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619377227; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=p0+F03mTlc7zTKygisBPb0KY0Z0Z2VVXNZBhnIkaP0o=; b=XJv2qlUc2wOA8JQbibON5wQ5A2nQB+ymQMHPHgqVJTRpoW4w+S45JVIwdHcKJ+HyjS+KPM FbyDSXQJpNCGirM8bW5OJeHFsdd5cHXrKL2dVJyr3gO0dUHkwR25TjhWaDCTdQGj233YZs jj4rE0pe/UhopD3Cmduonqvfix/VkH/kzo2aFNtp3qOr4R+N7mYKCyPEmqQBhZmd0I64Qq zuGArvPgjLFWzSeiizLUTw+yjwaWgeeS6hdhOA9AsKFwg+Lhe9DYM0thnvObJYMpX1Jv0x DFLVvUBVhZrsdcqgCp5SkPhpWTz4Qil3nH9vMRN7Y9jzOZMSHVlQQ84yKVrwNQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619377227; a=rsa-sha256; cv=none; b=sjrF20T1JiCGUOrGd8puQPHx2LYH16rqKsDrf4+J26MaOCWNLqg+FVwX5f1Xj/ZMgh1ZTR SWRACxgh03CSjG/3wSgIfvs2pJ2wj4MXGMTjZKeMSSM0w7l3ki9pJzxrmXN8TWN/e9o2+b a4F2EKf3IEVxkbnCfLuN3altLyjuLDwzIEFLNsgJ72tIUt4OQ3NEZ8Ojp/RX9yFF/mHdKb 0NVw5DjcLIKGlGfAxKuss45TcvzG6E8ldRyJ6xi3z381K0/74vUGPXJEgKki396ba4f57r vhpPgHzjPRfUVawLZ7d9Zpk/Q5+kCXc0mhYlI4+AIjWkDk7plRwVOHkzKWYR5w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=PMa18rgd; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=UK3Us6N8; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.45 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=famulari.name header.s=mesmtp header.b=PMa18rgd; dkim=fail ("headers rsa verify failed") header.d=messagingengine.com header.s=fm2 header.b=UK3Us6N8; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: D576D1937C X-Spam-Score: -1.45 X-Migadu-Scanner: scn0.migadu.com X-TUID: C2acarp/SZKh On Sun, Apr 25, 2021 at 03:26:08AM +0000, Vinicius Monego wrote: > * gnu/packages/orange.scm (orange): New variable. Thanks for the v2 patches. I pushed as 5461efe81f680b577cb12ba7d003e38009628b81 after making the following changes: > + ;; Relax some dependency versions. > + (substitute* "requirements-gui.txt" (("PyQtWebEngine>=5.12") "")) I rewrote this comment to explain the reason for the substitution. Like I said, we do not change version constraints that are chosen by upstream developers without a good reason, and so this comment was not sufficient. > + ("python-louvain" ,python-python-louvain) I missed this in the first round of review but, as specified in our manual section Python Modules, we don't name packages "python-python-foo", but instead just "python-foo". After I changed it, I realized that we already have a python-louvain package. Anyways, I changed the pre-existing python-louvain package to be called python-louvain-0.6, adjusted its user, and renamed your package to python-louvain. It would be nice to check if python-scanpy, which uses python-louvain-0.6, can instead use python-louvain. Let us know if you want advice about how to handle this situation in the future.