all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Charles via Guix-patches via <guix-patches@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: "53704@debbugs.gnu.org" <53704@debbugs.gnu.org>,
	Julien Lepiller <julien@lepiller.eu>
Subject: [bug#53704] Bump
Date: Sat, 12 Feb 2022 23:45:34 +0000	[thread overview]
Message-ID: <PnC6IbPuiD_UZsr3th_oYjtMiMOlliw1yggefJgsdLLPPOQiJMkGK1CTYi468yxGVYU-i8EXnH4nL5aGWA1duDKb-pYQNDTfp00_WYYMiTA=@protonmail.com> (raw)
In-Reply-To: <11a5c7052c3f76dcf41fc614fed551ee019c1f96.camel@telenet.be>

Thanks for the review, Maxime! That is a lot of stuff I did not know about. Your new version of the patch works for me except for the (list (local-file part which I think should be (search-patches.

What should I do about the library code duplication and licensing issues? Should I bring it upu with the project maintainers?

------- Original Message -------

On Saturday, February 12th, 2022 at 7:31 AM, Maxime Devos <maximedevos@telenet.be> wrote:

> Hi,
>
> I've modified the package definition and patch a bit to
>
> make it simpler (visualboyadvance-m-fix-rpath.patch now only removed
>
> things), cross-compilable (it uses cc-for-target instead of hardcoding
>
> "gcc" and LIBRARY_PATH is unused) and avoid using constructs that
>
> are being deprecated (%build-inputs --> this-package-input).
>
> The list+local-file will have to be replaced by search-patches.
>
> Cross-compilation is untested because gtk+ cannot currently be
>
> cross-compiled.
>
> It seems to work, at least the application starts, I don't have any VBA
>
> games to test it with.
>
> Greetings,
>
> Maxime.




  reply	other threads:[~2022-02-12 23:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 17:36 [bug#53704] Add Visualboyadvance-m Charles via Guix-patches via
2022-02-11  6:51 ` [bug#53704] Bump Charles via Guix-patches via
2022-02-11  7:05   ` Julien Lepiller
2022-02-12  0:30     ` Charles via Guix-patches via
2022-02-12  9:54       ` Maxime Devos
2022-02-12 10:11       ` Maxime Devos
2022-02-12 11:35       ` Maxime Devos
2022-02-12 12:17         ` Maxime Devos
2022-02-12 13:31       ` Maxime Devos
2022-02-12 23:45         ` Charles via Guix-patches via [this message]
2022-02-27  0:19           ` Charles via Guix-patches via
2022-02-27 10:52           ` Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='PnC6IbPuiD_UZsr3th_oYjtMiMOlliw1yggefJgsdLLPPOQiJMkGK1CTYi468yxGVYU-i8EXnH4nL5aGWA1duDKb-pYQNDTfp00_WYYMiTA=@protonmail.com' \
    --to=guix-patches@gnu.org \
    --cc=53704@debbugs.gnu.org \
    --cc=charles.b.jackson@protonmail.com \
    --cc=julien@lepiller.eu \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.