From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KBqXMMVGCGItVgAAgWs5BA (envelope-from ) for ; Sun, 13 Feb 2022 00:46:13 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id OPNQKcVGCGLHOgAAG6o9tA (envelope-from ) for ; Sun, 13 Feb 2022 00:46:13 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 023582FD02 for ; Sun, 13 Feb 2022 00:46:13 +0100 (CET) Received: from localhost ([::1]:49052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nJ25j-0005QK-Bx for larch@yhetil.org; Sat, 12 Feb 2022 18:46:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJ25Z-0005QA-W3 for guix-patches@gnu.org; Sat, 12 Feb 2022 18:46:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:42055) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nJ25Z-0007HT-M8 for guix-patches@gnu.org; Sat, 12 Feb 2022 18:46:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nJ25Z-0004jC-J3 for guix-patches@gnu.org; Sat, 12 Feb 2022 18:46:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53704] Bump Resent-From: Charles Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 12 Feb 2022 23:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53704 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Maxime Devos Cc: "53704@debbugs.gnu.org" <53704@debbugs.gnu.org>, Julien Lepiller Received: via spool by 53704-submit@debbugs.gnu.org id=B53704.164470954618151 (code B ref 53704); Sat, 12 Feb 2022 23:46:01 +0000 Received: (at 53704) by debbugs.gnu.org; 12 Feb 2022 23:45:46 +0000 Received: from localhost ([127.0.0.1]:35951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJ25K-0004ih-1q for submit@debbugs.gnu.org; Sat, 12 Feb 2022 18:45:46 -0500 Received: from mail-4324.protonmail.ch ([185.70.43.24]:12285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJ25H-0004iT-NX for 53704@debbugs.gnu.org; Sat, 12 Feb 2022 18:45:44 -0500 Date: Sat, 12 Feb 2022 23:45:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1644709537; bh=FIYchh64fdXjPJZnuIqzeQdRyo/E8ZgA71AWdFVybTc=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID; b=XfJuTskMl09Eb7z7vbzJdHoktnwCLbG6lbATodaz0emgRlhnDUwe+2mqhxTCbBr0O 2iELEVKh3kt22ra1/g/+HQm0mOQMhk5n+ut3J7axIr75FgzLu4MDcwWIbBuEq5kazu ulh3VOpNI54V1l8FgjY+vbKj8lJuZH+on/AaRul205vkQ2KgZmPX0va69c7GhVjyc1 a0vAcCcXMvSC0/BAvCe0v5pmUTnKzEKv+MPgnr+bhMgW0VJhDYQ0boW7JCD7xnwHUz U3t3kV6JxmAIZnOdDhPmz/RhwkFM8QVMmqGC2Pey2stoB7PVVhfrxOpKuejFTONHOB OS+VYo18srWOA== Message-ID: In-Reply-To: <11a5c7052c3f76dcf41fc614fed551ee019c1f96.camel@telenet.be> References: <_jHX_rdAkHOB9IqHIQfXfggyuZwAL-8cC92ZuWnlLfjZtXdqUHY5XBLRjD32CGrxNx7uBzHJgAtN_YdHoifX1Y4Vhaayg_gWJX6wqPZDhx4=@protonmail.com> <33CA9DF7-1E9D-410D-9775-61825B56A0DF@lepiller.eu> <3c9dxjEeXYXD76uUQgjwTlqZOtOb7IFb8FX50AHQoH9bc-bapcr6kxnaouHjVYd3CaIPjKPiuUwZ6tx6VW-YRPKUMri5i_mLx4du5ux81a8=@protonmail.com> <11a5c7052c3f76dcf41fc614fed551ee019c1f96.camel@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Charles X-ACL-Warn: , Charles via Guix-patches From: Charles via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644709573; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=FIYchh64fdXjPJZnuIqzeQdRyo/E8ZgA71AWdFVybTc=; b=uJeevj7xHMIKsQTRD4egIPyBnBZmqNMimfEHV4iNNNwOTy3mKZkJ+Unlj0hX9SSES+Elwy UN+mFW+FJWekFl0psHhtv6JVDsIWt6m96XO7pY8+XW7/YF4Rwtjynmipd3l88q2mfhT0tk m0DtqSmlXBJY0SnM8nU16Z+e2qitH/FMK5sayzL80RqTR9RbY7IlNfJMKmoRc6Jg3xuObq lCPJejS6O1Q1/oyOmZNGfSAoP343jpEIH9pguriCFbCfkRck15Jb2KQSFqBpQ8uYHwjxet A5R+IUW2FfU2J6txct3NdMelgfHbLEAa4BNY8QbpnhiAqM1deQAm4sOxh+teEQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644709573; a=rsa-sha256; cv=none; b=h3F69Lly6LvTU8n+HlESST+xh7ZX+/BI6y3lPbS66P9ExQlmeboIzBtfP/kL0M8GIZAzRH cNkp9nf+HnzcurFpPL8Rzqu+w5+BxeSGy99x/cy0y8Gounnqf0HnWG1QnvCNhWjEPJj179 boAhBFoHKKjh6eYRT3fB0cAibVvO03UH3p0CPhGvn50IGJht4CKDPXU0lLemHnd69FrVgf gdz3UsDWjVzV/IF2DIedJdeueE5+0Acxu+6Y9/nhlFDem5P2L4F3ahb17fsc/QFrj90bWr zYEjXNvTFYsKA8HZ6rsNCnpMumgQhmxa9EJ8keXepygfHKIht2TiNQ0D+I0Fpw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=XfJuTskM; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.63 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=XfJuTskM; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 023582FD02 X-Spam-Score: -3.63 X-Migadu-Scanner: scn1.migadu.com X-TUID: FRKI+5Q13rYK Thanks for the review, Maxime! That is a lot of stuff I did not know about.= Your new version of the patch works for me except for the (list (local-fil= e part which I think should be (search-patches. What should I do about the library code duplication and licensing issues? S= hould I bring it upu with the project maintainers? ------- Original Message ------- On Saturday, February 12th, 2022 at 7:31 AM, Maxime Devos wrote: > Hi, > > I've modified the package definition and patch a bit to > > make it simpler (visualboyadvance-m-fix-rpath.patch now only removed > > things), cross-compilable (it uses cc-for-target instead of hardcoding > > "gcc" and LIBRARY_PATH is unused) and avoid using constructs that > > are being deprecated (%build-inputs --> this-package-input). > > The list+local-file will have to be replaced by search-patches. > > Cross-compilation is untested because gtk+ cannot currently be > > cross-compiled. > > It seems to work, at least the application starts, I don't have any VBA > > games to test it with. > > Greetings, > > Maxime.