all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Julien Lepiller <julien@lepiller.eu>
To: Charles <charles.b.jackson@protonmail.com>,
	"53704@debbugs.gnu.org" <53704@debbugs.gnu.org>
Subject: [bug#53704] Bump
Date: Fri, 11 Feb 2022 08:05:08 +0100	[thread overview]
Message-ID: <33CA9DF7-1E9D-410D-9775-61825B56A0DF@lepiller.eu> (raw)
In-Reply-To: <Q8Y0dERv2B2HRxgdbxZuAlQWe77wcC_de78ypfLnBLGBdYluR-9C-oDOI9nIFbosyWQHmhpYc34qSIGZHaLIoLYoutn3Qeb1_JOgzv9r0tQ=@protonmail.com>

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

Your patch looks good, though I haven't tested yet. In your synopsis, it's "an emulator", not "a emulator". The patches should contain author information. Did you create them yourself? Did you get them from somewhere else?

The gcc patch could be replaced with a phase that substitutes cc for gcc.

You need to add the patches to gnu/local.mk.

Thanks!

On February 11, 2022 7:51:31 AM GMT+01:00, Charles via Guix-patches via <guix-patches@gnu.org> wrote:
>Is there any chance this can get merged? If there is something wrong with the package, I am happy to fix it.
>
>
>
>

[-- Attachment #2: Type: text/html, Size: 864 bytes --]

  reply	other threads:[~2022-02-11  7:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01 17:36 [bug#53704] Add Visualboyadvance-m Charles via Guix-patches via
2022-02-11  6:51 ` [bug#53704] Bump Charles via Guix-patches via
2022-02-11  7:05   ` Julien Lepiller [this message]
2022-02-12  0:30     ` Charles via Guix-patches via
2022-02-12  9:54       ` Maxime Devos
2022-02-12 10:11       ` Maxime Devos
2022-02-12 11:35       ` Maxime Devos
2022-02-12 12:17         ` Maxime Devos
2022-02-12 13:31       ` Maxime Devos
2022-02-12 23:45         ` Charles via Guix-patches via
2022-02-27  0:19           ` Charles via Guix-patches via
2022-02-27 10:52           ` Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=33CA9DF7-1E9D-410D-9775-61825B56A0DF@lepiller.eu \
    --to=julien@lepiller.eu \
    --cc=53704@debbugs.gnu.org \
    --cc=charles.b.jackson@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.