* [bug#45011] [PATCH] add emacs-project and dependency
2020-12-04 20:12 ` Nicolas Goaziou
@ 2020-12-05 18:18 ` Jonathan
2020-12-06 14:53 ` Nicolas Goaziou
2020-12-05 19:41 ` [bug#45011] " Jonathan
2020-12-05 19:42 ` Jonathan
2 siblings, 1 reply; 14+ messages in thread
From: Jonathan @ 2020-12-05 18:18 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 45011
[-- Attachment #1: Type: text/plain, Size: 2047 bytes --]
Hi
The descriptions are the ones found in their project's homepage. I can't
think of a better synopsis for Project since it provides several functions
to operate on a project directory... Do you have a suggestion?.
Which patch do you want first? emacs-xref is needed for emacs-project. Do
you want me to send emacs-xref first?
Best,
On Fri, Dec 4, 2020 at 2:12 PM Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:
> Hello,
>
> Jonathan <rostranjj@gmail.com> writes:
>
> > gnu/packages/emacs-xyz.scm | 61 ++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 61 insertions(+)
>
> Thank you!
>
> Could you write a commit message to introduce your changes? You can look
> at those starting with "Add ..." in the code base.
>
> Also, could you split it into two patches, one for each package?
>
> > + (synopsis "Operations on the current project")
> > + (description
> > + "NOTE: The project API is still experimental and can change in major,
> > +backward-incompatible ways. Everyone is encouraged to try it, and
> > +report to us any problems or use cases we hadn't anticipated, by
> > +sending an email to emacs-devel, or `M-x report-emacs-bug'.
> > +
> > +This file contains generic infrastructure for dealing with
> > +projects, some utility functions, and commands using that
> > +infrastructure.")
>
> The synopsis could be clarified, so could the description. In
> particular, the latter explains what the library is about.
>
> > + (description
> > + "NOTE: The xref API is still experimental and can change in major,
> > +backward-incompatible ways. Everyone is encouraged to try it, and
> > +report to us any problems or use cases we hadn't anticipated, by
> > +sending an email to emacs-devel, or `M-x report-emacs-bug'.
> > +
> > +This file provides a somewhat generic infrastructure for cross
> > +referencing commands, in particular \"find-definition\".
> > +
> > +See the etags and elisp-mode implementations for full examples.")
>
> Ditto.
>
> Could you send an updated patch?
>
> Regards,
> --
> Nicolas Goaziou
>
[-- Attachment #2: Type: text/html, Size: 2788 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [bug#45011] [PATCH] add emacs-project and dependency
2020-12-05 18:18 ` Jonathan
@ 2020-12-06 14:53 ` Nicolas Goaziou
2020-12-06 19:22 ` Jonathan
0 siblings, 1 reply; 14+ messages in thread
From: Nicolas Goaziou @ 2020-12-06 14:53 UTC (permalink / raw)
To: Jonathan; +Cc: 45011
Hello,
Jonathan <rostranjj@gmail.com> writes:
> The descriptions are the ones found in their project's homepage.
Well, sometimes, even upstream descriptions need to be reworded.
> I can't think of a better synopsis for Project since it provides
> several functions to operate on a project directory... Do you have
> a suggestion?.
Unfortunately, no. My concern is that I don't know what this package is
about, and the synopsis doesn't help me finding it out. Maybe the term
"project" is too vague.
Note that the synopsis must fit on a single line, and is not a full
sentence. You may want to run "guix lint" on your package definition.
Also, I suggest to remove the big note at the beginning of each
description. It may make sense as a foreword in a project home page, but
I don't think it does when describing the software.
> Which patch do you want first? emacs-xref is needed for emacs-project. Do
> you want me to send emacs-xref first?
Sure.
I see you send new patches. Could you integrate the suggestion above,
and include a proper commit message, like the following:
gnu: Add emacs-xref.
* gnu/packages/emacs-xyz.scm (emacs-xref): New variable.
?
Thanks!
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 14+ messages in thread* [bug#45011] [PATCH] add emacs-project and dependency
2020-12-06 14:53 ` Nicolas Goaziou
@ 2020-12-06 19:22 ` Jonathan
2020-12-06 20:36 ` Nicolas Goaziou
0 siblings, 1 reply; 14+ messages in thread
From: Jonathan @ 2020-12-06 19:22 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 45011
Hello Nicolas
Thanks for the feedback. My bad if my tone in the email sounds dry... it’s not my intention.
This is my first ever Guix contribution and I’m following from what I saw in the website’s video tutorials. I kindly ask that you have some patience with me.
The only thing I need clarified now is how do I send the commits? I thought git format-patch included the commit? Do you want me to send two separate emails with the commit message as the subject? I’m not sure how to send to you the commit info with the patch in the email.
I did see those commit messages on the project repo but I was not sure I needed to add a newline after the main message. Do you want me to send the patches’ commit message like the one you just typed in the email?
All the best
> On Dec 6, 2020, at 08:53, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>
> Hello,
>
> Jonathan <rostranjj@gmail.com> writes:
>
>> The descriptions are the ones found in their project's homepage.
>
> Well, sometimes, even upstream descriptions need to be reworded.
>
>> I can't think of a better synopsis for Project since it provides
>> several functions to operate on a project directory... Do you have
>> a suggestion?.
>
> Unfortunately, no. My concern is that I don't know what this package is
> about, and the synopsis doesn't help me finding it out. Maybe the term
> "project" is too vague.
>
> Note that the synopsis must fit on a single line, and is not a full
> sentence. You may want to run "guix lint" on your package definition.
>
> Also, I suggest to remove the big note at the beginning of each
> description. It may make sense as a foreword in a project home page, but
> I don't think it does when describing the software.
>
>> Which patch do you want first? emacs-xref is needed for emacs-project. Do
>> you want me to send emacs-xref first?
>
> Sure.
>
> I see you send new patches. Could you integrate the suggestion above,
> and include a proper commit message, like the following:
>
> gnu: Add emacs-xref.
>
> * gnu/packages/emacs-xyz.scm (emacs-xref): New variable.
>
> ?
>
> Thanks!
>
> Regards,
> --
> Nicolas Goaziou
^ permalink raw reply [flat|nested] 14+ messages in thread
* [bug#45011] [PATCH] add emacs-project and dependency
2020-12-06 19:22 ` Jonathan
@ 2020-12-06 20:36 ` Nicolas Goaziou
2020-12-06 23:55 ` Jonathan
0 siblings, 1 reply; 14+ messages in thread
From: Nicolas Goaziou @ 2020-12-06 20:36 UTC (permalink / raw)
To: Jonathan; +Cc: 45011
Jonathan <rostranjj@gmail.com> writes:
> This is my first ever Guix contribution
Welcome aboard!
> and I’m following from what I saw in the website’s video tutorials.
> I kindly ask that you have some patience with me.
Of course!
> The only thing I need clarified now is how do I send the commits?
> I thought git format-patch included the commit?
It does. git format-patch generates a patch file including the commit
message. I'm surprised you experienced something different.
> Do you want me to send two separate emails with the commit message as
> the subject? I’m not sure how to send to you the commit info with the
> patch in the email.
The important things to fix are the descriptions and the synopses.
If you cannot send the commit message along with the patch, I'll write
it for you when applying the patches.
Since there are only two patches, you can attach them both to the same
email, if that's easier for you.
Regards,
^ permalink raw reply [flat|nested] 14+ messages in thread
* [bug#45011] [PATCH] add emacs-project and dependency
2020-12-06 20:36 ` Nicolas Goaziou
@ 2020-12-06 23:55 ` Jonathan
2020-12-08 7:26 ` Nicolas Goaziou
0 siblings, 1 reply; 14+ messages in thread
From: Jonathan @ 2020-12-06 23:55 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 45011
> It does. git format-patch generates a patch file including the commit
message. I'm surprised you experienced something different.
It does for me but as an email, with the subject filled in with the commit message. I only copied the body. Should I send the entire file? It will be formatted as an email with the sender, receiver and subject headers
Best
> On Dec 6, 2020, at 14:36, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:
>
> It does. git format-patch generates a patch file including the commit
> message. I'm surprised you experienced something different.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [bug#45011] [PATCH] add emacs-project and dependency
2020-12-06 23:55 ` Jonathan
@ 2020-12-08 7:26 ` Nicolas Goaziou
2020-12-08 17:31 ` Jonathan
0 siblings, 1 reply; 14+ messages in thread
From: Nicolas Goaziou @ 2020-12-08 7:26 UTC (permalink / raw)
To: Jonathan; +Cc: 45011
Hello,
Jonathan <rostranjj@gmail.com> writes:
> It does for me but as an email, with the subject filled in with the
> commit message. I only copied the body. Should I send the entire file?
I think so.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 14+ messages in thread
* [bug#45011] [PATCH] add emacs-project and dependency
2020-12-08 7:26 ` Nicolas Goaziou
@ 2020-12-08 17:31 ` Jonathan
2020-12-08 17:34 ` Jonathan
0 siblings, 1 reply; 14+ messages in thread
From: Jonathan @ 2020-12-08 17:31 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 45011
[-- Attachment #1: Type: text/plain, Size: 2151 bytes --]
From 1e2a8d0eefd02bbec2ad6366c312dab3c635cba1 Mon Sep 17 00:00:00 2001
From: wario <rostranjj@gmail.com>
Date: Tue, 8 Dec 2020 11:29:55 -0600
Subject: [PATCH] gnu: Add emacs-xref. *gnu/packages/emacs-xyz.scm
(emacs-xref): New variable.
---
gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e2658b4547..6999265a0e 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -87,6 +87,7 @@
;;; Copyright © 2020 Noah Landis <noahlandis@posteo.net>
;;; Copyright © 2020 Nicolò Balzarotti <nicolo@nixo.xyz>
;;; Copyright © 2020 André A. Gomes <andremegafone@gmail.com>
+;;; Copyright © 2020 Jonathan Rostran <rostranjj@gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -25768,3 +25769,25 @@ anymore. In this way, it's like a lightweight
\"workspace\" manager, allowing
you to easily restore one or more frames, including their windows, the
windows' layout, and their buffers.")
(license license:gpl3+)))
+
+(define-public emacs-xref
+ (package
+ (name "emacs-xref")
+ (version "1.0.3")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://elpa.gnu.org/packages/xref-"
+ version
+ ".el"))
+ (sha256
+ (base32
+ "1r531gl73y1br8g4n77gxbyj26yiaw7snjad21fgs5m80cka8fi3"))))
+ (build-system emacs-build-system)
+ (home-page
+ "http://elpa.gnu.org/packages/xref.html")
+ (synopsis "Cross-referencing commands")
+ (description "This file provides a somewhat generic infrastructure for
cross
+referencing commands, in particular \"find-definition\".")
+ (license license:gpl3+)))
--
2.29.2
On Tue, Dec 8, 2020 at 1:26 AM Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:
> Hello,
>
> Jonathan <rostranjj@gmail.com> writes:
>
> > It does for me but as an email, with the subject filled in with the
> > commit message. I only copied the body. Should I send the entire file?
>
> I think so.
>
> Regards,
> --
> Nicolas Goaziou
>
[-- Attachment #2: Type: text/html, Size: 3144 bytes --]
^ permalink raw reply related [flat|nested] 14+ messages in thread* [bug#45011] [PATCH] add emacs-project and dependency
2020-12-08 17:31 ` Jonathan
@ 2020-12-08 17:34 ` Jonathan
2020-12-16 16:53 ` Jonathan
0 siblings, 1 reply; 14+ messages in thread
From: Jonathan @ 2020-12-08 17:34 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 45011
[-- Attachment #1: Type: text/plain, Size: 3941 bytes --]
From fb50c9d2de0e4896dc679b217f3cf66c3214e044 Mon Sep 17 00:00:00 2001
From: wario <rostranjj@gmail.com>
Date: Tue, 8 Dec 2020 11:33:49 -0600
Subject: [PATCH] gnu: Add emacs-project *gnu/packages/emacs-xyz.scm
(emacs-project): New variable.
---
gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 6999265a0e..e15c7650e2 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -342,6 +342,31 @@ for those who may want transient periods of unbalanced
parentheses, such as
when typing parentheses directly or commenting out code line by line.")
(license license:gpl3+)))
+(define-public emacs-project
+ (package
+ (name "emacs-project")
+ (version "0.5.2")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://elpa.gnu.org/packages/project-"
+ version
+ ".el"))
+ (sha256
+ (base32
+ "181hls4phhj8kgpfcky6h0mgzpl9xj616abvcvx8mrn4nmpyh655"))))
+ (build-system emacs-build-system)
+ (propagated-inputs `(("emacs-xref" ,emacs-xref)))
+ (home-page
+ "http://elpa.gnu.org/packages/project.html")
+ (synopsis "Operations on the current project")
+ (description
+ "This file contains generic infrastructure for dealing with
+projects, some utility functions, and commands using that
+infrastructure.")
+ (license license:gpl3+)))
+
(define-public git-modes
(package
(name "emacs-git-modes")
--
2.29.2
On Tue, Dec 8, 2020 at 11:31 AM Jonathan <rostranjj@gmail.com> wrote:
> From 1e2a8d0eefd02bbec2ad6366c312dab3c635cba1 Mon Sep 17 00:00:00 2001
> From: wario <rostranjj@gmail.com>
> Date: Tue, 8 Dec 2020 11:29:55 -0600
> Subject: [PATCH] gnu: Add emacs-xref. *gnu/packages/emacs-xyz.scm
> (emacs-xref): New variable.
>
> ---
> gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index e2658b4547..6999265a0e 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -87,6 +87,7 @@
> ;;; Copyright © 2020 Noah Landis <noahlandis@posteo.net>
> ;;; Copyright © 2020 Nicolò Balzarotti <nicolo@nixo.xyz>
> ;;; Copyright © 2020 André A. Gomes <andremegafone@gmail.com>
> +;;; Copyright © 2020 Jonathan Rostran <rostranjj@gmail.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -25768,3 +25769,25 @@ anymore. In this way, it's like a lightweight
> \"workspace\" manager, allowing
> you to easily restore one or more frames, including their windows, the
> windows' layout, and their buffers.")
> (license license:gpl3+)))
> +
> +(define-public emacs-xref
> + (package
> + (name "emacs-xref")
> + (version "1.0.3")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://elpa.gnu.org/packages/xref-"
> + version
> + ".el"))
> + (sha256
> + (base32
> + "1r531gl73y1br8g4n77gxbyj26yiaw7snjad21fgs5m80cka8fi3"))))
> + (build-system emacs-build-system)
> + (home-page
> + "http://elpa.gnu.org/packages/xref.html")
> + (synopsis "Cross-referencing commands")
> + (description "This file provides a somewhat generic infrastructure for
> cross
> +referencing commands, in particular \"find-definition\".")
> + (license license:gpl3+)))
> --
> 2.29.2
>
>
>
> On Tue, Dec 8, 2020 at 1:26 AM Nicolas Goaziou <mail@nicolasgoaziou.fr>
> wrote:
>
>> Hello,
>>
>> Jonathan <rostranjj@gmail.com> writes:
>>
>> > It does for me but as an email, with the subject filled in with the
>> > commit message. I only copied the body. Should I send the entire file?
>>
>> I think so.
>>
>> Regards,
>> --
>> Nicolas Goaziou
>>
>
[-- Attachment #2: Type: text/html, Size: 5629 bytes --]
^ permalink raw reply related [flat|nested] 14+ messages in thread* [bug#45011] [PATCH] add emacs-project and dependency
2020-12-08 17:34 ` Jonathan
@ 2020-12-16 16:53 ` Jonathan
2020-12-16 17:33 ` bug#45011: " Nicolas Goaziou
0 siblings, 1 reply; 14+ messages in thread
From: Jonathan @ 2020-12-16 16:53 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 45011
[-- Attachment #1: Type: text/plain, Size: 4197 bytes --]
hello??
On Tue, Dec 8, 2020 at 11:34 AM Jonathan <rostranjj@gmail.com> wrote:
> From fb50c9d2de0e4896dc679b217f3cf66c3214e044 Mon Sep 17 00:00:00 2001
> From: wario <rostranjj@gmail.com>
> Date: Tue, 8 Dec 2020 11:33:49 -0600
> Subject: [PATCH] gnu: Add emacs-project *gnu/packages/emacs-xyz.scm
> (emacs-project): New variable.
>
> ---
> gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 6999265a0e..e15c7650e2 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -342,6 +342,31 @@ for those who may want transient periods of
> unbalanced parentheses, such as
> when typing parentheses directly or commenting out code line by line.")
> (license license:gpl3+)))
>
> +(define-public emacs-project
> + (package
> + (name "emacs-project")
> + (version "0.5.2")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://elpa.gnu.org/packages/project-"
> + version
> + ".el"))
> + (sha256
> + (base32
> + "181hls4phhj8kgpfcky6h0mgzpl9xj616abvcvx8mrn4nmpyh655"))))
> + (build-system emacs-build-system)
> + (propagated-inputs `(("emacs-xref" ,emacs-xref)))
> + (home-page
> + "http://elpa.gnu.org/packages/project.html")
> + (synopsis "Operations on the current project")
> + (description
> + "This file contains generic infrastructure for dealing with
> +projects, some utility functions, and commands using that
> +infrastructure.")
> + (license license:gpl3+)))
> +
> (define-public git-modes
> (package
> (name "emacs-git-modes")
> --
> 2.29.2
>
>
>
> On Tue, Dec 8, 2020 at 11:31 AM Jonathan <rostranjj@gmail.com> wrote:
>
>> From 1e2a8d0eefd02bbec2ad6366c312dab3c635cba1 Mon Sep 17 00:00:00 2001
>> From: wario <rostranjj@gmail.com>
>> Date: Tue, 8 Dec 2020 11:29:55 -0600
>> Subject: [PATCH] gnu: Add emacs-xref. *gnu/packages/emacs-xyz.scm
>> (emacs-xref): New variable.
>>
>> ---
>> gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
>> 1 file changed, 23 insertions(+)
>>
>> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
>> index e2658b4547..6999265a0e 100644
>> --- a/gnu/packages/emacs-xyz.scm
>> +++ b/gnu/packages/emacs-xyz.scm
>> @@ -87,6 +87,7 @@
>> ;;; Copyright © 2020 Noah Landis <noahlandis@posteo.net>
>> ;;; Copyright © 2020 Nicolò Balzarotti <nicolo@nixo.xyz>
>> ;;; Copyright © 2020 André A. Gomes <andremegafone@gmail.com>
>> +;;; Copyright © 2020 Jonathan Rostran <rostranjj@gmail.com>
>> ;;;
>> ;;; This file is part of GNU Guix.
>> ;;;
>> @@ -25768,3 +25769,25 @@ anymore. In this way, it's like a lightweight
>> \"workspace\" manager, allowing
>> you to easily restore one or more frames, including their windows, the
>> windows' layout, and their buffers.")
>> (license license:gpl3+)))
>> +
>> +(define-public emacs-xref
>> + (package
>> + (name "emacs-xref")
>> + (version "1.0.3")
>> + (source
>> + (origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "https://elpa.gnu.org/packages/xref-"
>> + version
>> + ".el"))
>> + (sha256
>> + (base32
>> + "1r531gl73y1br8g4n77gxbyj26yiaw7snjad21fgs5m80cka8fi3"))))
>> + (build-system emacs-build-system)
>> + (home-page
>> + "http://elpa.gnu.org/packages/xref.html")
>> + (synopsis "Cross-referencing commands")
>> + (description "This file provides a somewhat generic infrastructure for
>> cross
>> +referencing commands, in particular \"find-definition\".")
>> + (license license:gpl3+)))
>> --
>> 2.29.2
>>
>>
>>
>> On Tue, Dec 8, 2020 at 1:26 AM Nicolas Goaziou <mail@nicolasgoaziou.fr>
>> wrote:
>>
>>> Hello,
>>>
>>> Jonathan <rostranjj@gmail.com> writes:
>>>
>>> > It does for me but as an email, with the subject filled in with the
>>> > commit message. I only copied the body. Should I send the entire file?
>>>
>>> I think so.
>>>
>>> Regards,
>>> --
>>> Nicolas Goaziou
>>>
>>
[-- Attachment #2: Type: text/html, Size: 6056 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* [bug#45011] [PATCH] add emacs-project and dependency
2020-12-04 20:12 ` Nicolas Goaziou
2020-12-05 18:18 ` Jonathan
@ 2020-12-05 19:41 ` Jonathan
2020-12-05 19:42 ` Jonathan
2 siblings, 0 replies; 14+ messages in thread
From: Jonathan @ 2020-12-05 19:41 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 45011
[-- Attachment #1: Type: text/plain, Size: 3605 bytes --]
---
gnu/packages/emacs-xyz.scm | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5eb8f7c1ea..8a3414d123 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -86,6 +86,7 @@
;;; Copyright © 2020 Tim Howes <timhowes@lavabit.com>
;;; Copyright © 2020 Noah Landis <noahlandis@posteo.net>
;;; Copyright © 2020 Nicolò Balzarotti <nicolo@nixo.xyz>
+;;; Copyright © 2020 Jonathan Rostran <rostranjj@gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -25754,3 +25755,33 @@ syntax highlighting and UI components.")
"This Emacs package provides a Janet REPL to evaluate
@code{janet-mode}
s-expression.")
(license license:expat))))
+
+(define-public emacs-xref
+ (package
+ (name "emacs-xref")
+ (version "1.0.3")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://elpa.gnu.org/packages/xref-"
+ version
+ ".el"))
+ (sha256
+ (base32
+ "1r531gl73y1br8g4n77gxbyj26yiaw7snjad21fgs5m80cka8fi3"))))
+ (build-system emacs-build-system)
+ (home-page
+ "http://elpa.gnu.org/packages/xref.html")
+ (synopsis "Cross-referencing commands")
+ (description
+ "NOTE: The xref API is still experimental and can change in major,
+backward-incompatible ways. Everyone is encouraged to try it, and
+report to us any problems or use cases we hadn't anticipated, by
+sending an email to emacs-devel, or `M-x report-emacs-bug'.
+
+This file provides a somewhat generic infrastructure for cross
+referencing commands, in particular \"find-definition\".
+
+See the etags and elisp-mode implementations for full examples.")
+ (license license:gpl3+)))
--
2.29.2
On Fri, Dec 4, 2020 at 2:12 PM Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:
> Hello,
>
> Jonathan <rostranjj@gmail.com> writes:
>
> > gnu/packages/emacs-xyz.scm | 61 ++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 61 insertions(+)
>
> Thank you!
>
> Could you write a commit message to introduce your changes? You can look
> at those starting with "Add ..." in the code base.
>
> Also, could you split it into two patches, one for each package?
>
> > + (synopsis "Operations on the current project")
> > + (description
> > + "NOTE: The project API is still experimental and can change in major,
> > +backward-incompatible ways. Everyone is encouraged to try it, and
> > +report to us any problems or use cases we hadn't anticipated, by
> > +sending an email to emacs-devel, or `M-x report-emacs-bug'.
> > +
> > +This file contains generic infrastructure for dealing with
> > +projects, some utility functions, and commands using that
> > +infrastructure.")
>
> The synopsis could be clarified, so could the description. In
> particular, the latter explains what the library is about.
>
> > + (description
> > + "NOTE: The xref API is still experimental and can change in major,
> > +backward-incompatible ways. Everyone is encouraged to try it, and
> > +report to us any problems or use cases we hadn't anticipated, by
> > +sending an email to emacs-devel, or `M-x report-emacs-bug'.
> > +
> > +This file provides a somewhat generic infrastructure for cross
> > +referencing commands, in particular \"find-definition\".
> > +
> > +See the etags and elisp-mode implementations for full examples.")
>
> Ditto.
>
> Could you send an updated patch?
>
> Regards,
> --
> Nicolas Goaziou
>
[-- Attachment #2: Type: text/html, Size: 4766 bytes --]
^ permalink raw reply related [flat|nested] 14+ messages in thread* [bug#45011] [PATCH] add emacs-project and dependency
2020-12-04 20:12 ` Nicolas Goaziou
2020-12-05 18:18 ` Jonathan
2020-12-05 19:41 ` [bug#45011] " Jonathan
@ 2020-12-05 19:42 ` Jonathan
2 siblings, 0 replies; 14+ messages in thread
From: Jonathan @ 2020-12-05 19:42 UTC (permalink / raw)
To: Nicolas Goaziou; +Cc: 45011
[-- Attachment #1: Type: text/plain, Size: 3177 bytes --]
---
gnu/packages/emacs-xyz.scm | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 8a3414d123..b056f05688 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -730,6 +730,33 @@ this one is much simpler and much more consistent.
When using this package,
then only the color of the mode line changes when a window becomes
in-/active.")
(license license:gpl3+)))
+(define-public emacs-project
+ (package
+ (name "emacs-project")
+ (version "0.5.2")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append
+ "https://elpa.gnu.org/packages/project-"
+ version
+ ".el"))
+ (sha256
+ (base32
+ "181hls4phhj8kgpfcky6h0mgzpl9xj616abvcvx8mrn4nmpyh655"))))
+ (build-system emacs-build-system)
+ (propagated-inputs `(("emacs-xref" ,emacs-xref)))
+ (home-page
+ "http://elpa.gnu.org/packages/project.html")
+ (synopsis "This file contains generic infrastructure for dealing with
+projects, some utility functions, and commands using that
+infrastructure.")
+ (description
+ "The goal is to make it easier for Lisp programs to operate on the
+current project, without having to know which package handles
+detection of that project type, parsing its config files, etc.")
+ (license license:gpl3+)))
+
(define-public emacs-treepy
(package
(name "emacs-treepy")
--
2.29.2
On Fri, Dec 4, 2020 at 2:12 PM Nicolas Goaziou <mail@nicolasgoaziou.fr>
wrote:
> Hello,
>
> Jonathan <rostranjj@gmail.com> writes:
>
> > gnu/packages/emacs-xyz.scm | 61 ++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 61 insertions(+)
>
> Thank you!
>
> Could you write a commit message to introduce your changes? You can look
> at those starting with "Add ..." in the code base.
>
> Also, could you split it into two patches, one for each package?
>
> > + (synopsis "Operations on the current project")
> > + (description
> > + "NOTE: The project API is still experimental and can change in major,
> > +backward-incompatible ways. Everyone is encouraged to try it, and
> > +report to us any problems or use cases we hadn't anticipated, by
> > +sending an email to emacs-devel, or `M-x report-emacs-bug'.
> > +
> > +This file contains generic infrastructure for dealing with
> > +projects, some utility functions, and commands using that
> > +infrastructure.")
>
> The synopsis could be clarified, so could the description. In
> particular, the latter explains what the library is about.
>
> > + (description
> > + "NOTE: The xref API is still experimental and can change in major,
> > +backward-incompatible ways. Everyone is encouraged to try it, and
> > +report to us any problems or use cases we hadn't anticipated, by
> > +sending an email to emacs-devel, or `M-x report-emacs-bug'.
> > +
> > +This file provides a somewhat generic infrastructure for cross
> > +referencing commands, in particular \"find-definition\".
> > +
> > +See the etags and elisp-mode implementations for full examples.")
>
> Ditto.
>
> Could you send an updated patch?
>
> Regards,
> --
> Nicolas Goaziou
>
[-- Attachment #2: Type: text/html, Size: 4222 bytes --]
^ permalink raw reply related [flat|nested] 14+ messages in thread