From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2BhrK6LwzF8dLgAA0tVLHw (envelope-from ) for ; Sun, 06 Dec 2020 14:54:26 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id gAVYJ6LwzF+KDAAA1q6Kng (envelope-from ) for ; Sun, 06 Dec 2020 14:54:26 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 496C99401BF for ; Sun, 6 Dec 2020 14:54:26 +0000 (UTC) Received: from localhost ([::1]:38116 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klvQf-0001bS-6Q for larch@yhetil.org; Sun, 06 Dec 2020 09:54:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34456) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klvQJ-0001b6-Bi for guix-patches@gnu.org; Sun, 06 Dec 2020 09:54:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:37775) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1klvQI-0005WG-Al for guix-patches@gnu.org; Sun, 06 Dec 2020 09:54:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1klvQI-0007a8-A2 for guix-patches@gnu.org; Sun, 06 Dec 2020 09:54:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45011] [PATCH] add emacs-project and dependency Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 06 Dec 2020 14:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45011 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jonathan Cc: 45011@debbugs.gnu.org Received: via spool by 45011-submit@debbugs.gnu.org id=B45011.160726640329099 (code B ref 45011); Sun, 06 Dec 2020 14:54:02 +0000 Received: (at 45011) by debbugs.gnu.org; 6 Dec 2020 14:53:23 +0000 Received: from localhost ([127.0.0.1]:49321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klvPf-0007ZH-1t for submit@debbugs.gnu.org; Sun, 06 Dec 2020 09:53:23 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:40815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klvPd-0007Z3-0r for 45011@debbugs.gnu.org; Sun, 06 Dec 2020 09:53:21 -0500 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id C7576C0005; Sun, 6 Dec 2020 14:53:13 +0000 (UTC) From: Nicolas Goaziou References: <87lfedpby8.fsf@nicolasgoaziou.fr> Date: Sun, 06 Dec 2020 15:53:12 +0100 In-Reply-To: (Jonathan's message of "Sat, 5 Dec 2020 12:18:29 -0600") Message-ID: <874kkz0yw7.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.30 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 496C99401BF X-Spam-Score: -2.30 X-Migadu-Scanner: ns3122888.ip-94-23-21.eu X-TUID: DDaN9aHOQq1P Hello, Jonathan writes: > The descriptions are the ones found in their project's homepage. Well, sometimes, even upstream descriptions need to be reworded. > I can't think of a better synopsis for Project since it provides > several functions to operate on a project directory... Do you have > a suggestion?. Unfortunately, no. My concern is that I don't know what this package is about, and the synopsis doesn't help me finding it out. Maybe the term "project" is too vague. Note that the synopsis must fit on a single line, and is not a full sentence. You may want to run "guix lint" on your package definition. Also, I suggest to remove the big note at the beginning of each description. It may make sense as a foreword in a project home page, but I don't think it does when describing the software. > Which patch do you want first? emacs-xref is needed for emacs-project. Do > you want me to send emacs-xref first? Sure. I see you send new patches. Could you integrate the suggestion above, and include a proper commit message, like the following: gnu: Add emacs-xref. * gnu/packages/emacs-xyz.scm (emacs-xref): New variable. ? Thanks! Regards, -- Nicolas Goaziou