all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice <tobias.geerinckx.rice@gmail.com>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: simple-scan: Update to 3.19.91.
Date: Wed, 9 Mar 2016 01:25:04 +0100	[thread overview]
Message-ID: <CAKFHe2Qbr=ZD8cYi8_hJAwDhtEs0t9q61FGL3HR4vsBC2aYsMQ@mail.gmail.com> (raw)
In-Reply-To: <20160309000506.GD24107@jasmine>

Firstly, thanks for the feedback!

On 09/03/2016, Leo Famulari <leo@famulari.name> wrote:
>> I therefore simply disabled it.
>
> I think that lots of software in our distribution has unused features or
> portability "goop" that doesn't apply to us, but we don't delete that
> code.

Running ‘./configure --disable-*’ isn't deleting code. The rest is a bugfix.

> So, it fails to build from source if you don't delete this file?

Correct.

> I still don't understand why we should delete the source file.

Because it fails to build from source if we don't.

Again, this is a stale (generated) file. Did you read the linked bug report?

There are various ways to code this, but none that don't amount to
deleting (generated) source files.[1]

> After searching online for "packagekit simple scan" I found the Nix
> package definition for Simple Scan 3.19.91. They

For the record: me.

> [...] pass to ./configure '--disable-packagekit'. Would that work?

So do ‘we’:

On Tue, Mar 08, 2016 at 11:04:35PM +0100, Tobias Geerinckx-Rice wrote:
> '(#:configure-flags '("--disable-packagekit")

But that alone is not enough. Not without removing the stale file.

Kind regards,

T G-R (nckx on #guix in about a quarter of an hour, if that helps :-)

[1] OK, ‘touch’ing random things, but that's just fooling make into
overwriting it, which is the same thing.

  reply	other threads:[~2016-03-09  0:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08 22:04 [PATCH] gnu: simple-scan: Update to 3.19.91 Tobias Geerinckx-Rice
2016-03-08 23:02 ` Leo Famulari
2016-03-08 23:43   ` Tobias Geerinckx-Rice
2016-03-08 23:50     ` Tobias Geerinckx-Rice
2016-03-09  0:05     ` Leo Famulari
2016-03-09  0:25       ` Tobias Geerinckx-Rice [this message]
2016-03-09  1:39         ` Leo Famulari
2016-03-09  7:49           ` Leo Famulari
2016-03-09 13:28             ` Ludovic Courtès
2016-03-09 20:56               ` Leo Famulari
2016-03-12 20:33                 ` Danny Milosavljevic
2016-03-13 10:34                   ` Danny Milosavljevic
2016-03-13 16:27                     ` Tobias Geerinckx-Rice

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKFHe2Qbr=ZD8cYi8_hJAwDhtEs0t9q61FGL3HR4vsBC2aYsMQ@mail.gmail.com' \
    --to=tobias.geerinckx.rice@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.