From: ludo@gnu.org (Ludovic Courtès)
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: simple-scan: Update to 3.19.91.
Date: Wed, 09 Mar 2016 14:28:03 +0100 [thread overview]
Message-ID: <87fuvzdbmk.fsf@gnu.org> (raw)
In-Reply-To: <20160309074914.GA18130@jasmine> (Leo Famulari's message of "Wed, 9 Mar 2016 02:49:14 -0500")
Leo Famulari <leo@famulari.name> skribis:
> On Tue, Mar 08, 2016 at 08:39:37PM -0500, Leo Famulari wrote:
>> On Wed, Mar 09, 2016 at 01:25:04AM +0100, Tobias Geerinckx-Rice wrote:
>> > On 09/03/2016, Leo Famulari <leo@famulari.name> wrote:
>> > > [...] pass to ./configure '--disable-packagekit'. Would that work?
>> >
>> > So do ‘we’:
>> >
>> > On Tue, Mar 08, 2016 at 11:04:35PM +0100, Tobias Geerinckx-Rice wrote:
>> > > '(#:configure-flags '("--disable-packagekit")
>>
>> Oops! Serves me right for trying to squeeze this review in earlier ;)
>>
>> > There are various ways to code this, but none that don't amount to
>> > deleting (generated) source files.[1]
>>
>> I didn't realize this was generated C code. In that case it's closer to
>> a compiled binary than source code, don't you think? Can we delete all
>> the generated files and rebuild them from source?
>
> Anyways, that is probably something to look into later. I think it makes
> sense to do this update, remove that file, and include a link to the bug
> report with a bit of context.
>
> Does anyone have any objections to that plan?
I’m not sure I fully grasped everything, but the plan looks good. And
since it’s an update and the problem was already there, let’s not annoy
Tobias more than this. :-)
Eventually, I agree it’ll be best to remove the generated C files,
though.
Ludo’.
next prev parent reply other threads:[~2016-03-09 13:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 22:04 [PATCH] gnu: simple-scan: Update to 3.19.91 Tobias Geerinckx-Rice
2016-03-08 23:02 ` Leo Famulari
2016-03-08 23:43 ` Tobias Geerinckx-Rice
2016-03-08 23:50 ` Tobias Geerinckx-Rice
2016-03-09 0:05 ` Leo Famulari
2016-03-09 0:25 ` Tobias Geerinckx-Rice
2016-03-09 1:39 ` Leo Famulari
2016-03-09 7:49 ` Leo Famulari
2016-03-09 13:28 ` Ludovic Courtès [this message]
2016-03-09 20:56 ` Leo Famulari
2016-03-12 20:33 ` Danny Milosavljevic
2016-03-13 10:34 ` Danny Milosavljevic
2016-03-13 16:27 ` Tobias Geerinckx-Rice
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fuvzdbmk.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.