From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tobias Geerinckx-Rice Subject: Re: [PATCH] gnu: simple-scan: Update to 3.19.91. Date: Wed, 9 Mar 2016 01:25:04 +0100 Message-ID: References: <1457474675-21775-1-git-send-email-tobias.geerinckx.rice@gmail.com> <20160308230232.GA24107@jasmine> <20160309000506.GD24107@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42782) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adRw2-0007XK-3j for guix-devel@gnu.org; Tue, 08 Mar 2016 19:25:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adRw1-0001xF-4i for guix-devel@gnu.org; Tue, 08 Mar 2016 19:25:06 -0500 Received: from mail-oi0-x22c.google.com ([2607:f8b0:4003:c06::22c]:34252) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adRw0-0001wr-VP for guix-devel@gnu.org; Tue, 08 Mar 2016 19:25:05 -0500 Received: by mail-oi0-x22c.google.com with SMTP id m82so23760192oif.1 for ; Tue, 08 Mar 2016 16:25:04 -0800 (PST) In-Reply-To: <20160309000506.GD24107@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Leo Famulari Cc: guix-devel@gnu.org Firstly, thanks for the feedback! On 09/03/2016, Leo Famulari wrote: >> I therefore simply disabled it. > > I think that lots of software in our distribution has unused features or > portability "goop" that doesn't apply to us, but we don't delete that > code. Running =E2=80=98./configure --disable-*=E2=80=99 isn't deleting code. The = rest is a bugfix. > So, it fails to build from source if you don't delete this file? Correct. > I still don't understand why we should delete the source file. Because it fails to build from source if we don't. Again, this is a stale (generated) file. Did you read the linked bug report= ? There are various ways to code this, but none that don't amount to deleting (generated) source files.[1] > After searching online for "packagekit simple scan" I found the Nix > package definition for Simple Scan 3.19.91. They For the record: me. > [...] pass to ./configure '--disable-packagekit'. Would that work? So do =E2=80=98we=E2=80=99: On Tue, Mar 08, 2016 at 11:04:35PM +0100, Tobias Geerinckx-Rice wrote: > '(#:configure-flags '("--disable-packagekit") But that alone is not enough. Not without removing the stale file. Kind regards, T G-R (nckx on #guix in about a quarter of an hour, if that helps :-) [1] OK, =E2=80=98touch=E2=80=99ing random things, but that's just fooling m= ake into overwriting it, which is the same thing.