From: Eric Bavier <bavier@cray.com>
To: "29492-done@debbugs.gnu.org" <29492-done@debbugs.gnu.org>
Subject: bug#29492: tests/guix-system.sh failure on unbound variable check
Date: Mon, 4 Dec 2017 15:37:19 +0000 [thread overview]
Message-ID: <BN6PR11MB1716527888BBCB0A84CB233BB73C0@BN6PR11MB1716.namprd11.prod.outlook.com> (raw)
In-Reply-To: <87d13x30wy.fsf@gnu.org>
Pushed in 42d16037d857aac02add38513bfa58535c1ddcfe
Thanks,
Eric Bavier, Scientific Libraries, Cray Inc.
________________________________________
From: Ludovic Courtès <ludo@gnu.org>
Sent: Saturday, December 2, 2017 03:59
To: Eric Bavier
Cc: '29492@debbugs.gnu.org'
Subject: Re: bug#29492: tests/guix-system.sh failure on unbound variable check
Eric Bavier <bavier@cray.com> skribis:
>> -----Original Message-----
>> From: Ludovic Courtès [mailto:ludo@gnu.org]
>> Sent: Thursday, November 30, 2017 4:04 AM
>> To: Eric Bavier
>> Cc: 29492@debbugs.gnu.org
>> Subject: Re: bug#29492: tests/guix-system.sh failure on unbound variable
>> check
>>
>> Hi Eric,
>>
>> Eric Bavier <bavier@cray.com> skribis:
>>
>> > Latest guix master (2cdf78df2d3d5d88c7e6908754233cf37cce1e61) fails
>> tests/guix-system.sh for me, on line 128. This seems to be caused by the
>> fact that the error output contains a multi-character column number:
>> >
>> > ```
>> > /tmp/bavier/tmpfile:9:14: In procedure #<procedure 3aba2820 ()>:
>> > /tmp/bavier/tmpfile:9:14: GRUB-config: unbound variable
>> > hint: Did you forget a `use-modules' form?
>>
>> I suppose that’s with Guile 2.0, right?
>
> Right, 2.0.14.
>
>> So the patch would become:
>
> diff --git a/tests/guix-system.sh b/tests/guix-system.sh
> index 4bb866adf..eaa0c4332 100644
> --- a/tests/guix-system.sh
> +++ b/tests/guix-system.sh
> @@ -125,7 +125,8 @@ else
> # See <http://bugs.gnu.org/26107>.
> grep "$tmpfile:[49]:[0-9]: GRUB-config.*[Uu]nbound variable" "$errorfile"
> else
> - grep "$tmpfile:9:[0-9]: GRUB-config.*[Uu]nbound variable" "$errorfile"
> + # With Guile 2.0.14 the error is reported on line 14 (the last line).
> + grep "$tmpfile:9:[0-9]\+: GRUB-config.*[Uu]nbound variable" "$errorfile"
> fi
> fi
>
> No, at *column* 14. Which I believe is the desired result, right? Character 14 is the '(', the 'GRUB-config symbol itself starts at character 15. But now I wonder whether we should be using a regex for that anyhow. Do we expect the column number to change ever?
We don’t, but sometimes location info is not as precise as we’d like.
> I think it would be fine to fix the regex for Guile 2.0 only, but once the bug affecting 2.2 is fixed, it'll need to be applied there too. Maybe it would make sense to fix both at the same time.
Yes, you’re right, it’s better to fix both.
Feel free to push.
Thank you!
Ludo’.
prev parent reply other threads:[~2017-12-04 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 19:25 bug#29492: tests/guix-system.sh failure on unbound variable check Eric Bavier
2017-11-30 10:04 ` Ludovic Courtès
2017-12-01 23:28 ` Eric Bavier
2017-12-02 9:59 ` Ludovic Courtès
2017-12-04 15:37 ` Eric Bavier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN6PR11MB1716527888BBCB0A84CB233BB73C0@BN6PR11MB1716.namprd11.prod.outlook.com \
--to=bavier@cray.com \
--cc=29492-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.