From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: bug#29492: tests/guix-system.sh failure on unbound variable check Date: Mon, 4 Dec 2017 15:37:19 +0000 Message-ID: References: <87vahs5bh2.fsf@gnu.org> , <87d13x30wy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eLsoo-0001xf-CI for bug-guix@gnu.org; Mon, 04 Dec 2017 10:38:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eLsol-0005RK-2Z for bug-guix@gnu.org; Mon, 04 Dec 2017 10:38:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:36952) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eLsok-0005R2-LE for bug-guix@gnu.org; Mon, 04 Dec 2017 10:38:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eLsok-0001oA-Fw for bug-guix@gnu.org; Mon, 04 Dec 2017 10:38:02 -0500 Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Message-ID: In-Reply-To: <87d13x30wy.fsf@gnu.org> Content-Language: en-US List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: "29492-done@debbugs.gnu.org" <29492-done@debbugs.gnu.org> Pushed in 42d16037d857aac02add38513bfa58535c1ddcfe Thanks, Eric Bavier, Scientific Libraries, Cray Inc. ________________________________________ From: Ludovic Court=E8s Sent: Saturday, December 2, 2017 03:59 To: Eric Bavier Cc: '29492@debbugs.gnu.org' Subject: Re: bug#29492: tests/guix-system.sh failure on unbound variable ch= eck Eric Bavier skribis: >> -----Original Message----- >> From: Ludovic Court=E8s [mailto:ludo@gnu.org] >> Sent: Thursday, November 30, 2017 4:04 AM >> To: Eric Bavier >> Cc: 29492@debbugs.gnu.org >> Subject: Re: bug#29492: tests/guix-system.sh failure on unbound variable >> check >> >> Hi Eric, >> >> Eric Bavier skribis: >> >> > Latest guix master (2cdf78df2d3d5d88c7e6908754233cf37cce1e61) fails >> tests/guix-system.sh for me, on line 128. This seems to be caused by th= e >> fact that the error output contains a multi-character column number: >> > >> > ``` >> > /tmp/bavier/tmpfile:9:14: In procedure #: >> > /tmp/bavier/tmpfile:9:14: GRUB-config: unbound variable >> > hint: Did you forget a `use-modules' form? >> >> I suppose that=92s with Guile 2.0, right? > > Right, 2.0.14. > >> So the patch would become: > > diff --git a/tests/guix-system.sh b/tests/guix-system.sh > index 4bb866adf..eaa0c4332 100644 > --- a/tests/guix-system.sh > +++ b/tests/guix-system.sh > @@ -125,7 +125,8 @@ else > # See . > grep "$tmpfile:[49]:[0-9]: GRUB-config.*[Uu]nbound variable" "$erro= rfile" > else > - grep "$tmpfile:9:[0-9]: GRUB-config.*[Uu]nbound variable" "$errorfi= le" > + # With Guile 2.0.14 the error is reported on line 14 (the last line= ). > + grep "$tmpfile:9:[0-9]\+: GRUB-config.*[Uu]nbound variable" "$error= file" > fi > fi > > No, at *column* 14. Which I believe is the desired result, right? Chara= cter 14 is the '(', the 'GRUB-config symbol itself starts at character 15. = But now I wonder whether we should be using a regex for that anyhow. Do = we expect the column number to change ever? We don=92t, but sometimes location info is not as precise as we=92d like. > I think it would be fine to fix the regex for Guile 2.0 only, but once th= e bug affecting 2.2 is fixed, it'll need to be applied there too. Maybe it= would make sense to fix both at the same time. Yes, you=92re right, it=92s better to fix both. Feel free to push. Thank you! Ludo=92.