From: ludo@gnu.org (Ludovic Courtès)
To: Eric Bavier <bavier@cray.com>
Cc: 29492@debbugs.gnu.org
Subject: bug#29492: tests/guix-system.sh failure on unbound variable check
Date: Thu, 30 Nov 2017 11:04:25 +0100 [thread overview]
Message-ID: <87vahs5bh2.fsf@gnu.org> (raw)
In-Reply-To: <CY4PR11MB17188515B596D27AFBF0643BB73A0@CY4PR11MB1718.namprd11.prod.outlook.com> (Eric Bavier's message of "Tue, 28 Nov 2017 19:25:03 +0000")
[-- Attachment #1: Type: text/plain, Size: 528 bytes --]
Hi Eric,
Eric Bavier <bavier@cray.com> skribis:
> Latest guix master (2cdf78df2d3d5d88c7e6908754233cf37cce1e61) fails tests/guix-system.sh for me, on line 128. This seems to be caused by the fact that the error output contains a multi-character column number:
>
> ```
> /tmp/bavier/tmpfile:9:14: In procedure #<procedure 3aba2820 ()>:
> /tmp/bavier/tmpfile:9:14: GRUB-config: unbound variable
> hint: Did you forget a `use-modules' form?
I suppose that’s with Guile 2.0, right?
So the patch would become:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 527 bytes --]
diff --git a/tests/guix-system.sh b/tests/guix-system.sh
index 4bb866adf..eaa0c4332 100644
--- a/tests/guix-system.sh
+++ b/tests/guix-system.sh
@@ -125,7 +125,8 @@ else
# See <http://bugs.gnu.org/26107>.
grep "$tmpfile:[49]:[0-9]: GRUB-config.*[Uu]nbound variable" "$errorfile"
else
- grep "$tmpfile:9:[0-9]: GRUB-config.*[Uu]nbound variable" "$errorfile"
+ # With Guile 2.0.14 the error is reported on line 14 (the last line).
+ grep "$tmpfile:9:[0-9]\+: GRUB-config.*[Uu]nbound variable" "$errorfile"
fi
fi
[-- Attachment #3: Type: text/plain, Size: 57 bytes --]
Please push if it works for you.
Thanks,
Ludo’.
next prev parent reply other threads:[~2017-11-30 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 19:25 bug#29492: tests/guix-system.sh failure on unbound variable check Eric Bavier
2017-11-30 10:04 ` Ludovic Courtès [this message]
2017-12-01 23:28 ` Eric Bavier
2017-12-02 9:59 ` Ludovic Courtès
2017-12-04 15:37 ` Eric Bavier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vahs5bh2.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=29492@debbugs.gnu.org \
--cc=bavier@cray.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.