From: Pavel Shlyak <p.shlyak@pantherx.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 58125@debbugs.gnu.org
Subject: [bug#58125] [PATCH] gnu: Add nm-tray
Date: Wed, 5 Oct 2022 17:46:50 +0300 [thread overview]
Message-ID: <B3041DBE-037B-4B6B-AB89-C2A6FF356D73@pantherx.org> (raw)
In-Reply-To: <4fd51401-ad69-b33b-662b-f5e59ca11b46@telenet.be>
[-- Attachment #1: Type: text/plain, Size: 3582 bytes --]
> Except for the initial line(?), the commit message is for tor the Subject line (-:.
I didn’t get you
> Please write the actual copyright holder (likely the relevant members of this team or perhaps their employer, depending on how things are set up) -- AFAIK, "PantherX OS Team" is a not some legal entity that can hold copyright.
Done
> I don't think this module should unconditionally import that, to help with keeping "guix ... package" fast when the kde-frameworks isn't actually used.
I didn’t get that, too
> Could you add some information, more specifically something to distinguish nm-applet from nm-applet? Currently, it doesn't give any information that helps the user with choosing between nm-tray nad nm-applet.
Done
> Why? AFAICT, there are no git submodules.
True
> Can you test that icons are displayed properly in a pure environment ("guix shell --pure nm-tray -- …»)?
They are not. I don’t know how to get them to work.
> could you set WITH_MODEMMANAGER_SUPPORT?
It looks like it’s not yet implemented in the app. Instead, I have removed modem manager from inputs.
> 29 сент. 2022 г., в 19:29, Maxime Devos <maximedevos@telenet.be> написал(а):
>
>> Subject: [PATCH] gnu: Add nm-tray * gnu/packages/networking.scm (nm-tray): New
>> variable.
>
> Except for the initial line(?), the commit message is for tor the Subject line (-:.
>
> On 27-09-2022 22:49, Pavel Shlyak wrote:
>
> > + ;;; Copyright © 2020-2022 PantherX OS Team <team@pantherx.org>
>
> Please write the actual copyright holder (likely the relevant members of this team or perhaps their employer, depending on how things are set up) -- AFAIK, "PantherX OS Team" is a not some legal entity that can hold copyright.
>
> In both cases, I think we should investigate whether something like <https://www.samba.org/samba/devel/copyright-policy.html> should be done in Guix first.
>
> > +++ b/gnu/packages/networking.scm
> > + #:use-module (gnu packages kde-frameworks)
>
> I don't think this module should unconditionally import that, to help with keeping "guix ... package" fast when the kde-frameworks isn't actually used.
>
> I have tried out some tricks in <https://issues.guix.gnu.org/54539> -- while there doesn't seem to have been any conclusion on what's the 'proper' trick, there are some options -- see, e.g., how https://issues.guix.gnu.org/57861 uses module-ref.
>
>
>> + (synopsis "NetworkManager front end with information icon residing in system tray")
>> + (description "nm-tray is a network connection management tool (NetworkManager front end)
>> +with information icon residing in system tray (like e.g. nm-applet).")
>
> Could you add some information, more specifically something to distinguish nm-applet from nm-applet? Currently, it doesn't give any information that helps the user with choosing between nm-tray nad nm-applet.
>
>> + (recursive? #t)))
>
> Why? AFAICT, there are no git submodules.
>
> Looking through the source code, it appears to use icons. Can you test that icons are displayed properly in a pure environment ("guix shell --pure nm-tray -- ...")? Sometimes graphical software doesn't find its icons without some help.
>
> Looking at CMakeLists.txt, it comes with optional modem manager support, for which you seem to have added modemmanager-qt, but from reading CMakeLists.txt, it doesn't seem to be enabled by default, could you set WITH_MODEMMANAGER_SUPPORT?
>
> Greetings,
> Maxime.
> <OpenPGP_0x49E3EE22191725EE.asc>
[-- Attachment #2.1: Type: text/html, Size: 4118 bytes --]
[-- Attachment #2.2: 0001-gnu-Add-nm-tray.patch --]
[-- Type: application/octet-stream, Size: 3632 bytes --]
From a9473671cbbcf7c97495a4d65070006feb80f09b Mon Sep 17 00:00:00 2001
From: Pavel Shlyak <p.shlyak@pantherx.org>
Date: Tue, 27 Sep 2022 23:45:08 +0300
Subject: [PATCH] gnu: Add nm-tray
* gnu/packages/networking.scm (nm-tray): New variable.
---
gnu/packages/networking.scm | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index 3d9ba4fc8d..378651e100 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -40,6 +40,7 @@
;;; Copyright © 2020 Jesse Dowell <jessedowell@gmail.com>
;;; Copyright © 2020 Hamzeh Nasajpour <h.nasajpour@pantherx.org>
;;; Copyright © 2020, 2022 Michael Rohleder <mike@rohleder.de>
+;;; Copyright © 2021 Fakhri Sajadi <f.sajadi@pantherx.org>
;;; Copyright © 2021 Hartmut Goebel <h.goebel@crazy-compilers.com>
;;; Copyright © 2021 Justin Veilleux <terramorpha@cock.li>
;;; Copyright © 2021 Vinicius Monego <monego@posteo.net>
@@ -48,9 +49,11 @@
;;; Copyright © 2021 Guillaume Le Vaillant <glv@posteo.net>
;;; Copyright © 2021 Maxime Devos <maximedevos@telenet.be>
;;; Copyright © 2022 Simon South <simon@simonsouth.net>
+;;; Copyright © 2022 Pavel Shlyak <p.shlyak@pantherx.org>
;;; Copyright © 2022 Pierre Langlois <pierre.langlois@gmx.com>
;;; Copyright © 2022 Petr Hodina <phodina@protonmail.com>
;;; Copyright © 2022 Manolis Fragkiskos Ragkousis <manolis837@gmail.com>
+;;; Copyright © 2022 Reza Alizadeh Majd <r.majd@pantherx.org>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -80,6 +83,7 @@ (define-module (gnu packages networking)
#:use-module (guix build-system meson)
#:use-module (guix build-system perl)
#:use-module (guix build-system python)
+ #:use-module (guix build-system qt)
#:use-module (guix build-system trivial)
#:use-module (guix utils)
#:use-module (gnu packages)
@@ -115,6 +119,7 @@ (define-module (gnu packages networking)
#:use-module (gnu packages gstreamer)
#:use-module (gnu packages gtk)
#:use-module (gnu packages image)
+ #:use-module (gnu packages kde-frameworks)
#:use-module (gnu packages libevent)
#:use-module (gnu packages libidn)
#:use-module (gnu packages libusb)
@@ -973,6 +978,30 @@ (define-public blueman
(home-page "https://github.com/blueman-project/blueman")
(license license:gpl3+)))
+(define-public nm-tray
+ (package
+ (name "nm-tray")
+ (version "0.5.0")
+ (home-page "https://github.com/palinek/nm-tray")
+ (source
+ (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url home-page)
+ (commit version)))
+ (sha256
+ (base32 "14i8sl0hrnyidlvqnxza0v4018f7p685ksn8419i2w7f9yqpvpiw"))
+ (file-name (git-file-name name version))))
+ (build-system qt-build-system)
+ (arguments (list #:tests? #f)) ; There are no tests upstream
+ (inputs (list qtbase-5 networkmanager-qt))
+ (native-inputs (list qttools-5 pkg-config))
+ (synopsis "NetworkManager front end with information icon residing in system tray")
+ (description "nm-tray is a network connection management tool (NetworkManager front end)
+with information icon residing in system tray. Unlike nm-applet,
+that is part of gnome, this app is desktop-unaware.")
+ (license license:gpl2+)))
+
;; The gnu.org ‘home’ for this GNU project is a directory listing with 1.6.0 as
;; the latest version. The author's git repository, mentioned in the 1.6.0
;; README and otherwise legit-looking, contains a proper 1.7.0 release tarball
--
2.37.0 (Apple Git-136)
[-- Attachment #2.3: Type: text/html, Size: 3867 bytes --]
next prev parent reply other threads:[~2022-10-05 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 20:49 [bug#58125] [PATCH] gnu: Add nm-tray Pavel Shlyak
2022-09-29 16:29 ` Maxime Devos
2022-10-05 14:46 ` Pavel Shlyak [this message]
2022-10-05 17:03 ` Maxime Devos
2022-10-10 8:44 ` bug#58125: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B3041DBE-037B-4B6B-AB89-C2A6FF356D73@pantherx.org \
--to=p.shlyak@pantherx.org \
--cc=58125@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.