From: Maxime Devos <maximedevos@telenet.be>
To: Pavel Shlyak <p.shlyak@pantherx.org>, 58125@debbugs.gnu.org
Subject: [bug#58125] [PATCH] gnu: Add nm-tray
Date: Thu, 29 Sep 2022 18:29:12 +0200 [thread overview]
Message-ID: <4fd51401-ad69-b33b-662b-f5e59ca11b46@telenet.be> (raw)
In-Reply-To: <5AA319F7-F1FD-41A4-8ACA-13C978C26835@pantherx.org>
[-- Attachment #1.1.1: Type: text/plain, Size: 2278 bytes --]
> Subject: [PATCH] gnu: Add nm-tray * gnu/packages/networking.scm (nm-tray): New
> variable.
Except for the initial line(?), the commit message is for tor the
Subject line (-:.
On 27-09-2022 22:49, Pavel Shlyak wrote:
> + ;;; Copyright © 2020-2022 PantherX OS Team <team@pantherx.org>
Please write the actual copyright holder (likely the relevant members of
this team or perhaps their employer, depending on how things are set up)
-- AFAIK, "PantherX OS Team" is a not some legal entity that can hold
copyright.
In both cases, I think we should investigate whether something like
<https://www.samba.org/samba/devel/copyright-policy.html> should be done
in Guix first.
> +++ b/gnu/packages/networking.scm
> + #:use-module (gnu packages kde-frameworks)
I don't think this module should unconditionally import that, to help
with keeping "guix ... package" fast when the kde-frameworks isn't
actually used.
I have tried out some tricks in <https://issues.guix.gnu.org/54539> --
while there doesn't seem to have been any conclusion on what's the
'proper' trick, there are some options -- see, e.g., how
https://issues.guix.gnu.org/57861 uses module-ref.
> + (synopsis "NetworkManager front end with information icon residing in system tray")
> + (description "nm-tray is a network connection management tool (NetworkManager front end)
> +with information icon residing in system tray (like e.g. nm-applet).")
Could you add some information, more specifically something to
distinguish nm-applet from nm-applet? Currently, it doesn't give any
information that helps the user with choosing between nm-tray nad nm-applet.
> + (recursive? #t)))
Why? AFAICT, there are no git submodules.
Looking through the source code, it appears to use icons. Can you test
that icons are displayed properly in a pure environment ("guix shell
--pure nm-tray -- ...")? Sometimes graphical software doesn't find its
icons without some help.
Looking at CMakeLists.txt, it comes with optional modem manager support,
for which you seem to have added modemmanager-qt, but from reading
CMakeLists.txt, it doesn't seem to be enabled by default, could you set
WITH_MODEMMANAGER_SUPPORT?
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-09-29 16:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 20:49 [bug#58125] [PATCH] gnu: Add nm-tray Pavel Shlyak
2022-09-29 16:29 ` Maxime Devos [this message]
2022-10-05 14:46 ` Pavel Shlyak
2022-10-05 17:03 ` Maxime Devos
2022-10-10 8:44 ` bug#58125: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fd51401-ad69-b33b-662b-f5e59ca11b46@telenet.be \
--to=maximedevos@telenet.be \
--cc=58125@debbugs.gnu.org \
--cc=p.shlyak@pantherx.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.