Re: 01/01: gnu: red-eclipse: Add store "data" package path as default.

Re: 01/01: gnu: red-eclipse: Add store "data" package path as default.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]

On Tue, Oct 10, 2017 at 08:26:31AM -0400, Kei Kebreau wrote:
> kkebreau pushed a commit to branch master
> in repository guix.
> 
> commit 42abb842f64f5dd7834cabd445a5f4d01f1e68a4
> Author: Adonay Felipe Nogueira <adfeno@hyperbola.info>
> Date:   Sun Aug 20 15:28:20 2017 -0300
> 
>     gnu: red-eclipse: Add store "data" package path as default.
>     
>     * gnu/packages/games.scm (red-eclipse): Remove extra spaces. Make version
>     respect documentation.
>     [arguments]: Add "prefix" to make-flags. Add
>     "add-store-data-package-path-as-default" phase. Improve "copy-data" phase.
>     
>     Signed-off-by: Kei Kebreau <kkebreau@posteo.net>
> ---
>  gnu/packages/games.scm | 110 ++++++++++++++++++++++++++++++-------------------
>  1 file changed, 68 insertions(+), 42 deletions(-)

[...]

> @@ -133,6 +133,7 @@
>    #:use-module (gnu packages gnuzilla)
>    #:use-module (gnu packages icu4c)
>    #:use-module (gnu packages networking)
> +  #:use-module (guix build utils)
>    #:use-module (guix build-system gnu)
>    #:use-module (guix build-system haskell)
>    #:use-module (guix build-system python)

This module import created an ambiguous reference to 'which':

WARNING: (gnu packages games): `which' imported from both (gnu packages base) and (guix build utils)

I don't know if it will be a problem in practice.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: 01/01: gnu: red-eclipse: Add store "data" package path as default.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 1600 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Tue, Oct 10, 2017 at 08:26:31AM -0400, Kei Kebreau wrote:
>> kkebreau pushed a commit to branch master
>> in repository guix.
>> 
>> commit 42abb842f64f5dd7834cabd445a5f4d01f1e68a4
>> Author: Adonay Felipe Nogueira <adfeno@hyperbola.info>
>> Date:   Sun Aug 20 15:28:20 2017 -0300
>> 
>>     gnu: red-eclipse: Add store "data" package path as default.
>>     
>>     * gnu/packages/games.scm (red-eclipse): Remove extra spaces. Make version
>>     respect documentation.
>>     [arguments]: Add "prefix" to make-flags. Add
>>     "add-store-data-package-path-as-default" phase. Improve "copy-data" phase.
>>     
>>     Signed-off-by: Kei Kebreau <kkebreau@posteo.net>
>> ---
>>  gnu/packages/games.scm | 110 ++++++++++++++++++++++++++++++-------------------
>>  1 file changed, 68 insertions(+), 42 deletions(-)
>
> [...]
>
>> @@ -133,6 +133,7 @@
>>    #:use-module (gnu packages gnuzilla)
>>    #:use-module (gnu packages icu4c)
>>    #:use-module (gnu packages networking)
>> +  #:use-module (guix build utils)
>>    #:use-module (guix build-system gnu)
>>    #:use-module (guix build-system haskell)
>>    #:use-module (guix build-system python)
>
> This module import created an ambiguous reference to 'which':
>
> WARNING: (gnu packages games): `which' imported from both (gnu
> packages base) and (guix build utils)
>
> I don't know if it will be a problem in practice.

It looks like Ludovic took care of this in commit
db9c49f4999d4e5f6eb0565a6a80892131c55670. Thank you for the
notification, though.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: 01/01: gnu: red-eclipse: Add store "data" package path as default.

[Ludovic Courtès]

Kei Kebreau <kkebreau@posteo.net> skribis:

> Leo Famulari <leo@famulari.name> writes:
>
>> On Tue, Oct 10, 2017 at 08:26:31AM -0400, Kei Kebreau wrote:
>>> kkebreau pushed a commit to branch master
>>> in repository guix.
>>> 
>>> commit 42abb842f64f5dd7834cabd445a5f4d01f1e68a4
>>> Author: Adonay Felipe Nogueira <adfeno@hyperbola.info>
>>> Date:   Sun Aug 20 15:28:20 2017 -0300
>>> 
>>>     gnu: red-eclipse: Add store "data" package path as default.
>>>     
>>>     * gnu/packages/games.scm (red-eclipse): Remove extra spaces. Make version
>>>     respect documentation.
>>>     [arguments]: Add "prefix" to make-flags. Add
>>>     "add-store-data-package-path-as-default" phase. Improve "copy-data" phase.
>>>     
>>>     Signed-off-by: Kei Kebreau <kkebreau@posteo.net>
>>> ---
>>>  gnu/packages/games.scm | 110 ++++++++++++++++++++++++++++++-------------------
>>>  1 file changed, 68 insertions(+), 42 deletions(-)
>>
>> [...]
>>
>>> @@ -133,6 +133,7 @@
>>>    #:use-module (gnu packages gnuzilla)
>>>    #:use-module (gnu packages icu4c)
>>>    #:use-module (gnu packages networking)
>>> +  #:use-module (guix build utils)
>>>    #:use-module (guix build-system gnu)
>>>    #:use-module (guix build-system haskell)
>>>    #:use-module (guix build-system python)
>>
>> This module import created an ambiguous reference to 'which':
>>
>> WARNING: (gnu packages games): `which' imported from both (gnu
>> packages base) and (guix build utils)
>>
>> I don't know if it will be a problem in practice.
>
> It looks like Ludovic took care of this in commit
> db9c49f4999d4e5f6eb0565a6a80892131c55670. Thank you for the
> notification, though.

Right, I had overlooked Leo’s message.

It was indeed a problem in practice, which prevented evaluation:
packages such as ‘crawl-tiles’ were getting the procedure instead of the
package as an input, which is invalid.

Ludo’.