From: ludo@gnu.org (Ludovic Courtès)
To: Kei Kebreau <kkebreau@posteo.net>
Cc: guix-devel@gnu.org, Kei Kebreau <kei@openmailbox.org>
Subject: Re: 01/01: gnu: red-eclipse: Add store "data" package path as default.
Date: Thu, 12 Oct 2017 10:48:11 +0200 [thread overview]
Message-ID: <87zi8wpx9w.fsf@gnu.org> (raw)
In-Reply-To: <87wp42d1ci.fsf@posteo.net> (Kei Kebreau's message of "Tue, 10 Oct 2017 19:34:05 -0400")
Kei Kebreau <kkebreau@posteo.net> skribis:
> Leo Famulari <leo@famulari.name> writes:
>
>> On Tue, Oct 10, 2017 at 08:26:31AM -0400, Kei Kebreau wrote:
>>> kkebreau pushed a commit to branch master
>>> in repository guix.
>>>
>>> commit 42abb842f64f5dd7834cabd445a5f4d01f1e68a4
>>> Author: Adonay Felipe Nogueira <adfeno@hyperbola.info>
>>> Date: Sun Aug 20 15:28:20 2017 -0300
>>>
>>> gnu: red-eclipse: Add store "data" package path as default.
>>>
>>> * gnu/packages/games.scm (red-eclipse): Remove extra spaces. Make version
>>> respect documentation.
>>> [arguments]: Add "prefix" to make-flags. Add
>>> "add-store-data-package-path-as-default" phase. Improve "copy-data" phase.
>>>
>>> Signed-off-by: Kei Kebreau <kkebreau@posteo.net>
>>> ---
>>> gnu/packages/games.scm | 110 ++++++++++++++++++++++++++++++-------------------
>>> 1 file changed, 68 insertions(+), 42 deletions(-)
>>
>> [...]
>>
>>> @@ -133,6 +133,7 @@
>>> #:use-module (gnu packages gnuzilla)
>>> #:use-module (gnu packages icu4c)
>>> #:use-module (gnu packages networking)
>>> + #:use-module (guix build utils)
>>> #:use-module (guix build-system gnu)
>>> #:use-module (guix build-system haskell)
>>> #:use-module (guix build-system python)
>>
>> This module import created an ambiguous reference to 'which':
>>
>> WARNING: (gnu packages games): `which' imported from both (gnu
>> packages base) and (guix build utils)
>>
>> I don't know if it will be a problem in practice.
>
> It looks like Ludovic took care of this in commit
> db9c49f4999d4e5f6eb0565a6a80892131c55670. Thank you for the
> notification, though.
Right, I had overlooked Leo’s message.
It was indeed a problem in practice, which prevented evaluation:
packages such as ‘crawl-tiles’ were getting the procedure instead of the
package as an input, which is invalid.
Ludo’.
prev parent reply other threads:[~2017-10-12 8:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171010122630.7275.20219@vcs0.savannah.gnu.org>
[not found] ` <20171010122631.845F9201F1@vcs0.savannah.gnu.org>
2017-10-10 14:36 ` 01/01: gnu: red-eclipse: Add store "data" package path as default Leo Famulari
2017-10-10 23:34 ` Kei Kebreau
2017-10-12 8:48 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zi8wpx9w.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=kei@openmailbox.org \
--cc=kkebreau@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.