From: Oleg Pykhalov <go.wigust@gmail.com>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 29678@debbugs.gnu.org
Subject: [bug#29678] [PATCH] gnu: qemu: Add pulseaudio support.
Date: Wed, 31 Jan 2018 17:39:59 +0300 [thread overview]
Message-ID: <87y3kexfb4.fsf@gmail.com> (raw)
In-Reply-To: <87608qd964.fsf@fastmail.com> (Marius Bakke's message of "Thu, 28 Dec 2017 19:00:51 +0100")
[-- Attachment #1.1: Type: text/plain, Size: 1882 bytes --]
Hello Marius,
apologies for a long reply. I fix a comment and have a question about
clojure. Also a new patch is attached.
Marius Bakke <mbakke@fastmail.com> writes:
> Oleg Pykhalov <go.wigust@gmail.com> writes:
>
>> From 2eff4caca543d9909758a4f2eb6f953467a309d7 Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <go.wigust@gmail.com>
>> Date: Fri, 8 Dec 2017 18:51:10 +0300
>> Subject: [PATCH] gnu: qemu: Add pulseaudio support.
>>
>> * gnu/packages/virtualization.scm (qemu): Add pulseaudio support.
>
> Please mention the change to [inputs] and [arguments] here.
OK.
[...]
>> #:phases
>> (modify-phases %standard-phases
>> (replace 'configure
>> @@ -166,6 +171,7 @@
>> ("ncurses" ,ncurses)
>> ;; ("pciutils" ,pciutils)
>> ("pixman" ,pixman)
>> + ("pulseaudio" ,pulseaudio)
>
> I see pulseaudio is already in Qemus closure,
How do you see this?
Is that what do you use?
--8<---------------cut here---------------start------------->8---
guix graph --type=references pulseaudio | dot -Tsvg > pulseaudio.svg
--8<---------------cut here---------------end--------------->8---
> so this does not add anything. LGTM!
Hm, seems it doesn't.
--8<---------------cut here---------------start------------->8---
starting phase `configure'
ERROR: pa check failed
Make sure to have the pa libs and headers installed.
phase `configure' failed after 1.8 seconds
builder for `/gnu/store/zy7p2f4vhnmy154lmgjyhz26y41ngcjg-qemu-2.10.2.drv' failed with exit code 1
@ build-failed /gnu/store/zy7p2f4vhnmy154lmgjyhz26y41ngcjg-qemu-2.10.2.drv - 1 builder for `/gnu/store/zy7p2f4vhnmy154lmgjyhz26y41ngcjg-qemu-2.10.2.drv' failed with exit code 1
guix build: error: build failed: build of `/gnu/store/zy7p2f4vhnmy154lmgjyhz26y41ngcjg-qemu-2.10.2.drv' failed
--8<---------------cut here---------------end--------------->8---
[...]
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: [PATCH] gnu: qemu: Add pulseaudio support. --]
[-- Type: text/x-patch, Size: 2121 bytes --]
From 69c18f461f6a00c7dd25b86e50be95a38d0ca445 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Fri, 8 Dec 2017 18:51:10 +0300
Subject: [PATCH] gnu: qemu: Add pulseaudio support.
* gnu/packages/virtualization.scm (qemu)[arguments]: Add pulseaudio support.
[inputs]: Add pulseaudio.
---
gnu/packages/virtualization.scm | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.scm
index f4fd4c336..97263382d 100644
--- a/gnu/packages/virtualization.scm
+++ b/gnu/packages/virtualization.scm
@@ -52,6 +52,7 @@
#:use-module (gnu packages protobuf)
#:use-module (gnu packages python)
#:use-module (gnu packages python-web)
+ #:use-module (gnu packages pulseaudio)
#:use-module (gnu packages selinux)
#:use-module (gnu packages sdl)
#:use-module (gnu packages spice)
@@ -96,10 +97,13 @@
'(;; Running tests in parallel can occasionally lead to failures, like:
;; boot_sector_test: assertion failed (signature == SIGNATURE): (0x00000000 == 0x0000dead)
#:parallel-tests? #f
- #:configure-flags (list "--enable-usb-redir" "--enable-opengl"
- (string-append "--smbd="
- (assoc-ref %outputs "out")
- "/libexec/samba-wrapper"))
+ #:configure-flags
+ (list "--enable-usb-redir"
+ "--enable-opengl"
+ (string-append "--smbd=" (assoc-ref %outputs "out")
+ "/libexec/samba-wrapper")
+ (string-append "--audio-drv-list="
+ (string-join (list "alsa" "pa" "sdl") ",")))
#:phases
(modify-phases %standard-phases
(replace 'configure
@@ -181,6 +185,7 @@ exec smbd $@")))
("ncurses" ,ncurses)
;; ("pciutils" ,pciutils)
("pixman" ,pixman)
+ ("pulseaudio" ,pulseaudio)
("sdl" ,sdl)
("spice" ,spice)
("usbredir" ,usbredir)
--
2.15.1
[-- Attachment #1.3: Type: text/plain, Size: 15 bytes --]
Thanks,
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-01-31 14:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 17:24 [bug#29678] [PATCH] gnu: qemu: Add pulseaudio support Oleg Pykhalov
2017-12-28 18:00 ` Marius Bakke
2018-01-31 14:39 ` Oleg Pykhalov [this message]
2018-01-31 15:04 ` Marius Bakke
2018-02-03 10:40 ` Oleg Pykhalov
2018-02-08 11:30 ` Marius Bakke
2018-02-09 22:04 ` Oleg Pykhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3kexfb4.fsf@gmail.com \
--to=go.wigust@gmail.com \
--cc=29678@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.