From: Marius Bakke <mbakke@fastmail.com>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 29678@debbugs.gnu.org
Subject: [bug#29678] [PATCH] gnu: qemu: Add pulseaudio support.
Date: Wed, 31 Jan 2018 16:04:54 +0100 [thread overview]
Message-ID: <87wozyoyqx.fsf@fastmail.com> (raw)
In-Reply-To: <87y3kexfb4.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1943 bytes --]
Oleg Pykhalov <go.wigust@gmail.com> writes:
>>> #:phases
>>> (modify-phases %standard-phases
>>> (replace 'configure
>>> @@ -166,6 +171,7 @@
>>> ("ncurses" ,ncurses)
>>> ;; ("pciutils" ,pciutils)
>>> ("pixman" ,pixman)
>>> + ("pulseaudio" ,pulseaudio)
>>
>> I see pulseaudio is already in Qemus closure,
>
> How do you see this?
>
> Is that what do you use?
> --8<---------------cut here---------------start------------->8---
> guix graph --type=references pulseaudio | dot -Tsvg > pulseaudio.svg
> --8<---------------cut here---------------end--------------->8---
I used `guix size qemu | grep pulseaudio`.
However "qemu-minimal" does not include pulseaudio, which increases the
size by about 25%. Can you drop the input from qemu-minimal at the same
time? Unfortunately we might have to override #:configure-flags as well.
[...]
> @@ -96,10 +97,13 @@
> '(;; Running tests in parallel can occasionally lead to failures, like:
> ;; boot_sector_test: assertion failed (signature == SIGNATURE): (0x00000000 == 0x0000dead)
> #:parallel-tests? #f
> - #:configure-flags (list "--enable-usb-redir" "--enable-opengl"
> - (string-append "--smbd="
> - (assoc-ref %outputs "out")
> - "/libexec/samba-wrapper"))
> + #:configure-flags
> + (list "--enable-usb-redir"
> + "--enable-opengl"
> + (string-append "--smbd=" (assoc-ref %outputs "out")
> + "/libexec/samba-wrapper")
> + (string-append "--audio-drv-list="
> + (string-join (list "alsa" "pa" "sdl") ",")))
Nit-pick: I don't really see the benefit of using string-join here. But
no strong opinion. However: use '() instead of (list ...) when the
elements do not need to be evaluated.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2018-01-31 15:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 17:24 [bug#29678] [PATCH] gnu: qemu: Add pulseaudio support Oleg Pykhalov
2017-12-28 18:00 ` Marius Bakke
2018-01-31 14:39 ` Oleg Pykhalov
2018-01-31 15:04 ` Marius Bakke [this message]
2018-02-03 10:40 ` Oleg Pykhalov
2018-02-08 11:30 ` Marius Bakke
2018-02-09 22:04 ` Oleg Pykhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wozyoyqx.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=29678@debbugs.gnu.org \
--cc=go.wigust@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.