From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1egtZW-00068d-ON for guix-patches@gnu.org; Wed, 31 Jan 2018 09:41:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1egtZO-0006fN-Iw for guix-patches@gnu.org; Wed, 31 Jan 2018 09:41:10 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:42550) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1egtZO-0006et-BC for guix-patches@gnu.org; Wed, 31 Jan 2018 09:41:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1egtZO-0004E3-5v for guix-patches@gnu.org; Wed, 31 Jan 2018 09:41:02 -0500 Subject: [bug#29678] [PATCH] gnu: qemu: Add pulseaudio support. Resent-Message-ID: From: Oleg Pykhalov References: <87o9n3kgez.fsf@gmail.com> <87608qd964.fsf@fastmail.com> Date: Wed, 31 Jan 2018 17:39:59 +0300 In-Reply-To: <87608qd964.fsf@fastmail.com> (Marius Bakke's message of "Thu, 28 Dec 2017 19:00:51 +0100") Message-ID: <87y3kexfb4.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 29678@debbugs.gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Hello Marius, apologies for a long reply. I fix a comment and have a question about clojure. Also a new patch is attached. Marius Bakke writes: > Oleg Pykhalov writes: > >> From 2eff4caca543d9909758a4f2eb6f953467a309d7 Mon Sep 17 00:00:00 2001 >> From: Oleg Pykhalov >> Date: Fri, 8 Dec 2017 18:51:10 +0300 >> Subject: [PATCH] gnu: qemu: Add pulseaudio support. >> >> * gnu/packages/virtualization.scm (qemu): Add pulseaudio support. > > Please mention the change to [inputs] and [arguments] here. OK. [...] >> #:phases >> (modify-phases %standard-phases >> (replace 'configure >> @@ -166,6 +171,7 @@ >> ("ncurses" ,ncurses) >> ;; ("pciutils" ,pciutils) >> ("pixman" ,pixman) >> + ("pulseaudio" ,pulseaudio) > > I see pulseaudio is already in Qemus closure, How do you see this? Is that what do you use? --8<---------------cut here---------------start------------->8--- guix graph --type=references pulseaudio | dot -Tsvg > pulseaudio.svg --8<---------------cut here---------------end--------------->8--- > so this does not add anything. LGTM! Hm, seems it doesn't. --8<---------------cut here---------------start------------->8--- starting phase `configure' ERROR: pa check failed Make sure to have the pa libs and headers installed. phase `configure' failed after 1.8 seconds builder for `/gnu/store/zy7p2f4vhnmy154lmgjyhz26y41ngcjg-qemu-2.10.2.drv' failed with exit code 1 @ build-failed /gnu/store/zy7p2f4vhnmy154lmgjyhz26y41ngcjg-qemu-2.10.2.drv - 1 builder for `/gnu/store/zy7p2f4vhnmy154lmgjyhz26y41ngcjg-qemu-2.10.2.drv' failed with exit code 1 guix build: error: build failed: build of `/gnu/store/zy7p2f4vhnmy154lmgjyhz26y41ngcjg-qemu-2.10.2.drv' failed --8<---------------cut here---------------end--------------->8--- [...] --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-qemu-Add-pulseaudio-support.patch Content-Transfer-Encoding: quoted-printable Content-Description: [PATCH] gnu: qemu: Add pulseaudio support. From=2069c18f461f6a00c7dd25b86e50be95a38d0ca445 Mon Sep 17 00:00:00 2001 From: Oleg Pykhalov Date: Fri, 8 Dec 2017 18:51:10 +0300 Subject: [PATCH] gnu: qemu: Add pulseaudio support. * gnu/packages/virtualization.scm (qemu)[arguments]: Add pulseaudio support. [inputs]: Add pulseaudio. =2D-- gnu/packages/virtualization.scm | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/gnu/packages/virtualization.scm b/gnu/packages/virtualization.= scm index f4fd4c336..97263382d 100644 =2D-- a/gnu/packages/virtualization.scm +++ b/gnu/packages/virtualization.scm @@ -52,6 +52,7 @@ #:use-module (gnu packages protobuf) #:use-module (gnu packages python) #:use-module (gnu packages python-web) + #:use-module (gnu packages pulseaudio) #:use-module (gnu packages selinux) #:use-module (gnu packages sdl) #:use-module (gnu packages spice) @@ -96,10 +97,13 @@ '(;; Running tests in parallel can occasionally lead to failures, lik= e: ;; boot_sector_test: assertion failed (signature =3D=3D SIGNATURE):= (0x00000000 =3D=3D 0x0000dead) #:parallel-tests? #f =2D #:configure-flags (list "--enable-usb-redir" "--enable-opengl" =2D (string-append "--smbd=3D" =2D (assoc-ref %outputs "out") =2D "/libexec/samba-wrapper")) + #:configure-flags + (list "--enable-usb-redir" + "--enable-opengl" + (string-append "--smbd=3D" (assoc-ref %outputs "out") + "/libexec/samba-wrapper") + (string-append "--audio-drv-list=3D" + (string-join (list "alsa" "pa" "sdl") ","))) #:phases (modify-phases %standard-phases (replace 'configure @@ -181,6 +185,7 @@ exec smbd $@"))) ("ncurses" ,ncurses) ;; ("pciutils" ,pciutils) ("pixman" ,pixman) + ("pulseaudio" ,pulseaudio) ("sdl" ,sdl) ("spice" ,spice) ("usbredir" ,usbredir) =2D-=20 2.15.1 --=-=-= Content-Type: text/plain Thanks, Oleg. --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEc+OyAXw1EaDPCmAPckbhHGm3lWkFAlpx1T8ACgkQckbhHGm3 lWkCfg//RKB7u76bPJDqiKy5oS9ly4l5STA20m3t4Qw+lLOOtn2ax3EeZIliPyGC +4+NGO5jM/xi2fAYsBqBafBDh5mEXR1U314dI4CGneji4VbPB/d0ot2KLlZEdxDB dHmgHpHrY3nojWv42jk4DtxWt7NyG67vUiIylTOKwQ2sW8G6xfOydhWYrX28gi/N pjITGa1IjdtD/x6KkderFQBnNiDJ0woNfNrPTKvbwi3+As/fBHv3Vep6nwQhbGAg jjK2LMj6ELL6TTC8Zw5N5MFLanOr+NlRaesln0m92beJqYnDUySMBidEgaP41W5d ct5PucVB1XVILn5zqSRbndAvA4cUasX/+fzxJOlmJ2Wo+cGhKRxMzZKp/kLtKB/R 6nHFgWA93mFSgZDeQcfb5aZOF/oHUzZwx/kr9EXyIxPKIoltLWwBXmoLN0UHhCsV nmar8WfSsEQdoCKIzcUiWytepFNQdzQHGVWoipPHC652cjeVp5Q9QTKUQHZHQ91l otChYbUrt1wio7Qpo4Vllkf18eoC6eMEq3I0XhjstEVNiyAoSMUQi79nhr6L5QWP 4Ew2siyPhxGEIAGFNHo/DKJ2FqWI8jeLKMaGlvxwtZ+LRULgC1+cu0SL9k/tcUbH qGuZv9x/paIa1EaGOn4lko1nZBCMKH/EW6KF6k1e7rU7sgBpDCA= =CNJe -----END PGP SIGNATURE----- --==-=-=--