From: "Ludovic Courtès" <ludo@gnu.org>
To: "Wiktor Żelazny" <wz@freeshell.de>
Cc: "Wiktor Żelazny" <wzelazny@vurv.cz>, 57337@debbugs.gnu.org
Subject: [bug#57337] [PATCH 0/2] Add docxbox
Date: Thu, 08 Sep 2022 14:49:15 +0200 [thread overview]
Message-ID: <87y1uughf8.fsf_-_@gnu.org> (raw)
In-Reply-To: <20220822093651.31574-2-wz@freeshell.de> ("Wiktor Żelazny"'s message of "Mon, 22 Aug 2022 11:36:51 +0200")
Wiktor Żelazny <wz@freeshell.de> skribis:
> From: Wiktor Żelazny <wzelazny@vurv.cz>
>
> * gnu/packages/textutils.scm (docxbox): New variable.
[...]
> + (snippet '(begin
> + (for-each delete-file-recursively
> + '("bin" "vendor/json" "vendor/miniz-cpp"
> + "vendor/tinyxml2")) #t))))
You can remove the trailing #t, it’s no longer necessary.
> + (build-system cmake-build-system)
> + ;; (native-inputs (list bats)) ; Enable after fixing tests, use bash module
> + (inputs `(("json-modern-cxx-source" ,(package-source json-modern-cxx))
> + ("miniz-cpp-source" ,(package-source miniz-cpp))
> + ("tinyxml2-source" ,(package-source tinyxml2))))
I’d suggest using the new style, which is to refer to those right in the
code, like so:
(arguments
(list #:phases #~(modify-phases …
…
(invoke "tar" "xf" #$(package-source whatever)))))
However, it would be best if, instead of re-building those three
libraries, docxbox would instead link against the .so provided by their
respective packages.
> + (synopsis "CLI tool for MS Word DOCX templating and analysis")
s/CLI/Command-line/ (in general, avoid acronyms)
s/DOCX/@file{.docx}/ I would say.
Could you send updated patches?
Thanks,
Ludo’.
next prev parent reply other threads:[~2022-09-08 12:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 9:27 [bug#57337] [PATCH 0/2] Add docxbox Wiktor Żelazny
2022-08-22 9:36 ` [bug#57337] [PATCH 1/2] gnu: Add miniz-cpp Wiktor Żelazny
2022-08-22 9:36 ` [bug#57337] [PATCH 2/2] gnu: Add docxbox Wiktor Żelazny
2022-09-08 12:49 ` Ludovic Courtès [this message]
2022-09-23 18:04 ` [bug#57337] [PATCH 0/2] " Wiktor Żelazny
2022-09-08 12:46 ` Ludovic Courtès
2022-09-23 17:46 ` Wiktor Żelazny
2022-09-08 12:44 ` Ludovic Courtès
2022-09-23 18:21 ` Wiktor Żelazny
2022-12-26 14:57 ` [bug#57337] [v2 " Wiktor Żelazny
2022-12-26 14:57 ` [bug#57337] [v2 1/2] gnu: Add miniz-cpp Wiktor Żelazny
2023-01-25 22:17 ` Ludovic Courtès
2022-12-26 14:57 ` [bug#57337] [v2 2/2] gnu: Add docxbox Wiktor Żelazny
2023-01-25 22:21 ` Ludovic Courtès
2023-01-28 19:50 ` Wiktor Żelazny
2023-02-05 20:18 ` [bug#57337] [PATCH v3 1/2] gnu: Add miniz-cpp Wiktor Żelazny
2023-02-05 20:18 ` [bug#57337] [PATCH v3 2/2] gnu: Add docxbox Wiktor Żelazny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1uughf8.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=57337@debbugs.gnu.org \
--cc=wz@freeshell.de \
--cc=wzelazny@vurv.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.