all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: "Wiktor Żelazny" <wz@freeshell.de>
Cc: 57337@debbugs.gnu.org
Subject: [bug#57337] [v2 1/2] gnu: Add miniz-cpp.
Date: Wed, 25 Jan 2023 23:17:18 +0100	[thread overview]
Message-ID: <87mt66s1ht.fsf@gnu.org> (raw)
In-Reply-To: <20221226145732.1237-2-wz@freeshell.de> ("Wiktor Żelazny"'s message of "Mon, 26 Dec 2022 15:57:31 +0100")

Hi Wiktor,

Apologies for the delay.

Wiktor Żelazny <wz@freeshell.de> skribis:

> * gnu/packages/cpp.scm (miniz-cpp): New variable.
> ---
>  gnu/local.mk                                  |    1 +
>  gnu/packages/cpp.scm                          |   35 +
>  .../miniz-cpp-fixed-duplicated-symbols.patch  | 2734 +++++++++++++++++
>  3 files changed, 2770 insertions(+)
>  create mode 100644 gnu/packages/patches/miniz-cpp-fixed-duplicated-symbols.patch

That’s a pretty big patch, and we don’t usually take that big a patch
downstream, but…

> +                (patches (search-patches
> +                          ;; To be removed once https://github.com/tfussell/miniz-cpp/pull/11
> +                          ;; gets merged.
> +                          "miniz-cpp-fixed-duplicated-symbols.patch"))))

Looking at the GitHub issue, it seems the solution could be merge soon.

How about (1) pinging upstream asking whether they could merge it, and
(2) referring to the commit of this pull request in the package
definition in the meantime, with a comment explaining why?

Thanks in advance,
Ludo’.




  reply	other threads:[~2023-01-25 22:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-22  9:27 [bug#57337] [PATCH 0/2] Add docxbox Wiktor Żelazny
2022-08-22  9:36 ` [bug#57337] [PATCH 1/2] gnu: Add miniz-cpp Wiktor Żelazny
2022-08-22  9:36   ` [bug#57337] [PATCH 2/2] gnu: Add docxbox Wiktor Żelazny
2022-09-08 12:49     ` [bug#57337] [PATCH 0/2] " Ludovic Courtès
2022-09-23 18:04       ` Wiktor Żelazny
2022-09-08 12:46   ` Ludovic Courtès
2022-09-23 17:46     ` Wiktor Żelazny
2022-09-08 12:44 ` Ludovic Courtès
2022-09-23 18:21   ` Wiktor Żelazny
2022-12-26 14:57 ` [bug#57337] [v2 " Wiktor Żelazny
2022-12-26 14:57   ` [bug#57337] [v2 1/2] gnu: Add miniz-cpp Wiktor Żelazny
2023-01-25 22:17     ` Ludovic Courtès [this message]
2022-12-26 14:57   ` [bug#57337] [v2 2/2] gnu: Add docxbox Wiktor Żelazny
2023-01-25 22:21     ` Ludovic Courtès
2023-01-28 19:50       ` Wiktor Żelazny
2023-02-05 20:18 ` [bug#57337] [PATCH v3 1/2] gnu: Add miniz-cpp Wiktor Żelazny
2023-02-05 20:18   ` [bug#57337] [PATCH v3 2/2] gnu: Add docxbox Wiktor Żelazny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mt66s1ht.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=57337@debbugs.gnu.org \
    --cc=wz@freeshell.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.