From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id IItvEkvlGWM53wAAbAwnHQ (envelope-from ) for ; Thu, 08 Sep 2022 14:51:23 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id OCJrEkvlGWOEgAAA9RJhRA (envelope-from ) for ; Thu, 08 Sep 2022 14:51:23 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 211A633A18 for ; Thu, 8 Sep 2022 14:51:23 +0200 (CEST) Received: from localhost ([::1]:52566 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWH06-0006Pk-6u for larch@yhetil.org; Thu, 08 Sep 2022 08:51:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41876) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWGyo-0006MC-NP for guix-patches@gnu.org; Thu, 08 Sep 2022 08:50:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40639) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWGyn-0003s3-Q3 for guix-patches@gnu.org; Thu, 08 Sep 2022 08:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oWGyn-0000tc-Ky for guix-patches@gnu.org; Thu, 08 Sep 2022 08:50:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57337] [PATCH 0/2] Add docxbox Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 08 Sep 2022 12:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57337 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Wiktor =?UTF-8?Q?=C5=BBelazny?= Cc: Wiktor =?UTF-8?Q?=C5=BBelazny?= , 57337@debbugs.gnu.org Received: via spool by 57337-submit@debbugs.gnu.org id=B57337.16626413703386 (code B ref 57337); Thu, 08 Sep 2022 12:50:01 +0000 Received: (at 57337) by debbugs.gnu.org; 8 Sep 2022 12:49:30 +0000 Received: from localhost ([127.0.0.1]:57567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWGyI-0000sY-Hj for submit@debbugs.gnu.org; Thu, 08 Sep 2022 08:49:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWGyC-0000sE-Pg for 57337@debbugs.gnu.org; Thu, 08 Sep 2022 08:49:28 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57224) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWGy5-0003jr-6i; Thu, 08 Sep 2022 08:49:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=iiLCX+7Yb/pXI5BXaRVb2S6zDt0eQSxmF7KfcunJelQ=; b=ePhiRJ7yTpagsodWK+WS xCGFQB5s3K0tZsp8Ryohyr51c1GdAc6l6LSipvYcGLbzgbGMIoFI0lXT+1bZXnPu+PSzTWmPgjiKY JlzEnnJQRgLe5xOlBVS8c55SZgJ4zP6k23XCodSey/xi2UrqDvJyuLxByI4A2cEyRyK1T3b6Qp6aR bhdWaZLZpLXVfJauzQj2Yx39W6Mh8sNZ5E3mYbtmqNGbo6xU7ULtbpp6ZSHcHxcQ9kbsTlxPjecLQ UpZwTVDFpqv4FjM6yIgadwehp8KXM7Xv/VIFCdrn0hpJ25YHsW9O3xC48OoH28fkcndF6ZcfrhG7i TPcTJcvHYrxUXQ==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=41162 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWGy4-0004oM-QA; Thu, 08 Sep 2022 08:49:17 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220822093651.31574-1-wz@freeshell.de> <20220822093651.31574-2-wz@freeshell.de> Date: Thu, 08 Sep 2022 14:49:15 +0200 In-Reply-To: <20220822093651.31574-2-wz@freeshell.de> ("Wiktor =?UTF-8?Q?=C5=BBelazny?="'s message of "Mon, 22 Aug 2022 11:36:51 +0200") Message-ID: <87y1uughf8.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662641483; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=iiLCX+7Yb/pXI5BXaRVb2S6zDt0eQSxmF7KfcunJelQ=; b=b/feQ3FMREECfk49j81aH1ahOhSYBJkTPKADUpVxysO6x+4sr9K6SwjV0ce15Al4g/Q4SG FvxR/j88V1qBcyLD50vCeTSp2dTrjOjrXYep9uNp8DWdEGx8z3D7Is8ow04k+O2bkrTqkX +NhaYDtN5LKKeGqtdjEkJLFDERx8tmD+y/CpC3WPVmP357mX5ObhWTsT/ruPNznjFrB4I1 HF8F/ShxOyrUt8N8fBioTpuVB1G/cqUIo/mR1fA68ZGnEvgp7YB5fBVXqsZBeERZ4T9HBd g7WESSJAW29fCrwS4hyhemi8O+OCatmy0IWoiNJO08S1dFAM5TAhlBi/rSf6DQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662641483; a=rsa-sha256; cv=none; b=aOVn/ND3F8YG2vOCdczXfOB0Cz8Cj9Cz4q/90W0j/gfrvc1gTDp+/FHx/NdWh9O2ZePOsv U0z6DpzHiNf9sE+zQB0LlfkmL30ACc2Xzjt97oYpblH1D2rjkWJpGYWRRqdKqzJDi6aIbD NCZgr7NI+JguKw9F9AqHMwE/MEoa0OktvB26CbiwJrW1TXiwNka+VXVWQ9ARmoFyEKyZoN dNb2yAZyVJci44NlF1FCH5OgP6NlcBFN010bH1Gu3FnWH5t5oN/k7rgM2dT+NtHacLaq+N 03AdOlOMX/Eylqwp7IWfS/7ex19eZWyCrt5q4kpL+SK+Pm0mepgtCQrAtPOHqg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ePhiRJ7y; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.08 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=ePhiRJ7y; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 211A633A18 X-Spam-Score: -5.08 X-Migadu-Scanner: scn0.migadu.com X-TUID: hYzM2SkHD0dL Wiktor =C5=BBelazny skribis: > From: Wiktor =C5=BBelazny > > * gnu/packages/textutils.scm (docxbox): New variable. [...] > + (snippet '(begin > + (for-each delete-file-recursively > + '("bin" "vendor/json" "vendor/miniz-= cpp" > + "vendor/tinyxml2")) #t)))) You can remove the trailing #t, it=E2=80=99s no longer necessary. > + (build-system cmake-build-system) > + ;; (native-inputs (list bats)) ; Enable after fixing tests, use bash= module > + (inputs `(("json-modern-cxx-source" ,(package-source json-modern-cxx= )) > + ("miniz-cpp-source" ,(package-source miniz-cpp)) > + ("tinyxml2-source" ,(package-source tinyxml2)))) I=E2=80=99d suggest using the new style, which is to refer to those right i= n the code, like so: (arguments (list #:phases #~(modify-phases =E2=80=A6 =E2=80=A6 (invoke "tar" "xf" #$(package-source whatever))))) However, it would be best if, instead of re-building those three libraries, docxbox would instead link against the .so provided by their respective packages. > + (synopsis "CLI tool for MS Word DOCX templating and analysis") s/CLI/Command-line/ (in general, avoid acronyms) s/DOCX/@file{.docx}/ I would say. Could you send updated patches? Thanks, Ludo=E2=80=99.