[bug#63015] [PATCH] gnu: Add emacs-gemini.

[bug#63015] [PATCH] gnu: Add emacs-gemini.

[Evgeny Pisemsky]

[-- Attachment #1: 0001-gnu-Add-emacs-gemini.patch --]
[-- Type: text/x-patch, Size: 2213 bytes --]

From 7c2de9e0137927140df056f20cb8de635c8aa4ce Mon Sep 17 00:00:00 2001
From: Evgeny Pisemsky <evgeny@pisemsky.com>
Date: Sat, 22 Apr 2023 15:00:00 +0300
Subject: [PATCH] gnu: Add emacs-gemini.

* gnu/packages/emacs-xyz.scm (emacs-gemini): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b9bece1365..b76099d81d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -126,6 +126,7 @@
 ;;; Copyright © 2020, 2021, 2022, 2023 Andrew Tropin <andrew@trop.in>
 ;;; Copyright © 2023 Dominik Delgado Steuter <d@delgado.nrw>
 ;;; Copyright © 2023 Juliana Sims <juli@incana.org>
+;;; Copyright © 2023 Evgeny Pisemsky <evgeny@pisemsky.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -31367,6 +31368,31 @@ (define-public emacs-elpher
 connections using TLS encryption.")
     (license license:gpl3+)))
 
+(define-public emacs-gemini
+  (let ((version "1.2.0")
+        (revision "0")
+        (commit "a7dd7c6ea4e036d0d5ecc4a5d284874c400f10ba"))
+    (package
+      (name "emacs-gemini")
+      (version (git-version version revision commit))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://git.carcosa.net/jmcbray/gemini.el.git")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1pvlk56mhh4xh4gwzqldfk79jsjbcpivv5scd9811pv3afc30gsx"))))
+      (build-system emacs-build-system)
+      (home-page "https://git.carcosa.net/jmcbray/gemini.el")
+      (synopsis "Syntax highlighting for text/gemini")
+      (description
+       "This is a very simple syntax-highlighting mode for text/gemini documents.
+Currently, support is not complete, but it should be enough to help with basic
+documents.")
+      (license license:agpl3+))))
+
 (define-public emacs-zerodark-theme
   (package
     (name "emacs-zerodark-theme")

base-commit: 5b545763ed9b8a3fade7f756d543819fc090953f
-- 
2.39.2

[bug#63015] [PATCH] gnu: Add emacs-gemini.

[Nicolas Goaziou]

Hello,

Evgeny Pisemsky <evgeny@pisemsky.com> writes:

> From 7c2de9e0137927140df056f20cb8de635c8aa4ce Mon Sep 17 00:00:00 2001
> From: Evgeny Pisemsky <evgeny@pisemsky.com>
> Date: Sat, 22 Apr 2023 15:00:00 +0300
> Subject: [PATCH] gnu: Add emacs-gemini.
>
> * gnu/packages/emacs-xyz.scm (emacs-gemini): New variable.

Thank you. Some comments follow.

> +(define-public emacs-gemini
> +  (let ((version "1.2.0")
> +        (revision "0")
> +        (commit "a7dd7c6ea4e036d0d5ecc4a5d284874c400f10ba"))

This particular commit you're using is actually a version bump. Since
upstream does not tag such bumps, I suggest to make it the exact "1.2.0"
version, instead of "1.2.0-0.a7dd7c6".

IOW, you can drop revision binding, and version too.

> +    (package
> +      (name "emacs-gemini")
> +      (version (git-version version revision commit))

Here (version "1.2.0") is enough.

> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://git.carcosa.net/jmcbray/gemini.el.git")

Nitpick: I suggest to drop the ".git" suffix for consistency with other
packages.

> +                      (commit commit)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "1pvlk56mhh4xh4gwzqldfk79jsjbcpivv5scd9811pv3afc30gsx"))))
> +      (build-system emacs-build-system)
> +      (home-page "https://git.carcosa.net/jmcbray/gemini.el")
> +      (synopsis "Syntax highlighting for text/gemini")
> +      (description
> +       "This is a very simple syntax-highlighting mode for text/gemini documents.
> +Currently, support is not complete, but it should be enough to help with basic
> +documents.")
> +      (license license:agpl3+))))

Otherwise LGTM.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

[bug#63015] [PATCH] gnu: Add emacs-gemini.

[Evgeny Pisemsky]

[-- Attachment #1: Type: text/plain, Size: 36 bytes --]

Hello!

Here is the updated patch.


[-- Attachment #2: 0001-gnu-Add-emacs-gemini.patch --]
[-- Type: text/x-patch, Size: 2053 bytes --]

From 6571e21e1a6d1397b78ad0e98e296d0837647bb5 Mon Sep 17 00:00:00 2001
From: Evgeny Pisemsky <evgeny@pisemsky.com>
Date: Sat, 22 Apr 2023 15:00:00 +0300
Subject: [PATCH] gnu: Add emacs-gemini.

* gnu/packages/emacs-xyz.scm (emacs-gemini): New variable.
---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b9bece1365..06bf8f18ee 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -126,6 +126,7 @@
 ;;; Copyright © 2020, 2021, 2022, 2023 Andrew Tropin <andrew@trop.in>
 ;;; Copyright © 2023 Dominik Delgado Steuter <d@delgado.nrw>
 ;;; Copyright © 2023 Juliana Sims <juli@incana.org>
+;;; Copyright © 2023 Evgeny Pisemsky <evgeny@pisemsky.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -31367,6 +31368,28 @@ (define-public emacs-elpher
 connections using TLS encryption.")
     (license license:gpl3+)))
 
+(define-public emacs-gemini
+  (package
+    (name "emacs-gemini")
+    (version "1.2.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://git.carcosa.net/jmcbray/gemini.el")
+                    (commit "a7dd7c6ea4e036d0d5ecc4a5d284874c400f10ba")))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1pvlk56mhh4xh4gwzqldfk79jsjbcpivv5scd9811pv3afc30gsx"))))
+    (build-system emacs-build-system)
+    (home-page "https://git.carcosa.net/jmcbray/gemini.el")
+    (synopsis "Syntax highlighting for text/gemini")
+    (description
+     "This is a very simple syntax-highlighting mode for text/gemini documents.
+Currently, support is not complete, but it should be enough to help with basic
+documents.")
+    (license license:agpl3+)))
+
 (define-public emacs-zerodark-theme
   (package
     (name "emacs-zerodark-theme")

base-commit: 5b545763ed9b8a3fade7f756d543819fc090953f
-- 
2.39.2

bug#63015: [PATCH] gnu: Add emacs-gemini.

[Nicolas Goaziou]

Hello,

Evgeny Pisemsky <evgeny@pisemsky.com> writes:

> Hello!
>
> Here is the updated patch.

[...]

> Subject: [PATCH] gnu: Add emacs-gemini.
>
> * gnu/packages/emacs-xyz.scm (emacs-gemini): New variable.

Perfect! Applied. Thank you.

Regards,
-- 
Nicolas Goaziou