From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Evgeny Pisemsky <evgeny@pisemsky.com>
Cc: 63015@debbugs.gnu.org
Subject: [bug#63015] [PATCH] gnu: Add emacs-gemini.
Date: Sat, 22 Apr 2023 16:50:01 +0200 [thread overview]
Message-ID: <87edoc0y5i.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87h6t83x2c.fsf@pisemsky.com> (Evgeny Pisemsky's message of "Sat, 22 Apr 2023 15:45:15 +0300")
Hello,
Evgeny Pisemsky <evgeny@pisemsky.com> writes:
> From 7c2de9e0137927140df056f20cb8de635c8aa4ce Mon Sep 17 00:00:00 2001
> From: Evgeny Pisemsky <evgeny@pisemsky.com>
> Date: Sat, 22 Apr 2023 15:00:00 +0300
> Subject: [PATCH] gnu: Add emacs-gemini.
>
> * gnu/packages/emacs-xyz.scm (emacs-gemini): New variable.
Thank you. Some comments follow.
> +(define-public emacs-gemini
> + (let ((version "1.2.0")
> + (revision "0")
> + (commit "a7dd7c6ea4e036d0d5ecc4a5d284874c400f10ba"))
This particular commit you're using is actually a version bump. Since
upstream does not tag such bumps, I suggest to make it the exact "1.2.0"
version, instead of "1.2.0-0.a7dd7c6".
IOW, you can drop revision binding, and version too.
> + (package
> + (name "emacs-gemini")
> + (version (git-version version revision commit))
Here (version "1.2.0") is enough.
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://git.carcosa.net/jmcbray/gemini.el.git")
Nitpick: I suggest to drop the ".git" suffix for consistency with other
packages.
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1pvlk56mhh4xh4gwzqldfk79jsjbcpivv5scd9811pv3afc30gsx"))))
> + (build-system emacs-build-system)
> + (home-page "https://git.carcosa.net/jmcbray/gemini.el")
> + (synopsis "Syntax highlighting for text/gemini")
> + (description
> + "This is a very simple syntax-highlighting mode for text/gemini documents.
> +Currently, support is not complete, but it should be enough to help with basic
> +documents.")
> + (license license:agpl3+))))
Otherwise LGTM.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2023-04-22 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-22 12:45 [bug#63015] [PATCH] gnu: Add emacs-gemini Evgeny Pisemsky
2023-04-22 14:50 ` Nicolas Goaziou [this message]
2023-04-22 15:18 ` Evgeny Pisemsky
2023-04-23 15:10 ` bug#63015: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edoc0y5i.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=63015@debbugs.gnu.org \
--cc=evgeny@pisemsky.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.