* Re: 07/19: services: postgresql: Add default package. [not found] ` <20230421151609.305BAC13A94@vcs2.savannah.gnu.org> @ 2023-04-21 16:31 ` Christopher Baines 2023-05-03 21:00 ` Ludovic Courtès 0 siblings, 1 reply; 4+ messages in thread From: Christopher Baines @ 2023-04-21 16:31 UTC (permalink / raw) To: Ludovic Courtès; +Cc: guix-devel [-- Attachment #1: Type: text/plain, Size: 886 bytes --] guix-commits@gnu.org writes: > civodul pushed a commit to branch master > in repository guix. > > commit e45306c1982aee194243cf661295c7ca776d879f > Author: Ludovic Courtès <ludo@gnu.org> > AuthorDate: Thu Apr 20 10:38:37 2023 +0200 > > services: postgresql: Add default package. > > * gnu/services/databases.scm (<postgresql-configuration>)[postgresql]: > Add default value, moved from... > (postgresql-service-type)[default-value]: ... here. > --- > gnu/services/databases.scm | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) The default was removed a few years ago [1] and I don't think there's been a significant change (like supporting automatic upgrading existing databases between versions) in the service since then. 1: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=bdcf4d88d58798eca7811c8b1fbd4638168d05c3 [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 987 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 07/19: services: postgresql: Add default package. 2023-04-21 16:31 ` 07/19: services: postgresql: Add default package Christopher Baines @ 2023-05-03 21:00 ` Ludovic Courtès 2023-05-04 8:11 ` Christopher Baines 0 siblings, 1 reply; 4+ messages in thread From: Ludovic Courtès @ 2023-05-03 21:00 UTC (permalink / raw) To: Christopher Baines; +Cc: guix-devel Hi Chris, Christopher Baines <mail@cbaines.net> skribis: > guix-commits@gnu.org writes: > >> civodul pushed a commit to branch master >> in repository guix. >> >> commit e45306c1982aee194243cf661295c7ca776d879f >> Author: Ludovic Courtès <ludo@gnu.org> >> AuthorDate: Thu Apr 20 10:38:37 2023 +0200 >> >> services: postgresql: Add default package. >> >> * gnu/services/databases.scm (<postgresql-configuration>)[postgresql]: >> Add default value, moved from... >> (postgresql-service-type)[default-value]: ... here. >> --- >> gnu/services/databases.scm | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > > The default was removed a few years ago [1] and I don't think there's > been a significant change (like supporting automatic upgrading existing > databases between versions) in the service since then. > > 1: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=bdcf4d88d58798eca7811c8b1fbd4638168d05c3 Oh, my bad. I found it weird that the default value would be found in the service and not in the configuration object. The result is that there is a default value, just not where you’d expect it. But yeah, I understand the rationale of the commit above, so we should probably revert to that and add a comment explaining why there’s no default. I wonder how we can make sure that users can still write (say): (service cuirass-service-type) without having to explicitly specify which postgresql version they want to use. WDYT? Ludo’. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 07/19: services: postgresql: Add default package. 2023-05-03 21:00 ` Ludovic Courtès @ 2023-05-04 8:11 ` Christopher Baines 2023-05-07 21:22 ` Ludovic Courtès 0 siblings, 1 reply; 4+ messages in thread From: Christopher Baines @ 2023-05-04 8:11 UTC (permalink / raw) To: Ludovic Courtès; +Cc: guix-devel [-- Attachment #1: Type: text/plain, Size: 2278 bytes --] Ludovic Courtès <ludo@gnu.org> writes: > Christopher Baines <mail@cbaines.net> skribis: > >> guix-commits@gnu.org writes: >> >>> civodul pushed a commit to branch master >>> in repository guix. >>> >>> commit e45306c1982aee194243cf661295c7ca776d879f >>> Author: Ludovic Courtès <ludo@gnu.org> >>> AuthorDate: Thu Apr 20 10:38:37 2023 +0200 >>> >>> services: postgresql: Add default package. >>> >>> * gnu/services/databases.scm (<postgresql-configuration>)[postgresql]: >>> Add default value, moved from... >>> (postgresql-service-type)[default-value]: ... here. >>> --- >>> gnu/services/databases.scm | 6 +++--- >>> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> The default was removed a few years ago [1] and I don't think there's >> been a significant change (like supporting automatic upgrading existing >> databases between versions) in the service since then. >> >> 1: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=bdcf4d88d58798eca7811c8b1fbd4638168d05c3 > > Oh, my bad. I found it weird that the default value would be found in > the service and not in the configuration object. The result is that > there is a default value, just not where you’d expect it. > > But yeah, I understand the rationale of the commit above, so we should > probably revert to that and add a comment explaining why there’s no > default. > > I wonder how we can make sure that users can still write (say): > > (service cuirass-service-type) > > without having to explicitly specify which postgresql version they want > to use. > > WDYT? Yeah, we're just moving the problem of matching up the PostgreSQL software and data at the moment, but I think it's still preferable to make the problem clear in the configuration and when reconfiguring rather than delaying things to when the service doesn't start. It would be good to at least have some Guix specific documentation on how to migrate from one PostgreSQL version to another, and ideally this could be integrated in to the service somehow. That's the blocking issue to providing defaults here, we're just setting the user up for the service not starting at some point in the future when we change the default version of PostgreSQL. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 987 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 07/19: services: postgresql: Add default package. 2023-05-04 8:11 ` Christopher Baines @ 2023-05-07 21:22 ` Ludovic Courtès 0 siblings, 0 replies; 4+ messages in thread From: Ludovic Courtès @ 2023-05-07 21:22 UTC (permalink / raw) To: Christopher Baines; +Cc: guix-devel Hi, Christopher Baines <mail@cbaines.net> skribis: > Ludovic Courtès <ludo@gnu.org> writes: > >> Christopher Baines <mail@cbaines.net> skribis: >> >>> guix-commits@gnu.org writes: >>> >>>> civodul pushed a commit to branch master >>>> in repository guix. >>>> >>>> commit e45306c1982aee194243cf661295c7ca776d879f >>>> Author: Ludovic Courtès <ludo@gnu.org> >>>> AuthorDate: Thu Apr 20 10:38:37 2023 +0200 >>>> >>>> services: postgresql: Add default package. [...] >> Oh, my bad. I found it weird that the default value would be found in >> the service and not in the configuration object. The result is that >> there is a default value, just not where you’d expect it. >> >> But yeah, I understand the rationale of the commit above, so we should >> probably revert to that and add a comment explaining why there’s no >> default. >> >> I wonder how we can make sure that users can still write (say): >> >> (service cuirass-service-type) >> >> without having to explicitly specify which postgresql version they want >> to use. >> >> WDYT? > > Yeah, we're just moving the problem of matching up the PostgreSQL > software and data at the moment, but I think it's still preferable to > make the problem clear in the configuration and when reconfiguring > rather than delaying things to when the service doesn't start. Yeah, OK. So I guess we can revert e45306c1982aee194243cf661295c7ca776d879f and add a comment explaining the lack of a default value. If that sounds good to you, please go ahead or let me know if I should do it. > It would be good to at least have some Guix specific documentation on > how to migrate from one PostgreSQL version to another, and ideally this > could be integrated in to the service somehow. That's the blocking issue > to providing defaults here, we're just setting the user up for the > service not starting at some point in the future when we change the > default version of PostgreSQL. I’m not really in a position to help but I agree! Thanks, Ludo’. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-07 21:23 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <168209016695.26329.16329467815416207575@vcs2.savannah.gnu.org> [not found] ` <20230421151609.305BAC13A94@vcs2.savannah.gnu.org> 2023-04-21 16:31 ` 07/19: services: postgresql: Add default package Christopher Baines 2023-05-03 21:00 ` Ludovic Courtès 2023-05-04 8:11 ` Christopher Baines 2023-05-07 21:22 ` Ludovic Courtès
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/guix.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.