From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id wJYoF78WWGTiSAEASxT56A (envelope-from ) for ; Sun, 07 May 2023 23:23:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id IFIcF78WWGSYbwEAauVa8A (envelope-from ) for ; Sun, 07 May 2023 23:23:11 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 155911FED4 for ; Sun, 7 May 2023 23:23:11 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvlq5-0000nV-G0; Sun, 07 May 2023 17:22:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvlq4-0000nN-JI for guix-devel@gnu.org; Sun, 07 May 2023 17:22:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvlq4-0004Lh-B9; Sun, 07 May 2023 17:22:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=vyF3p6n4uXPpAgEJqcUnnTduOdB7stIjWMboEtS5N+8=; b=cJJR8ZRzA3r43v1fXZSZ 11QFZT50GUJuYnAJk8mSwQaz0m3M+/RHoRNREqJ5OqE5tp+cXmYmzHXZjGzRgThP8ld9rrVuHPQ3a lTX1nktw28vsN4N1Bg/fdfttufuJZ3ynwEEHeAkYGg9jf95rJpOnvvZ803UEIuRg8DnNNKctoPCWx L0RvL7Rutay4N3IvCnrgY01fyrhe2AZckwhtJhIwQ5EaIKYB0JJ8qWAbiapipHsE5wOW6YZ5ZvNf0 Bae0D0pUd7MbrBqzF+8VtaXBCgLJFxCM/HKl5JeOMDJSA0YNH7/id1nMOe2L5mIzt36T0xio76I1E 56VROKGQLNHuLg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvlq3-0000Vo-U3; Sun, 07 May 2023 17:22:40 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Christopher Baines Cc: guix-devel@gnu.org Subject: Re: 07/19: services: postgresql: Add default package. References: <168209016695.26329.16329467815416207575@vcs2.savannah.gnu.org> <20230421151609.305BAC13A94@vcs2.savannah.gnu.org> <878reltcsi.fsf@cbaines.net> <87y1m5w2ox.fsf@gnu.org> <87a5yko6d2.fsf@cbaines.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Octidi 18 =?utf-8?Q?Flor=C3=A9al?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour de la Corbeille-d'or X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 07 May 2023 23:22:37 +0200 In-Reply-To: <87a5yko6d2.fsf@cbaines.net> (Christopher Baines's message of "Thu, 04 May 2023 09:11:07 +0100") Message-ID: <877ctjhm5e.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1683494591; a=rsa-sha256; cv=none; b=CC32WhT/enYhbd9pYgduKyDxP4EUjQCeUcKRqD7TVnFhTX5gI3RwoeD1GKgTYvcoUhr3z5 pFkq2SuYlWNqVi9H2xFCzEa6sPo471j5b3uZPA0BbYxCeNEJqXemLWEuimUmNk+h6cFEBd PtnYonRs16lHfBRyK8dfNGI3+4CAdYvnPirkpB3Fa7lvPRtp6u8UTxRJrl2nwN0R1JgLyp TW+pP2irAIwLpG68gFjITcxfi7GsgxvWsdyN6Fy+ovUrt6/Fj3T5PwynZnWVAs11DXEsrI IuoG4BF8FjmeKzfNj1U7GZ8m747NKsBalXPEOC7rR6vLYnAiTfpplP8VY5n+lg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=cJJR8ZRz; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1683494591; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=vyF3p6n4uXPpAgEJqcUnnTduOdB7stIjWMboEtS5N+8=; b=d+GrWaLIl9EAbWAAVriVnsVqsDsAnQrUSL2PoCrLr9zoohfmKIcDa8Fh/RxvM0X7fcMYZq ddiYk7KmA35l/SWOn5ITzmHgWxoQCpOXesQEyM+GqeSMtKifrONyCjGYJPXx2ix2vzSJNj U18TQGbRDsQuaf2s7IK3b5Qk56QhvYek/rbACWi/A5niI8RC8ORmqa1+dZ1dYblwbts22o lfa/lZTKzq7G8PisdR7JL9kkyy4Gz+vZ8FA5sKO5n62BOvoWPJTkXS4qTkH1Ku0GbHidVx wPPjfaqIy3AhwAdFY9iR2O61SeC9FDqA9UP9S1H7E+8L8FXPITwa+1jApAy5qA== X-Migadu-Spam-Score: -5.90 X-Spam-Score: -5.90 X-Migadu-Queue-Id: 155911FED4 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=cJJR8ZRz; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-TUID: xx7an9PRDAI2 Hi, Christopher Baines skribis: > Ludovic Court=C3=A8s writes: > >> Christopher Baines skribis: >> >>> guix-commits@gnu.org writes: >>> >>>> civodul pushed a commit to branch master >>>> in repository guix. >>>> >>>> commit e45306c1982aee194243cf661295c7ca776d879f >>>> Author: Ludovic Court=C3=A8s >>>> AuthorDate: Thu Apr 20 10:38:37 2023 +0200 >>>> >>>> services: postgresql: Add default package. [...] >> Oh, my bad. I found it weird that the default value would be found in >> the service and not in the configuration object. The result is that >> there is a default value, just not where you=E2=80=99d expect it. >> >> But yeah, I understand the rationale of the commit above, so we should >> probably revert to that and add a comment explaining why there=E2=80=99s= no >> default. >> >> I wonder how we can make sure that users can still write (say): >> >> (service cuirass-service-type) >> >> without having to explicitly specify which postgresql version they want >> to use. >> >> WDYT? > > Yeah, we're just moving the problem of matching up the PostgreSQL > software and data at the moment, but I think it's still preferable to > make the problem clear in the configuration and when reconfiguring > rather than delaying things to when the service doesn't start. Yeah, OK. So I guess we can revert e45306c1982aee194243cf661295c7ca776d879f and add a comment explaining the lack of a default value. If that sounds good to you, please go ahead or let me know if I should do it. > It would be good to at least have some Guix specific documentation on > how to migrate from one PostgreSQL version to another, and ideally this > could be integrated in to the service somehow. That's the blocking issue > to providing defaults here, we're just setting the user up for the > service not starting at some point in the future when we change the > default version of PostgreSQL. I=E2=80=99m not really in a position to help but I agree! Thanks, Ludo=E2=80=99.