* [bug#31942] [PATCH] pack: Fix guix pack -f docker.
@ 2018-06-22 21:46 Christopher Baines
2018-06-23 22:00 ` Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Christopher Baines @ 2018-06-22 21:46 UTC (permalink / raw)
To: 31942
Without this change, running guix pack fails as (guix sets) is missing when
compiling (guix build store-copy).
* guix/scripts/pack.scm (docker-image): Move (guix build store-copy) to within
the source-module-closure call.
---
guix/scripts/pack.scm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/guix/scripts/pack.scm b/guix/scripts/pack.scm
index ed876b259..443d199be 100644
--- a/guix/scripts/pack.scm
+++ b/guix/scripts/pack.scm
@@ -364,9 +364,9 @@ the image."
(define build
;; Guile-JSON is required by (guix docker).
(with-extensions (list json)
- (with-imported-modules `(,@(source-module-closure '((guix docker))
+ (with-imported-modules `(,@(source-module-closure '((guix docker)
+ (guix build store-copy))
#:select? not-config?)
- (guix build store-copy)
((guix config) => ,config))
#~(begin
(use-modules (guix docker) (srfi srfi-19) (guix build store-copy))
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [bug#31942] [PATCH] pack: Fix guix pack -f docker.
2018-06-22 21:46 [bug#31942] [PATCH] pack: Fix guix pack -f docker Christopher Baines
@ 2018-06-23 22:00 ` Ludovic Courtès
2018-06-24 8:26 ` bug#31942: " Christopher Baines
0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2018-06-23 22:00 UTC (permalink / raw)
To: Christopher Baines; +Cc: 31942
Hi Chris!
Christopher Baines <mail@cbaines.net> skribis:
> Without this change, running guix pack fails as (guix sets) is missing when
> compiling (guix build store-copy).
>
> * guix/scripts/pack.scm (docker-image): Move (guix build store-copy) to within
> the source-module-closure call.
Good catch, got for it!
Thanks,
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#31942: [PATCH] pack: Fix guix pack -f docker.
2018-06-23 22:00 ` Ludovic Courtès
@ 2018-06-24 8:26 ` Christopher Baines
2018-06-25 21:36 ` [bug#31942] " Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Christopher Baines @ 2018-06-24 8:26 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 31942-done
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Hi Chris!
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> Without this change, running guix pack fails as (guix sets) is missing when
>> compiling (guix build store-copy).
>>
>> * guix/scripts/pack.scm (docker-image): Move (guix build store-copy) to within
>> the source-module-closure call.
>
> Good catch, got for it!
Great, I've pushed this now.
Note that the squashfs format looks to be similarly broken, but not
quite as simple to fix.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [bug#31942] [PATCH] pack: Fix guix pack -f docker.
2018-06-24 8:26 ` bug#31942: " Christopher Baines
@ 2018-06-25 21:36 ` Ludovic Courtès
0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2018-06-25 21:36 UTC (permalink / raw)
To: Christopher Baines; +Cc: 31942-done
Christopher Baines <mail@cbaines.net> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hi Chris!
>>
>> Christopher Baines <mail@cbaines.net> skribis:
>>
>>> Without this change, running guix pack fails as (guix sets) is missing when
>>> compiling (guix build store-copy).
>>>
>>> * guix/scripts/pack.scm (docker-image): Move (guix build store-copy) to within
>>> the source-module-closure call.
>>
>> Good catch, got for it!
>
> Great, I've pushed this now.
>
> Note that the squashfs format looks to be similarly broken, but not
> quite as simple to fix.
Fixed in 66e9944e078cbb9e0d618377dd6df6e639640efa.
Thanks for the heads-up!
Ludo'.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-25 21:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-22 21:46 [bug#31942] [PATCH] pack: Fix guix pack -f docker Christopher Baines
2018-06-23 22:00 ` Ludovic Courtès
2018-06-24 8:26 ` bug#31942: " Christopher Baines
2018-06-25 21:36 ` [bug#31942] " Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.