[bug#31942] [PATCH] pack: Fix guix pack -f docker.

[bug#31942] [PATCH] pack: Fix guix pack -f docker.

[Christopher Baines]

Without this change, running guix pack fails as (guix sets) is missing when
compiling (guix build store-copy).

* guix/scripts/pack.scm (docker-image): Move (guix build store-copy) to within
the source-module-closure call.
---
 guix/scripts/pack.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/guix/scripts/pack.scm b/guix/scripts/pack.scm
index ed876b259..443d199be 100644
--- a/guix/scripts/pack.scm
+++ b/guix/scripts/pack.scm
@@ -364,9 +364,9 @@ the image."
   (define build
     ;; Guile-JSON is required by (guix docker).
     (with-extensions (list json)
-      (with-imported-modules `(,@(source-module-closure '((guix docker))
+      (with-imported-modules `(,@(source-module-closure '((guix docker)
+                                                          (guix build store-copy))
                                                         #:select? not-config?)
-                               (guix build store-copy)
                                ((guix config) => ,config))
         #~(begin
             (use-modules (guix docker) (srfi srfi-19) (guix build store-copy))
-- 
2.17.1

[bug#31942] [PATCH] pack: Fix guix pack -f docker.

[Ludovic Courtès]

Hi Chris!

Christopher Baines <mail@cbaines.net> skribis:

> Without this change, running guix pack fails as (guix sets) is missing when
> compiling (guix build store-copy).
>
> * guix/scripts/pack.scm (docker-image): Move (guix build store-copy) to within
> the source-module-closure call.

Good catch, got for it!

Thanks,
Ludo’.

bug#31942: [PATCH] pack: Fix guix pack -f docker.

[Christopher Baines]

[-- Attachment #1: Type: text/plain, Size: 514 bytes --]


Ludovic Courtès <ludo@gnu.org> writes:

> Hi Chris!
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> Without this change, running guix pack fails as (guix sets) is missing when
>> compiling (guix build store-copy).
>>
>> * guix/scripts/pack.scm (docker-image): Move (guix build store-copy) to within
>> the source-module-closure call.
>
> Good catch, got for it!

Great, I've pushed this now.

Note that the squashfs format looks to be similarly broken, but not
quite as simple to fix.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

[bug#31942] [PATCH] pack: Fix guix pack -f docker.

[Ludovic Courtès]

Christopher Baines <mail@cbaines.net> skribis:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hi Chris!
>>
>> Christopher Baines <mail@cbaines.net> skribis:
>>
>>> Without this change, running guix pack fails as (guix sets) is missing when
>>> compiling (guix build store-copy).
>>>
>>> * guix/scripts/pack.scm (docker-image): Move (guix build store-copy) to within
>>> the source-module-closure call.
>>
>> Good catch, got for it!
>
> Great, I've pushed this now.
>
> Note that the squashfs format looks to be similarly broken, but not
> quite as simple to fix.

Fixed in 66e9944e078cbb9e0d618377dd6df6e639640efa.

Thanks for the heads-up!

Ludo'.