From: "Ludovic Courtès" <ludo@gnu.org>
To: Lars-Dominik Braun <lars@6xq.net>
Cc: 58136@debbugs.gnu.org
Subject: [bug#58136] [PATCH] ui: Improve sort order when searching package names.
Date: Tue, 13 Dec 2022 17:40:36 +0100 [thread overview]
Message-ID: <87wn6vuuij.fsf@gnu.org> (raw)
In-Reply-To: <Y5iR9ey3ReyExwot@noor.fritz.box> (Lars-Dominik Braun's message of "Tue, 13 Dec 2022 15:53:41 +0100")
Hi,
Lars-Dominik Braun <lars@6xq.net> skribis:
>> Applied with the minor changes below, thank you!
> thank you!
>
>> +(test-assert "package-relevance and upstream name"
>> + ;; https://issues.guix.gnu.org/58136
>> + (let ((ggplot2 (specification->package "r-ggplot2"))
>> + (ggstance (specification->package "r-ggstance"))
>> + (rx (make-regexp "ggplot2" regexp/icase)))
>> + (> (package-relevance ggplot2 (list rx))
>> + (package-relevance ggstance (list rx))
>> + 0)))
> I was hesitant to add a system test, which depends on real package
> descriptions (not synthetic ones), because at some point it *will* break.
Yes, that’s a tradeoff. For now, I would think the test is a plus as it
will allow us to see if future tweaks break this use case but yeah, on
the day it breaks, we’ll have to rewrite it or to drop it.
Ludo’.
prev parent reply other threads:[~2022-12-13 16:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 9:27 [bug#58136] [PATCH] ui: Improve sort order when searching package names Lars-Dominik Braun
2022-09-28 14:26 ` zimoun
2022-09-28 20:23 ` Maxime Devos
2022-09-28 20:45 ` Maxime Devos
2022-09-28 21:40 ` zimoun
2022-09-28 21:43 ` Maxime Devos
2022-10-01 21:42 ` Ludovic Courtès
2022-10-02 8:26 ` zimoun
2022-10-12 11:24 ` Lars-Dominik Braun
2022-10-17 7:46 ` Ludovic Courtès
2022-10-17 8:19 ` zimoun
2022-12-09 11:49 ` Lars-Dominik Braun
2022-12-13 13:28 ` bug#58136: " Ludovic Courtès
2022-12-13 14:53 ` [bug#58136] " Lars-Dominik Braun
2022-12-13 16:40 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn6vuuij.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=58136@debbugs.gnu.org \
--cc=lars@6xq.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.