From: zimoun <zimon.toutoune@gmail.com>
To: Lars-Dominik Braun <lars@6xq.net>, 58136@debbugs.gnu.org
Cc: ludo@gnu.org
Subject: [bug#58136] [PATCH] ui: Improve sort order when searching package names.
Date: Wed, 28 Sep 2022 16:26:38 +0200 [thread overview]
Message-ID: <86wn9na82p.fsf@gmail.com> (raw)
In-Reply-To: <YzQTieJZSCJGTGY2@noor.fritz.box>
Hi Lars,
On Wed, 28 Sep 2022 at 11:27, Lars-Dominik Braun <lars@6xq.net> wrote:
> I propose we also score the unprefixed package name, so SCORE can award
> bonus points for a full string match. I don’t like that we have to
> maintain a list of common prefixes for this and that package names are
> scored twice now, but I can’t think of a better solution right now.
In addition to your proposal which LGTM, maybe we could also use the
’upstream-name’ properties. Most of the time, the Guix name matches the
upstream name, but sometimes not. Although, it would not fix the issue
for ggplot2 since there is no upstream-name for this package. :-)
Well, I propose something like see below (based on your patch):
1. keep the weight as 4
2. set the “namespace” weight to 1 (or 2 if you prefer)
Otherwise, for example, generic name as CSV could artificially bump
the relevance and hide relevant packages. For instance, compare
guix search csv
3. use upstream-name if provided
WDYT?
--8<---------------cut here---------------start------------->8---
diff --git a/guix/ui.scm b/guix/ui.scm
index 55b596ed35..14f296a546 100644
--- a/guix/ui.scm
+++ b/guix/ui.scm
@@ -1655,7 +1655,7 @@ (define (regexp->score regexp)
(define %package-metrics
;; Metrics used to compute the "relevance score" of a package against a set
;; of regexps.
- `((,package-name . 8)
+ `((,package-name . 4)
;; For packages with a language prefix (namespaces), also compare the
;; unprefixed name, so searching for “ggplot2” yields
@@ -1684,9 +1684,9 @@ (define %package-metrics
(if (string-prefix? prefix name)
(cons (substring name (string-length prefix)) accum)
accum))
- '()
+ (list (package-upstream-name package))
namespaces)))
- . 4)
+ . 1)
;; Match against uncommon outputs.
(,(lambda (package)
--8<---------------cut here---------------end--------------->8---
Cheers,
simon
next prev parent reply other threads:[~2022-09-28 15:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 9:27 [bug#58136] [PATCH] ui: Improve sort order when searching package names Lars-Dominik Braun
2022-09-28 14:26 ` zimoun [this message]
2022-09-28 20:23 ` Maxime Devos
2022-09-28 20:45 ` Maxime Devos
2022-09-28 21:40 ` zimoun
2022-09-28 21:43 ` Maxime Devos
2022-10-01 21:42 ` Ludovic Courtès
2022-10-02 8:26 ` zimoun
2022-10-12 11:24 ` Lars-Dominik Braun
2022-10-17 7:46 ` Ludovic Courtès
2022-10-17 8:19 ` zimoun
2022-12-09 11:49 ` Lars-Dominik Braun
2022-12-13 13:28 ` bug#58136: " Ludovic Courtès
2022-12-13 14:53 ` [bug#58136] " Lars-Dominik Braun
2022-12-13 16:40 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86wn9na82p.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=58136@debbugs.gnu.org \
--cc=lars@6xq.net \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.