From: zimoun <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>,
"Lars-Dominik Braun" <ldb@leibniz-psychology.org>
Cc: 58136@debbugs.gnu.org
Subject: [bug#58136] [PATCH] ui: Improve sort order when searching package names.
Date: Mon, 17 Oct 2022 10:19:48 +0200 [thread overview]
Message-ID: <877d0yoo9n.fsf@gmail.com> (raw)
In-Reply-To: <8735bmj3jf.fsf_-_@gnu.org>
Hi Lars, Ludo,
In short, I miss why the initial patch with a minor tweak is not enough
for covering the corner cases. :-)
On lun., 17 oct. 2022 at 09:46, Ludovic Courtès <ludo@gnu.org> wrote:
>> +++ b/guix/ui.scm
>> @@ -1623,10 +1623,23 @@ (define (relevance obj regexps metrics)
>> (define (score regexp str)
>> (fold-matches regexp str 0
>> (lambda (m score)
>> - (+ score
>> - (if (string=? (match:substring m) str)
>> - 5 ;exact match
>> - 1)))))
>> + (let* ((start (- (match:start m) 1))
>> + (end (match:end m))
>> + (left (if (>= start 0) (string-ref str start) #f))
>> + (right (if (< end (string-length str)) (string-ref str end) #f))
>> + (delimiter-classes '(Cc Cf Pd Pe Pf Pi Po Ps Sk Zs Zl Zp))
>> + (delim-left (or (member (and=> left char-general-category) delimiter-classes) (eq? left #f)))
>> + (delim-right (or (member (and=> right char-general-category) delimiter-classes) (eq? right #f))))
>> + (max score
>> + (cond
>> + ;; regexp is a full match for str.
>> + ((and (eq? left #f) (eq? right #f)) 4)
>> + ;; regexp matches a single word in str.
>> + ((and delim-left delim-right) 3)
>> + ;; regexp matches the beginning or end of a word in str.
>> + ((or delim-left delim-right) 2)
>> + ;; Everything else.
>> + (#t 1)))))))
>
> The intent is to have all regexps behave as if the user passed \<STR\>,
> is that right? Would be nice to have a comment clarifying that above
> and perhaps making it a separate change?
All this appears to me overcomplicated. Personally, I have to read it
many times to get the logic; while the initial patch was much clearer,
IMHO.
Other said, I am not convinced the complexity is worth the corner case.
The initial patch with the minor tweak I am proposing (maybe using
package-upstream-name*) appears to me enough for covering the corner
cases initially reported (as ggplot2).
>> @@ -1635,10 +1648,11 @@ (define (regexp->score regexp)
>> ((field . weight)
>> (match (field obj)
>> (#f relevance)
>> + ('() relevance)
>> ((? string? str)
>> - (+ relevance (* (score-regexp str) weight)))
>> + (max relevance (* (score-regexp str) weight)))
>> ((lst ...)
>> - (+ relevance (* weight (apply + (map score-regexp lst)))))))))
>> + (max relevance (* weight (apply max (map score-regexp lst)))))))))
>
> Intuitively I would expect scores to add up, otherwise we’re kinda
> losing information; so I would not make this change. WDYT?
I agree with Ludo that ’max’ is counterintuitive.
Well, could we list some examples (keyword and expectation)? Because
the initial patch with a minor tweak LGTM and covers ggplot2, csv, and
some others.
Cheers,
simon
next prev parent reply other threads:[~2022-10-17 9:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 9:27 [bug#58136] [PATCH] ui: Improve sort order when searching package names Lars-Dominik Braun
2022-09-28 14:26 ` zimoun
2022-09-28 20:23 ` Maxime Devos
2022-09-28 20:45 ` Maxime Devos
2022-09-28 21:40 ` zimoun
2022-09-28 21:43 ` Maxime Devos
2022-10-01 21:42 ` Ludovic Courtès
2022-10-02 8:26 ` zimoun
2022-10-12 11:24 ` Lars-Dominik Braun
2022-10-17 7:46 ` Ludovic Courtès
2022-10-17 8:19 ` zimoun [this message]
2022-12-09 11:49 ` Lars-Dominik Braun
2022-12-13 13:28 ` bug#58136: " Ludovic Courtès
2022-12-13 14:53 ` [bug#58136] " Lars-Dominik Braun
2022-12-13 16:40 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d0yoo9n.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=58136@debbugs.gnu.org \
--cc=ldb@leibniz-psychology.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.