From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#29492: tests/guix-system.sh failure on unbound variable check
Date: Thu, 30 Nov 2017 11:04:25 +0100
Message-ID: <87vahs5bh2.fsf@gnu.org>
References: <CY4PR11MB17188515B596D27AFBF0643BB73A0@CY4PR11MB1718.namprd11.prod.outlook.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50568)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eKLiO-0003dS-Rt
	for bug-guix@gnu.org; Thu, 30 Nov 2017 05:05:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eKLiI-0008BR-Ue
	for bug-guix@gnu.org; Thu, 30 Nov 2017 05:05:08 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:57124)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eKLiI-0008BB-PI
	for bug-guix@gnu.org; Thu, 30 Nov 2017 05:05:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eKLiI-0001js-CW
	for bug-guix@gnu.org; Thu, 30 Nov 2017 05:05:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.29492.B29492.15120362716644@debbugs.gnu.org>
In-Reply-To: <CY4PR11MB17188515B596D27AFBF0643BB73A0@CY4PR11MB1718.namprd11.prod.outlook.com>
	(Eric Bavier's message of "Tue, 28 Nov 2017 19:25:03 +0000")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Eric Bavier <bavier@cray.com>
Cc: 29492@debbugs.gnu.org

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi Eric,

Eric Bavier <bavier@cray.com> skribis:

> Latest guix master (2cdf78df2d3d5d88c7e6908754233cf37cce1e61) fails tests=
/guix-system.sh for me, on line 128.  This seems to be caused by the fact t=
hat the error output contains a multi-character column number:
>
> ```
> /tmp/bavier/tmpfile:9:14: In procedure #<procedure 3aba2820 ()>:
> /tmp/bavier/tmpfile:9:14: GRUB-config: unbound variable
> hint: Did you forget a `use-modules' form?

I suppose that=E2=80=99s with Guile 2.0, right?

So the patch would become:


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline

diff --git a/tests/guix-system.sh b/tests/guix-system.sh
index 4bb866adf..eaa0c4332 100644
--- a/tests/guix-system.sh
+++ b/tests/guix-system.sh
@@ -125,7 +125,8 @@ else
 	# See <http://bugs.gnu.org/26107>.
 	grep "$tmpfile:[49]:[0-9]: GRUB-config.*[Uu]nbound variable" "$errorfile"
     else
-	grep "$tmpfile:9:[0-9]: GRUB-config.*[Uu]nbound variable" "$errorfile"
+	# With Guile 2.0.14 the error is reported on line 14 (the last line).
+	grep "$tmpfile:9:[0-9]\+: GRUB-config.*[Uu]nbound variable" "$errorfile"
     fi
 fi
 

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Please push if it works for you.

Thanks,
Ludo=E2=80=99.

--=-=-=--