bug#31190: Ansible doesn't build

bug#31190: Ansible doesn't build

[Clément Lassieur]

starting phase `check'
running "python setup.py" with command "test" and parameters ()
running test
Searching for pynacl>=1.0.1
Reading https://pypi.python.org/simple/pynacl/
Download error on https://pypi.python.org/simple/pynacl/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'pynacl' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.python.org/simple/
Download error on https://pypi.python.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or working download links found for pynacl>=1.0.1
error: Could not find suitable distribution for Requirement.parse('pynacl>=1.0.1')
phase `check' failed after 0.5 seconds
builder for `/gnu/store/4mmlsi4rw7iwaw1nghkixbx859vi24ad-ansible-2.4.2.0.drv' failed with exit code 1
@ build-failed /gnu/store/4mmlsi4rw7iwaw1nghkixbx859vi24ad-ansible-2.4.2.0.drv - 1 builder for `/gnu/store/4mmlsi4rw7iwaw1nghkixbx859vi24ad-ansible-2.4.2.0.drv' failed with exit code 1
guix build: error: build failed: build of `/gnu/store/4mmlsi4rw7iwaw1nghkixbx859vi24ad-ansible-2.4.2.0.drv' failed

bug#31190: Ansible doesn't build

[Jelle Licht]

[-- Attachment #1.1: Type: text/plain, Size: 1471 bytes --]

2018-04-17 11:40 GMT+02:00 Clément Lassieur <clement@lassieur.org>:

> starting phase `check'
> running "python setup.py" with command "test" and parameters ()
> running test
> Searching for pynacl>=1.0.1
> Reading https://pypi.python.org/simple/pynacl/
> Download error on https://pypi.python.org/simple/pynacl/: [Errno -2] Name
> or service not known -- Some packages may not be found!
> Couldn't find index page for 'pynacl' (maybe misspelled?)
> Scanning index of all packages (this may take a while)
> Reading https://pypi.python.org/simple/
> Download error on https://pypi.python.org/simple/: [Errno -2] Name or
> service not known -- Some packages may not be found!
> No local packages or working download links found for pynacl>=1.0.1
> error: Could not find suitable distribution for
> Requirement.parse('pynacl>=1.0.1')
> phase `check' failed after 0.5 seconds
> builder for `/gnu/store/4mmlsi4rw7iwaw1nghkixbx859vi24ad-ansible-2.4.2.0.drv'
> failed with exit code 1
> @ build-failed /gnu/store/4mmlsi4rw7iwaw1nghkixbx859vi24ad-ansible-2.4.2.0.drv
> - 1 builder for `/gnu/store/4mmlsi4rw7iwaw1nghkixbx859vi24ad-ansible-2.4.2.0.drv'
> failed with exit code 1
> guix build: error: build failed: build of `/gnu/store/
> 4mmlsi4rw7iwaw1nghkixbx859vi24ad-ansible-2.4.2.0.drv' failed
>
>
>
>
The attached patches should fix this issue, but I am currently not able to
build them myself.
Could someone review + verify them?

- Jelle

[-- Attachment #1.2: Type: text/html, Size: 2323 bytes --]

[-- Attachment #2: 0001-gnu-Add-python2-pynacl.patch --]
[-- Type: text/x-patch, Size: 850 bytes --]

From 1c978fad25da3847d55fd6879a4473e84a9b02ff Mon Sep 17 00:00:00 2001
From: Jelle Licht <jlicht@fsfe.org>
Date: Tue, 17 Apr 2018 21:29:41 +0200
Subject: [PATCH] gnu: Add python2-pynacl.

* gnu/packages/python-crypto.scm (python2-pynacl): New variable.
---
 gnu/packages/python-crypto.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/python-crypto.scm b/gnu/packages/python-crypto.scm
index ace0891a7..9d5c35cac 100644
--- a/gnu/packages/python-crypto.scm
+++ b/gnu/packages/python-crypto.scm
@@ -587,6 +587,9 @@ Networking and Cryptography library.  These libraries have a stated goal
 of improving usability, security and speed.")
     (license license:asl2.0)))
 
+(define-public python2-pynacl
+  (package-with-python2 python-pynacl))
+
 (define-public python2-pgpdump
   (package
     (name "python2-pgpdump")
-- 
2.17.0


[-- Attachment #3: 0001-gnu-ansible-Add-missing-inputs.patch --]
[-- Type: text/x-patch, Size: 1368 bytes --]

From f770998d0f0b56180e0c9a12f0946a77d7ff61a5 Mon Sep 17 00:00:00 2001
From: Jelle Licht <jlicht@fsfe.org>
Date: Tue, 17 Apr 2018 21:31:05 +0200
Subject: [PATCH] gnu: ansible: Add missing inputs

* gnu/packages/admin.scm (ansible)[native-inputs]: Add python2-bcrypt and
  python2-pynacl.
---
 gnu/packages/admin.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index aed997e5b..07401af72 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -73,6 +73,7 @@
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages popt)
   #:use-module (gnu packages python)
+  #:use-module (gnu packages password-utils)
   #:use-module (gnu packages python-crypto)
   #:use-module (gnu packages python-web)
   #:use-module (gnu packages terminals)
@@ -1522,7 +1523,9 @@ of supported upstream metrics systems simultaneously.")
        (patches (search-patches "ansible-wrap-program-hack.patch"))))
     (build-system python-build-system)
     (native-inputs
-     `(("python2-pycrypto" ,python2-pycrypto)
+     `(("python2-bcrypt" ,python2-bcrypt)
+       ("python2-pycrypto" ,python2-pycrypto)
+       ("python2-pynacl" ,python2-pynacl)
        ("python2-httplib2" ,python2-httplib2)
        ("python2-passlib" ,python2-passlib)
        ("python2-nose" ,python2-nose)
-- 
2.17.0

bug#31190: Ansible doesn't build

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]

Jelle Licht <jlicht@fsfe.org> writes:

> From f770998d0f0b56180e0c9a12f0946a77d7ff61a5 Mon Sep 17 00:00:00 2001
> From: Jelle Licht <jlicht@fsfe.org>
> Date: Tue, 17 Apr 2018 21:31:05 +0200
> Subject: [PATCH] gnu: ansible: Add missing inputs
>
> * gnu/packages/admin.scm (ansible)[native-inputs]: Add python2-bcrypt and
>   python2-pynacl.
> ---
>  gnu/packages/admin.scm | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index aed997e5b..07401af72 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -73,6 +73,7 @@
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages popt)
>    #:use-module (gnu packages python)
> +  #:use-module (gnu packages password-utils)
>    #:use-module (gnu packages python-crypto)
>    #:use-module (gnu packages python-web)
>    #:use-module (gnu packages terminals)

This introduces a circular dependency between (gnu packages admin) and
(gnu packages password-utils).  Perhaps we should move python-bcrypt to
python-crypto.scm.  Thoughts?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#31190: Ansible doesn't build

[Jelle Licht]

[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]

2018-04-17 22:56 GMT+02:00 Marius Bakke <mbakke@fastmail.com>:

> Jelle Licht <jlicht@fsfe.org> writes:
>
> > From f770998d0f0b56180e0c9a12f0946a77d7ff61a5 Mon Sep 17 00:00:00 2001
> > From: Jelle Licht <jlicht@fsfe.org>
> > Date: Tue, 17 Apr 2018 21:31:05 +0200
> > Subject: [PATCH] gnu: ansible: Add missing inputs
> >
> > * gnu/packages/admin.scm (ansible)[native-inputs]: Add python2-bcrypt and
> >   python2-pynacl.
> > ---
> >  gnu/packages/admin.scm | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> > index aed997e5b..07401af72 100644
> > --- a/gnu/packages/admin.scm
> > +++ b/gnu/packages/admin.scm
> > @@ -73,6 +73,7 @@
> >    #:use-module (gnu packages pkg-config)
> >    #:use-module (gnu packages popt)
> >    #:use-module (gnu packages python)
> > +  #:use-module (gnu packages password-utils)
> >    #:use-module (gnu packages python-crypto)
> >    #:use-module (gnu packages python-web)
> >    #:use-module (gnu packages terminals)
>
> This introduces a circular dependency between (gnu packages admin) and
> (gnu packages password-utils).  Perhaps we should move python-bcrypt to
> python-crypto.scm.  Thoughts?
>

Makes sense to me. The `python-py-bcrypt' package is already located there
so it would make sense to have similar packages in the same place.

[-- Attachment #2: Type: text/html, Size: 1968 bytes --]

bug#31190: Ansible doesn't build

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1507 bytes --]

Jelle Licht <jlicht@fsfe.org> writes:

> 2018-04-17 22:56 GMT+02:00 Marius Bakke <mbakke@fastmail.com>:
>
>> Jelle Licht <jlicht@fsfe.org> writes:
>>
>> > From f770998d0f0b56180e0c9a12f0946a77d7ff61a5 Mon Sep 17 00:00:00 2001
>> > From: Jelle Licht <jlicht@fsfe.org>
>> > Date: Tue, 17 Apr 2018 21:31:05 +0200
>> > Subject: [PATCH] gnu: ansible: Add missing inputs
>> >
>> > * gnu/packages/admin.scm (ansible)[native-inputs]: Add python2-bcrypt and
>> >   python2-pynacl.
>> > ---
>> >  gnu/packages/admin.scm | 5 ++++-
>> >  1 file changed, 4 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
>> > index aed997e5b..07401af72 100644
>> > --- a/gnu/packages/admin.scm
>> > +++ b/gnu/packages/admin.scm
>> > @@ -73,6 +73,7 @@
>> >    #:use-module (gnu packages pkg-config)
>> >    #:use-module (gnu packages popt)
>> >    #:use-module (gnu packages python)
>> > +  #:use-module (gnu packages password-utils)
>> >    #:use-module (gnu packages python-crypto)
>> >    #:use-module (gnu packages python-web)
>> >    #:use-module (gnu packages terminals)
>>
>> This introduces a circular dependency between (gnu packages admin) and
>> (gnu packages password-utils).  Perhaps we should move python-bcrypt to
>> python-crypto.scm.  Thoughts?
>>
>
> Makes sense to me. The `python-py-bcrypt' package is already located there
> so it would make sense to have similar packages in the same place.

I went ahead and did this in 7c16af4646fac789000495064a13284691dbeb75.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#31190: Ansible doesn't build

[Clément Lassieur]

For the record, patches about it have been sent to guix-patches as well:
https://lists.gnu.org/archive/html/guix-patches/2018-04/msg00332.html.

Marius Bakke <mbakke@fastmail.com> writes:

> Jelle Licht <jlicht@fsfe.org> writes:
>
>> 2018-04-17 22:56 GMT+02:00 Marius Bakke <mbakke@fastmail.com>:
>>
>>> Jelle Licht <jlicht@fsfe.org> writes:
>>>
>>> > From f770998d0f0b56180e0c9a12f0946a77d7ff61a5 Mon Sep 17 00:00:00 2001
>>> > From: Jelle Licht <jlicht@fsfe.org>
>>> > Date: Tue, 17 Apr 2018 21:31:05 +0200
>>> > Subject: [PATCH] gnu: ansible: Add missing inputs
>>> >
>>> > * gnu/packages/admin.scm (ansible)[native-inputs]: Add python2-bcrypt and
>>> >   python2-pynacl.
>>> > ---
>>> >  gnu/packages/admin.scm | 5 ++++-
>>> >  1 file changed, 4 insertions(+), 1 deletion(-)
>>> >
>>> > diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
>>> > index aed997e5b..07401af72 100644
>>> > --- a/gnu/packages/admin.scm
>>> > +++ b/gnu/packages/admin.scm
>>> > @@ -73,6 +73,7 @@
>>> >    #:use-module (gnu packages pkg-config)
>>> >    #:use-module (gnu packages popt)
>>> >    #:use-module (gnu packages python)
>>> > +  #:use-module (gnu packages password-utils)
>>> >    #:use-module (gnu packages python-crypto)
>>> >    #:use-module (gnu packages python-web)
>>> >    #:use-module (gnu packages terminals)
>>>
>>> This introduces a circular dependency between (gnu packages admin) and
>>> (gnu packages password-utils).  Perhaps we should move python-bcrypt to
>>> python-crypto.scm.  Thoughts?
>>>
>>
>> Makes sense to me. The `python-py-bcrypt' package is already located there
>> so it would make sense to have similar packages in the same place.
>
> I went ahead and did this in 7c16af4646fac789000495064a13284691dbeb75.

bug#31190: Ansible doesn't build

[Roel Janssen]

Clément Lassieur <clement@lassieur.org> writes:

> For the record, patches about it have been sent to guix-patches as well:
> https://lists.gnu.org/archive/html/guix-patches/2018-04/msg00332.html.

Right. I didn't see these.  You can ignore mine then.


>
> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Jelle Licht <jlicht@fsfe.org> writes:
>>
>>> 2018-04-17 22:56 GMT+02:00 Marius Bakke <mbakke@fastmail.com>:
>>>
>>>> Jelle Licht <jlicht@fsfe.org> writes:
>>>>
>>>> > From f770998d0f0b56180e0c9a12f0946a77d7ff61a5 Mon Sep 17 00:00:00 2001
>>>> > From: Jelle Licht <jlicht@fsfe.org>
>>>> > Date: Tue, 17 Apr 2018 21:31:05 +0200
>>>> > Subject: [PATCH] gnu: ansible: Add missing inputs
>>>> >
>>>> > * gnu/packages/admin.scm (ansible)[native-inputs]: Add python2-bcrypt and
>>>> >   python2-pynacl.
>>>> > ---
>>>> >  gnu/packages/admin.scm | 5 ++++-
>>>> >  1 file changed, 4 insertions(+), 1 deletion(-)
>>>> >
>>>> > diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
>>>> > index aed997e5b..07401af72 100644
>>>> > --- a/gnu/packages/admin.scm
>>>> > +++ b/gnu/packages/admin.scm
>>>> > @@ -73,6 +73,7 @@
>>>> >    #:use-module (gnu packages pkg-config)
>>>> >    #:use-module (gnu packages popt)
>>>> >    #:use-module (gnu packages python)
>>>> > +  #:use-module (gnu packages password-utils)
>>>> >    #:use-module (gnu packages python-crypto)
>>>> >    #:use-module (gnu packages python-web)
>>>> >    #:use-module (gnu packages terminals)
>>>>
>>>> This introduces a circular dependency between (gnu packages admin) and
>>>> (gnu packages password-utils).  Perhaps we should move python-bcrypt to
>>>> python-crypto.scm.  Thoughts?
>>>>
>>>
>>> Makes sense to me. The `python-py-bcrypt' package is already located there
>>> so it would make sense to have similar packages in the same place.
>>
>> I went ahead and did this in 7c16af4646fac789000495064a13284691dbeb75.

bug#31190: Ansible doesn't build

[Jelle Licht]

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

I pushed my version of the patches that fix our ansible build as
`09e3cf583437ce421215dd28d2b94f574458b311'
and `acc6e6955f5d481cf984cafb0459d3489feda99e' to master.

[-- Attachment #2: Type: text/html, Size: 217 bytes --]

bug#31219: bug#31190: Ansible doesn't build

[Jelle Licht]

[-- Attachment #1: Type: text/plain, Size: 166 bytes --]

I pushed my version of the patches that fix our ansible build as
`09e3cf583437ce421215dd28d2b94f574458b311'
and `acc6e6955f5d481cf984cafb0459d3489feda99e' to master.

[-- Attachment #2: Type: text/html, Size: 217 bytes --]

bug#31190: Ansible doesn't build

[Clément Lassieur]

Jelle Licht <jlicht@fsfe.org> writes:

> I pushed my version of the patches that fix our ansible build as
> `09e3cf583437ce421215dd28d2b94f574458b311'
> and `acc6e6955f5d481cf984cafb0459d3489feda99e' to master.

Great, thank you!

[bug#31219] bug#31190: Ansible doesn't build

[Clément Lassieur]

Jelle Licht <jlicht@fsfe.org> writes:

> I pushed my version of the patches that fix our ansible build as
> `09e3cf583437ce421215dd28d2b94f574458b311'
> and `acc6e6955f5d481cf984cafb0459d3489feda99e' to master.

Great, thank you!