From: Fredrik Salomonsson <plattfot@posteo.net>
To: Maxime Devos <maximedevos@telenet.be>, 55420@debbugs.gnu.org
Subject: [bug#55420] [PATCH v2 1/2] guix: emacs-utils: Add emacs-batch-script.
Date: Sun, 05 Jun 2022 20:02:42 +0000 [thread overview]
Message-ID: <87v8teop3x.fsf@posteo.net> (raw)
In-Reply-To: <38a5e03d835b2daa2dd1959048f1d03f6f5a48cd.camel@telenet.be>
Hi Maxime,
Maxime Devos <maximedevos@telenet.be> writes:
> Fredrik Salomonsson schreef op zo 05-06-2022 om 00:19 [+0000]:
>> +(test-equal "print foo from emacs"
>> + "foo"
>> + (emacs-batch-script '(princ "foo")))
>
> IIUC, this can only be run if emacs is in $PATH when running the tests,
> so sometimes the test needs to be skipped. As an example on how to do
> this, see the "pypi->guix-package, wheels" test in tests/pypi.scm.
Yes, you are correct. All my tests started to fail when I added `--pure`
to my test command.
I just sent in a v3 of the patches when I skip the tests if emacs is not
in the PATH.
I also changed the tests for the `emacs-header-parse` to be wrapped by
`call-with-temporary-directory`. It felt wasteful to create and destroy that
file for each test when the file is static.
I opted to just have one test-skip and skip all five of them. Although
that migth be too fragile. Would be great to have something like:
(unless (which "emacs")
(test-skip "emacs-batch-script:")
(test-skip "emacs-header-parse:"))
But the docs just mention a counter or the full name of a test.
--
s/Fred[re]+i[ck]+/Fredrik/g
next prev parent reply other threads:[~2022-06-05 20:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-14 23:00 [bug#55420] [PATCH 0/2] Add a function to parse emacs elisp's package header Fredrik Salomonsson
2022-05-14 23:05 ` [bug#55420] [PATCH 1/2] guix: emacs-utils: Add emacs-batch-script Fredrik Salomonsson
2022-05-14 23:05 ` [bug#55420] [PATCH 2/2] guix: emacs-utils: Add emacs-header-parse Fredrik Salomonsson
2022-06-01 20:39 ` [bug#55420] [PATCH 0/2] Add a function to parse emacs elisp's package header Ludovic Courtès
2022-06-01 20:38 ` Ludovic Courtès
2022-06-02 2:53 ` Fredrik Salomonsson
2022-06-02 13:44 ` Ludovic Courtès
2022-06-05 0:42 ` Fredrik Salomonsson
2022-06-05 0:19 ` [bug#55420] [PATCH v2 1/2] guix: emacs-utils: Add emacs-batch-script Fredrik Salomonsson
2022-06-05 0:19 ` [bug#55420] [PATCH v2 2/2] guix: emacs-utils: Add emacs-header-parse Fredrik Salomonsson
2022-06-05 9:52 ` [bug#55420] [PATCH v2 1/2] guix: emacs-utils: Add emacs-batch-script Maxime Devos
2022-06-05 20:02 ` Fredrik Salomonsson [this message]
2022-06-05 19:51 ` [bug#55420] [PATCH v3 " Fredrik Salomonsson
2022-06-05 19:51 ` [bug#55420] [PATCH v3 2/2] guix: emacs-utils: Add emacs-header-parse Fredrik Salomonsson
2022-06-17 20:29 ` bug#55420: [PATCH 0/2] Add a function to parse emacs elisp's package header Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8teop3x.fsf@posteo.net \
--to=plattfot@posteo.net \
--cc=55420@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.