From: Fredrik Salomonsson <plattfot@posteo.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 55420@debbugs.gnu.org
Subject: [bug#55420] [PATCH 0/2] Add a function to parse emacs elisp's package header
Date: Sun, 05 Jun 2022 00:42:34 +0000 [thread overview]
Message-ID: <87h750rldx.fsf@posteo.net> (raw)
In-Reply-To: <87fsknp4bu.fsf@gnu.org>
Hi Ludo,
Ludovic Courtès <ludo@gnu.org> writes:
> Hi,
>
> Fredrik Salomonsson <plattfot@posteo.net> skribis:
>
>> Here is what I have so far:
>>
>> (define-condition-type &emacs-batch-error &error
>> emacs-batch-error?
>> (expression emacs-batch-error-expression)
>> (message emacs-batch-error-message))
>>
>> (define (emacs-batch-script expr)
>> "Execute the Elisp code EXPR in Emacs batch mode and return output."
>> (let* ((error-pipe (open-output-string))
>> (pipe (with-error-to-port error-pipe
>> (lambda ()
>> (open-pipe*
>> OPEN_READ
>> (%emacs) "--quick" "--batch"
>> (string-append "--eval=" (expr->string expr))))))
>> (output (read-string pipe))
>> (error (get-output-string error-pipe))
>> (status (close-pipe pipe)))
>> (unless (zero? status)
>> (raise (condition (&emacs-batch-error
>> (expression expr)
>> (message error)))))
>> output))
>
> Unfortunately ‘open-pipe*’ is not smart enough to redirect stderr to a
> non-file port (a string port in this case).
>
> One way around it would be to merge stdout and stderr, like so:
>
> (parameterize ((current-error-port (current-output-port)))
> (open-pipe* …))
>
> but then you get both on the same stream, which could be a problem for
> instance if Emacs emits warnings and such.
>
> You could work around it by establishing a second pipe:
>
> (match (pipe)
> ((stderr-input . stderr-output)
> (parameterize ((current-error-port stderr-output))
> (open-pipe* …))))
>
> Here you should be able to read, in the parent process, from
> ‘stderr-input’.
>
> Another option is to not try to capture stderr: after all, that’ll get
> printed on the screen anyway.
I just sent in v2 of the patches. Changes are:
- emacs-batch-script will now raise an &emacs-batch-error if emacs batch
script fails. I opted to capture the stderr and package that up in the
condition. Thank you for the pointers! I removed the expression slot I
had in my prototype. It felt redundant, emacs error message should be
enough.
- tests/build-emacs-utils.scm: I added tests for the two new procedures.
It was good that I added the tests as I had missed to use (srfi srfi-34)
in build/emacs-utils.scm during my prototyping and that generated the
cryptic error:
Wrong type (expecting exact integer): #<&emacs-batch-error…>
Took me a while to figure that one out. But now all is good. The tests
are passing.
Thanks again.
--
s/Fred[re]+i[ck]+/Fredrik/g
next prev parent reply other threads:[~2022-06-05 0:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-14 23:00 [bug#55420] [PATCH 0/2] Add a function to parse emacs elisp's package header Fredrik Salomonsson
2022-05-14 23:05 ` [bug#55420] [PATCH 1/2] guix: emacs-utils: Add emacs-batch-script Fredrik Salomonsson
2022-05-14 23:05 ` [bug#55420] [PATCH 2/2] guix: emacs-utils: Add emacs-header-parse Fredrik Salomonsson
2022-06-01 20:39 ` [bug#55420] [PATCH 0/2] Add a function to parse emacs elisp's package header Ludovic Courtès
2022-06-01 20:38 ` Ludovic Courtès
2022-06-02 2:53 ` Fredrik Salomonsson
2022-06-02 13:44 ` Ludovic Courtès
2022-06-05 0:42 ` Fredrik Salomonsson [this message]
2022-06-05 0:19 ` [bug#55420] [PATCH v2 1/2] guix: emacs-utils: Add emacs-batch-script Fredrik Salomonsson
2022-06-05 0:19 ` [bug#55420] [PATCH v2 2/2] guix: emacs-utils: Add emacs-header-parse Fredrik Salomonsson
2022-06-05 9:52 ` [bug#55420] [PATCH v2 1/2] guix: emacs-utils: Add emacs-batch-script Maxime Devos
2022-06-05 20:02 ` Fredrik Salomonsson
2022-06-05 19:51 ` [bug#55420] [PATCH v3 " Fredrik Salomonsson
2022-06-05 19:51 ` [bug#55420] [PATCH v3 2/2] guix: emacs-utils: Add emacs-header-parse Fredrik Salomonsson
2022-06-17 20:29 ` bug#55420: [PATCH 0/2] Add a function to parse emacs elisp's package header Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h750rldx.fsf@posteo.net \
--to=plattfot@posteo.net \
--cc=55420@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.