From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id OACBMgMMnWK4DgAAbAwnHQ (envelope-from ) for ; Sun, 05 Jun 2022 22:03:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id +DKjMQMMnWKyigAAG6o9tA (envelope-from ) for ; Sun, 05 Jun 2022 22:03:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 772931F507 for ; Sun, 5 Jun 2022 22:03:15 +0200 (CEST) Received: from localhost ([::1]:53910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nxwSv-0005HQ-JZ for larch@yhetil.org; Sun, 05 Jun 2022 16:03:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nxwSk-0005HE-Bm for guix-patches@gnu.org; Sun, 05 Jun 2022 16:03:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39677) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nxwSk-00055c-2w for guix-patches@gnu.org; Sun, 05 Jun 2022 16:03:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nxwSj-0007bU-Tx for guix-patches@gnu.org; Sun, 05 Jun 2022 16:03:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55420] [PATCH v2 1/2] guix: emacs-utils: Add emacs-batch-script. Resent-From: Fredrik Salomonsson Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 05 Jun 2022 20:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55420 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , 55420@debbugs.gnu.org Received: via spool by 55420-submit@debbugs.gnu.org id=B55420.165445937329211 (code B ref 55420); Sun, 05 Jun 2022 20:03:01 +0000 Received: (at 55420) by debbugs.gnu.org; 5 Jun 2022 20:02:53 +0000 Received: from localhost ([127.0.0.1]:33574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxwSb-0007b4-6f for submit@debbugs.gnu.org; Sun, 05 Jun 2022 16:02:53 -0400 Received: from mout02.posteo.de ([185.67.36.66]:46535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nxwSZ-0007as-LX for 55420@debbugs.gnu.org; Sun, 05 Jun 2022 16:02:52 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id DC0DC240108 for <55420@debbugs.gnu.org>; Sun, 5 Jun 2022 22:02:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1654459365; bh=0UXnvbUT3M0yutIDEd8qlc9RkRufBpQcjcn9TL0wD3o=; h=From:To:Subject:Date:From; b=Fe48K6WtcKBYd0iCo46iUM1jw9678nmTLMHJxcfAcF/mE1CgglGLGtOgOK2MYvnGR iChdkG2G5xwJmr+gtrCcqlFyLjPla0UmBxNDQVoxZcROW2VcXEY3Ip1Af84wk+Sc7c lB11SuIi4bEGmlCtrb3XU9MnxR68kYv/TmdQQkDFXhiku8aVrqO8FR2yI/soETf0PX erLptkykPXmnBa7HCowezeXW30avzIEox2hAZrKWlCZAQ9cIC9MV5BP3/WE1IXbYRv bUy1PovaLHgZfHPGfZSGDb5WoyUm0lg/8RBYyoQWme6MyU/xsQGj3xB0AO+hvWA01R HSLaKmCslVUiw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4LGSGD5K0wz6tnZ; Sun, 5 Jun 2022 22:02:44 +0200 (CEST) From: Fredrik Salomonsson In-Reply-To: <38a5e03d835b2daa2dd1959048f1d03f6f5a48cd.camel@telenet.be> References: <20220514230017.27372-1-plattfot@posteo.net> <20220605001924.184934-1-plattfot@posteo.net> <38a5e03d835b2daa2dd1959048f1d03f6f5a48cd.camel@telenet.be> Date: Sun, 05 Jun 2022 20:02:42 +0000 Message-ID: <87v8teop3x.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654459395; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=MoW4N4HZjXO+eeKvCdAva604012Q0xvsMevZPwRUXpE=; b=hQmEJMxlE7aGgSjaM6XDkfJAgxvmNJRW6bnrWLYGJG0GN9A4TwEoyK22n0A17e3nPiL8Lg CsbirQRxe191bGIg105WbJIbOPar1RzJ6805LlwUitDhOVy3G3JCbncvQOshSmzxdcTIau WjCHFUvAujc7xElnUvRoAC06phsE915JBagIUQgCCQ0YprmxdELJSooj/iP01LQPu44KaX 9crORNiu40D1S1jBX6nhSebbSK9EelQhhobtn6Z4mrCj/NENhvE6Zaxx9PxXekYMgGPaEj v6EsZKxhCbJwzGx/QzaklQBEE6mStBXMfLy7Eg4wp33WAP52EOfm/LLGL72mtg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654459395; a=rsa-sha256; cv=none; b=C7fKkBvMOqW3fZHCmqgLl8jqCIJ6ocMlGzwwQcQMojkIs15H2kAJQVKKtN4kewWbPIrYcx SOht9rdE2ebvSKyx6CnE0xOqMUXFqJ14OHjX6g0GEf9L1MkUHWU7Gq+svmC3qRCAnq0wEA FoSPCCbm1zmrU8ORZr1PN8hgKo6iwHMW1IkAWW4zgFEXXEyCUm7plVco/t8RW6/SEITVED YcGMzbLuU7kRmAJQV6ioHQ7fzpZ1n2w0Pxn+kPVw05Cf4kR8g/Wy55IiTGqzfRAZ3nAqTf ZuM03BxakcCMurC8cb18kBXlrFS8rUWpNzI/gKgxtpj21itVZqBIe4nVIDz3ag== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=Fe48K6Wt; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.49 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=Fe48K6Wt; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 772931F507 X-Spam-Score: 6.49 X-Migadu-Scanner: scn0.migadu.com X-TUID: 258rJ2fXQ1gJ Hi Maxime, Maxime Devos writes: > Fredrik Salomonsson schreef op zo 05-06-2022 om 00:19 [+0000]: >> +(test-equal "print foo from emacs" >> +=C2=A0 "foo" >> +=C2=A0 (emacs-batch-script '(princ "foo"))) > > IIUC, this can only be run if emacs is in $PATH when running the tests, > so sometimes the test needs to be skipped. As an example on how to do > this, see the "pypi->guix-package, wheels" test in tests/pypi.scm. Yes, you are correct. All my tests started to fail when I added `--pure` to my test command. I just sent in a v3 of the patches when I skip the tests if emacs is not in the PATH. I also changed the tests for the `emacs-header-parse` to be wrapped by `call-with-temporary-directory`. It felt wasteful to create and destroy that file for each test when the file is static. I opted to just have one test-skip and skip all five of them. Although that migth be too fragile. Would be great to have something like: (unless (which "emacs") (test-skip "emacs-batch-script:") (test-skip "emacs-header-parse:")) But the docs just mention a counter or the full name of a test. --=20 s/Fred[re]+i[ck]+/Fredrik/g