all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Guix Devel <guix-devel@gnu.org>
Subject: Re: branch master updated: remote-server: Fix fetch worker crash.
Date: Mon, 06 Dec 2021 09:50:20 +0100	[thread overview]
Message-ID: <87tufm15ir.fsf@gnu.org> (raw)
In-Reply-To: <87o85uu4uc.fsf@gnu.org> ("Ludovic Courtès"'s message of "Sun, 05 Dec 2021 22:19:55 +0100")


Hey Ludo,

> I think it’s be safer (less prone to TOCTTOU races) to write it as:
>
>   (catch 'system-error
>     (lambda ()
>       (register-gc-roots drv))
>     (lambda args
>       (unless (= ENOENT (system-error-errno args)) ;collected in the meantime
>         (apply throw args))))

Oh, indeed! Fixed with 6dcf2f65cea920b9b1c265de3e2b0abe0048a08e.

Thanks,

Mathieu


      reply	other threads:[~2021-12-06  8:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20211203093835.634.3648@vcs0.savannah.gnu.org>
2021-12-05 21:19 ` branch master updated: remote-server: Fix fetch worker crash Ludovic Courtès
2021-12-06  8:50   ` Mathieu Othacehe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tufm15ir.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.