From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 2B8OIvnOrWF9QgEAgWs5BA (envelope-from ) for ; Mon, 06 Dec 2021 09:51:05 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 2PWvHfnOrWHrHQAAbx9fmQ (envelope-from ) for ; Mon, 06 Dec 2021 08:51:05 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5418EB278 for ; Mon, 6 Dec 2021 09:51:05 +0100 (CET) Received: from localhost ([::1]:58378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mu9iB-0006pE-Vo for larch@yhetil.org; Mon, 06 Dec 2021 03:51:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46988) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mu9hW-0006lg-75 for guix-devel@gnu.org; Mon, 06 Dec 2021 03:50:26 -0500 Received: from [2001:470:142:3::e] (port=42396 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mu9hV-0002eT-Ru; Mon, 06 Dec 2021 03:50:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=/RIaxr3IH2HWJE91Wgj/JaedgN8iCJSHurX607Pwi70=; b=B7irZtgVOMHvxfHqUY56 K68Kx6xf1zH7HtG5hlxKBNX5enft7i192MLrBd2sdy7HRC5+3rHB2aTBGigzL8DS4q3xBC93FnKj3 WJ9Js7cUX6mRfkmZnjKRfnnha9z+ikm7BDtOdpt52Hzsy6oZDZrhopvo+8gZuPCHvRzfhzOfG6bdz +6q7pZn1LmnDAMDjEaIMW9Uay1crNswMlqqhWfn0peapDrac3QTUQKfvx7ppjskF5six1bdKcKqXk t2jT008jjP9iMwUKL1NbJHaF89LK3NjGGGWvXRf2p62+MuXqh5g8YZrmblMJMuzNVqW82sq1ZQTB3 LmznmbfdmVYdiQ==; Received: from [2a01:e0a:19b:d9a0:2ddb:d3d2:32e8:d31a] (port=48944 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mu9hV-0006Gt-NQ; Mon, 06 Dec 2021 03:50:21 -0500 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: branch master updated: remote-server: Fix fetch worker crash. References: <20211203093835.634.3648@vcs0.savannah.gnu.org> <87o85uu4uc.fsf@gnu.org> Date: Mon, 06 Dec 2021 09:50:20 +0100 In-Reply-To: <87o85uu4uc.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sun, 05 Dec 2021 22:19:55 +0100") Message-ID: <87tufm15ir.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Guix Devel Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: "Guix-devel" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1638780665; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=/RIaxr3IH2HWJE91Wgj/JaedgN8iCJSHurX607Pwi70=; b=pkzEAgbtougX8twXMVEdbse3j3YmqWs7bNauC9AbU94PQgJM6JibnUpnWg3ktaRBYeaxdp eDEXAFHTm8WmkJpmoZVONUwFL4SNEnt6fNtl0mGZ0RAuH2pEthlArI+eLLtyrEvS1/pmA5 yIdeZP1h5ry3v7/L7ZewueoasdPIs7pL3uNgchv2FKCFoxcrXJUk1g5EoGAAAzfRqMbIXx DBAIzD2MYCAHznPllGPVe6Nn1ze7ce3zyiHiwTgxyaC5sOV4NmitW7UgTr/5+aE26+A1vk 2L1Et6a0rPIgBH5HqVdGF5kRb8KOwNWl+4vQ1q6jsTPx0+bXFA4R9wKKbB38Bw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1638780665; a=rsa-sha256; cv=none; b=ncGQaXJvwRJY1t0uU9JUWCNC6cRZMIgR3fg90GTFjPgexp7mWHJWiAWwuC4MfvNVJAuX0z 2Sw8ehQHPAS2rtJHHpUYHu1sWBZa65LVg7ixWd6+yLYL6BEz/nsTkSUmVlZ0i1WOw5giKu AD+ye5vTetJLf+UtM56m7w7x3O1cfXln9Z2faiK0u6VbUgNqxIGmISxWDoASZ6XGiitktW yd0rGX59VK/U/2vWEVq/VHn5IX1zgPOR+X0oOeXjbm6nM+I8VnxfsnEkDXFcW19d5z/jPs QIHG024OlfYaGjobHY4R8+Mu8Dmkb80ZHr0XV73R5J8xX377e2ESQK66PSK9ew== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=B7irZtgV; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.34 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gnu.org header.s=fencepost-gnu-org header.b=B7irZtgV; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5418EB278 X-Spam-Score: -5.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: ij2xfKdQyHcw Hey Ludo, > I think it=E2=80=99s be safer (less prone to TOCTTOU races) to write it a= s: > > (catch 'system-error > (lambda () > (register-gc-roots drv)) > (lambda args > (unless (=3D ENOENT (system-error-errno args)) ;collected in the me= antime > (apply throw args)))) Oh, indeed! Fixed with 6dcf2f65cea920b9b1c265de3e2b0abe0048a08e. Thanks, Mathieu