From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: jgart <jgart@dismail.de>
Cc: 54584@debbugs.gnu.org
Subject: [bug#54584] [PATCH v2] gnu: python-slixmpp: Update to 1.8.1.
Date: Sat, 23 Apr 2022 23:32:53 -0400 [thread overview]
Message-ID: <87tuaj2m1m.fsf@gmail.com> (raw)
In-Reply-To: <20220416142609.11144-1-jgart@dismail.de> (jgart@dismail.de's message of "Sat, 16 Apr 2022 10:26:10 -0400")
Hi jgart,
jgart <jgart@dismail.de> writes:
> * gnu/packages/python-xyz.scm (python-slixmpp): Update to 1.8.1.
> [arguments]: Remove trailing boolean, use new style, and use
> cc-for-target.
> [native-inputs]: Use new style.
>
> Hi Maxim,
>
> Here is the second version of this patch.
>
> I think this adds what you suggested in the code review.
>
> thanks,
>
> jgart
>
> ---
> gnu/packages/python-xyz.scm | 25 ++++++++++++-------------
> 1 file changed, 12 insertions(+), 13 deletions(-)
>
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 219a0d9213..1654fc2894 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -688,7 +688,7 @@ (define-public python-mkdocs-material
> (define-public python-slixmpp
> (package
> (name "python-slixmpp")
> - (version "1.5.2")
> + (version "1.8.1")
> (source
> (origin
> (method git-fetch)
> @@ -700,21 +700,20 @@ (define-public python-slixmpp
> (file-name
> (git-file-name name version))
> (sha256
> - (base32 "15mqxcws14bjvh5jcfwl86zsvrymkdw3ya07vb44md7vfnsnclwx"))))
> + (base32 "0723m7pbyf4xnsy381drni3kr8wm60637gn6d7fbf4i5m04jy9iy"))))
> (build-system python-build-system)
> (arguments
> - `(#:phases
> - (modify-phases %standard-phases
> - (add-after 'unpack 'patch
> - (lambda _
> - (substitute* "setup.py"
> - (("'CC', 'cc'")
> - "'CC', 'gcc'"))
> - #t)))))
> + (list #:phases
> + #~(modify-phases %standard-phases
> + (add-after 'unpack 'patch
> + (lambda _
> + (substitute* "setup.py"
> + (((string-append "'CC', " #$(cc-for-target)))
> + ((string-append "'CC', " #$(cc-for-target))))))))))
This doesn't look right; the matched pattern is replaced by... the same
thing?
> (native-inputs
> - `(("cython" ,python-cython)
> - ("gnupg" ,gnupg)
> - ("pkg-config" ,pkg-config)))
> + (list python-cython
> + gnupg
> + pkg-config))
Are you sure pkg-config is needed? That's unusual in Python packages.
Thanks,
Maxim
next prev parent reply other threads:[~2022-04-24 3:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-26 18:27 [bug#54584] [PATCH] gnu: python-slixmpp: Update to 1.8.1 jgart via Guix-patches via
2022-03-26 21:16 ` Maxime Devos
2022-04-16 14:26 ` [bug#54584] [PATCH v2] " jgart via Guix-patches via
2022-04-16 15:25 ` Maxime Devos
2022-04-24 3:32 ` Maxim Cournoyer [this message]
2022-04-24 6:15 ` jgart via Guix-patches via
2022-05-22 5:08 ` [bug#54584] [PATCH] " Maxim Cournoyer
2022-05-22 19:35 ` jgart via Guix-patches via
2023-09-01 23:41 ` bug#54584: " Vagrant Cascadian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuaj2m1m.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=54584@debbugs.gnu.org \
--cc=jgart@dismail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.