all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: jgart via Guix-patches via <guix-patches@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 54584@debbugs.gnu.org
Subject: [bug#54584] [PATCH v2] gnu: python-slixmpp: Update to 1.8.1.
Date: Sun, 24 Apr 2022 02:15:51 -0400	[thread overview]
Message-ID: <20220424021551.GD18799@gac.attlocal.net> (raw)
In-Reply-To: <87tuaj2m1m.fsf@gmail.com>

On Sat, 23 Apr 2022 23:32:53 -0400 Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
> > +      (list #:phases
> > +            #~(modify-phases %standard-phases
> > +                (add-after 'unpack 'patch
> > +                  (lambda _
> > +                    (substitute* "setup.py"
> > +                      (((string-append "'CC', " #$(cc-for-target)))
> > +                       ((string-append "'CC', " #$(cc-for-target))))))))))
> 
> This doesn't look right; the matched pattern is replaced by... the same
> thing?

Oh yes, that was definitely a blunder. I'll send a patch fixing that soon.

> 
> >      (native-inputs
> > -     `(("cython" ,python-cython)
> > -       ("gnupg" ,gnupg)
> > -       ("pkg-config" ,pkg-config)))
> > +      (list python-cython
> > +            gnupg
> > +            pkg-config))
> 
> Are you sure pkg-config is needed?  That's unusual in Python packages.

I'll check that. That was there from the previous commit on the package.




  reply	other threads:[~2022-04-24  6:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-26 18:27 [bug#54584] [PATCH] gnu: python-slixmpp: Update to 1.8.1 jgart via Guix-patches via
2022-03-26 21:16 ` Maxime Devos
2022-04-16 14:26 ` [bug#54584] [PATCH v2] " jgart via Guix-patches via
2022-04-16 15:25   ` Maxime Devos
2022-04-24  3:32   ` Maxim Cournoyer
2022-04-24  6:15     ` jgart via Guix-patches via [this message]
2022-05-22  5:08       ` [bug#54584] [PATCH] " Maxim Cournoyer
2022-05-22 19:35         ` jgart via Guix-patches via
2023-09-01 23:41 ` bug#54584: " Vagrant Cascadian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220424021551.GD18799@gac.attlocal.net \
    --to=guix-patches@gnu.org \
    --cc=54584@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.