From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id YBOzODfFZGIBCgAAbAwnHQ (envelope-from ) for ; Sun, 24 Apr 2022 05:34:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id tY+5ODfFZGIAUQEA9RJhRA (envelope-from ) for ; Sun, 24 Apr 2022 05:34:15 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7BF87D530 for ; Sun, 24 Apr 2022 05:34:15 +0200 (CEST) Received: from localhost ([::1]:42758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1niT0o-0005Ed-FA for larch@yhetil.org; Sat, 23 Apr 2022 23:34:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1niT0b-0005D9-U9 for guix-patches@gnu.org; Sat, 23 Apr 2022 23:34:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:35360) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1niT0b-0006np-M1 for guix-patches@gnu.org; Sat, 23 Apr 2022 23:34:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1niT0b-0008CA-Jc for guix-patches@gnu.org; Sat, 23 Apr 2022 23:34:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54584] [PATCH v2] gnu: python-slixmpp: Update to 1.8.1. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 24 Apr 2022 03:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54584 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: jgart Cc: 54584@debbugs.gnu.org Received: via spool by 54584-submit@debbugs.gnu.org id=B54584.165077118331425 (code B ref 54584); Sun, 24 Apr 2022 03:34:01 +0000 Received: (at 54584) by debbugs.gnu.org; 24 Apr 2022 03:33:03 +0000 Received: from localhost ([127.0.0.1]:57490 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1niSze-0008Am-Ok for submit@debbugs.gnu.org; Sat, 23 Apr 2022 23:33:03 -0400 Received: from mail-qk1-f171.google.com ([209.85.222.171]:41901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1niSzd-0008AH-6j for 54584@debbugs.gnu.org; Sat, 23 Apr 2022 23:33:01 -0400 Received: by mail-qk1-f171.google.com with SMTP id s70so8628051qke.8 for <54584@debbugs.gnu.org>; Sat, 23 Apr 2022 20:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=o5W4VnSDneS/UpeJCsxxfub8Wz+WDsaTlYM6jMQo4jE=; b=DSokA7OoWisZTQqd/9IDB9EnWO23ClTKR1xKjtHvJw1rmqWX7q/SvrZQMHDvFigwib 5WCW8+zJVvCXtXBlW7nN2O2WiUsxqijIxxdSbgGY3TsyR7diaiawctYCMg1UKIYNpVd4 aJA7OdzboJM3hz0v0hZJi7Ybo/BLWlRHg8XJFuIMl7pzRpHSzuUHd/ezOGrlkKjqqIDu FdPV7jFw0N2j7Nvn4rHllbmLi5f8E7cxO6uN8c861GTTCOf9ep9f+Vpe4yX8Mi6/kMr4 GrtceVRVgxK+SfQ2ERlL1StQg+rTjFCXvEWNVxukV2UOVaDfvcthSrbHjmqCrVmBghl/ BCdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=o5W4VnSDneS/UpeJCsxxfub8Wz+WDsaTlYM6jMQo4jE=; b=pXNHrVk3OudK2OksKoP9xI3TzIDRk+NB1KslRaftOoFuGACV0AL/873/Pfow4nhXCO 6n1aZgC/mJaByTwaiUmZkGWwOwQLug1xOSrRCXWgOZU13i5W5raaCTCoH80yXvzTqEJi x9kYicQAtbHmcclsKxH0+6yRPOp2WGOeUSwiHy/trpZXs5rq458H5YYj3xrp4mGrQl9E F1rUbnrZtQyKAtMkyb0w1F0UhreF2GTEwhRagigANOJKuHHAxyfC4op62RrqvamRFrYJ nr8ItvblGDhpwMhbyG/DXK4s88cR5OldJgNeiyJv9/gLiFuSX0d1QlUqtsqZhQ0fTdcM xOlg== X-Gm-Message-State: AOAM530wuDog7blJcNfzK+Bp36PPhLKCiubqvajsBAg8Q/gOhhib5iOK kyic0sLYL5GQrwazT+rD98c9A5rLGjFfhQ== X-Google-Smtp-Source: ABdhPJwHpi/SSyJEdO63/MaMeW9YEhjc/xS8r7sKjGkeqhyMBfE5pcDCboVSIxRbm+QauNbMjkilqQ== X-Received: by 2002:a37:a15:0:b0:69d:c871:9c6d with SMTP id 21-20020a370a15000000b0069dc8719c6dmr6820783qkk.583.1650771175413; Sat, 23 Apr 2022 20:32:55 -0700 (PDT) Received: from hurd (dsl-150-232.b2b2c.ca. [66.158.150.232]) by smtp.gmail.com with ESMTPSA id d17-20020ac85d91000000b002f365edfd21sm229654qtx.83.2022.04.23.20.32.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Apr 2022 20:32:54 -0700 (PDT) From: Maxim Cournoyer References: <20220416142609.11144-1-jgart@dismail.de> Date: Sat, 23 Apr 2022 23:32:53 -0400 In-Reply-To: <20220416142609.11144-1-jgart@dismail.de> (jgart@dismail.de's message of "Sat, 16 Apr 2022 10:26:10 -0400") Message-ID: <87tuaj2m1m.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650771255; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=o5W4VnSDneS/UpeJCsxxfub8Wz+WDsaTlYM6jMQo4jE=; b=q/DJpf7C/HNXdD3BJiwxeBdcfXlQMGujIoKbegped0b9+U8gWElCcK574j1c/teOSV7t9D XiCJkTGrcB6q4686weDQIINGxBRsxZ6feYpT7cByFRGvhs9tP3rZtO0MXcsZJlDHB7vNLk I5YIr/xOlUQXMpfUnHYDcOnw9FhpDq8H1Trga1BFMjJDTIGTlC18YthVXSQKYfiLuJJPe/ /SJZIYj4OzehwTy/Tf5hCFvSyE6r/5Ckkj4tLscacgfF0+7WOuYCRikbgXDZejWxncTtFU e7y3JLm/RKZVhBhmqXNWLjDWFPln7SWVdDL4VGw41qdMzW2gIAYGie7ND2YWUw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650771255; a=rsa-sha256; cv=none; b=YzNu+CXc0iihvPXXv4CMrWHJgo9a0V5QqUnKNn57HWBilQx+B5B2wCU9FAKsT/mjzveKh4 epbkFueaJDgH/Z6hX6NnXGtS6hqz9cqXdQNPP3kdW97hzlUKxcJFcMnrezhd95ch/rRamq BBwNx53gNQYiXm8f0/8bHPNW0CbJAyfdZZCksY41HEif1x++MJol23w9L6mVq0VFM1vSm9 nuMMpGKoKsXBWtBg4DW8hJchvnWHx01TMebd6tFa2+TEeFt4i3AuXa5MY1yBkEojc5FnV+ VTMEABK1xAKu6KfVzZZXZEJMFr7StsZ0DltNCGjSfp4Y91ApYR2EWxN2QgwS2A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=DSokA7Oo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.99 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=DSokA7Oo; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7BF87D530 X-Spam-Score: 5.99 X-Migadu-Scanner: scn1.migadu.com X-TUID: L7bZQFDZOtlT Hi jgart, jgart writes: > * gnu/packages/python-xyz.scm (python-slixmpp): Update to 1.8.1. > [arguments]: Remove trailing boolean, use new style, and use > cc-for-target. > [native-inputs]: Use new style. > > Hi Maxim, > > Here is the second version of this patch. > > I think this adds what you suggested in the code review. > > thanks, > > jgart > > --- > gnu/packages/python-xyz.scm | 25 ++++++++++++------------- > 1 file changed, 12 insertions(+), 13 deletions(-) > > diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm > index 219a0d9213..1654fc2894 100644 > --- a/gnu/packages/python-xyz.scm > +++ b/gnu/packages/python-xyz.scm > @@ -688,7 +688,7 @@ (define-public python-mkdocs-material > (define-public python-slixmpp > (package > (name "python-slixmpp") > - (version "1.5.2") > + (version "1.8.1") > (source > (origin > (method git-fetch) > @@ -700,21 +700,20 @@ (define-public python-slixmpp > (file-name > (git-file-name name version)) > (sha256 > - (base32 "15mqxcws14bjvh5jcfwl86zsvrymkdw3ya07vb44md7vfnsnclwx")))) > + (base32 "0723m7pbyf4xnsy381drni3kr8wm60637gn6d7fbf4i5m04jy9iy")))) > (build-system python-build-system) > (arguments > - `(#:phases > - (modify-phases %standard-phases > - (add-after 'unpack 'patch > - (lambda _ > - (substitute* "setup.py" > - (("'CC', 'cc'") > - "'CC', 'gcc'")) > - #t))))) > + (list #:phases > + #~(modify-phases %standard-phases > + (add-after 'unpack 'patch > + (lambda _ > + (substitute* "setup.py" > + (((string-append "'CC', " #$(cc-for-target))) > + ((string-append "'CC', " #$(cc-for-target)))))))))) This doesn't look right; the matched pattern is replaced by... the same thing? > (native-inputs > - `(("cython" ,python-cython) > - ("gnupg" ,gnupg) > - ("pkg-config" ,pkg-config))) > + (list python-cython > + gnupg > + pkg-config)) Are you sure pkg-config is needed? That's unusual in Python packages. Thanks, Maxim