From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Pierre Langlois <pierre.langlois@gmx.com>, 59423-done@debbugs.gnu.org
Subject: bug#59423: Invalid 'location' field generated in dovecot configuration
Date: Sun, 04 Dec 2022 16:43:46 -0500 [thread overview]
Message-ID: <87tu2a6e0d.fsf@gmail.com> (raw)
In-Reply-To: <87h6ybm7pk.fsf@gnu.org> ("Ludovic Courtès"'s message of "Sun, 04 Dec 2022 17:53:11 +0100")
Hi Ludovic,
Ludovic Courtès <ludo@gnu.org> writes:
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>> Thanks for this extra bit of information and for spotting this usage. I
>> think "location" is likely to conflict for the general purpose
>> 'define-configuration' generated records, so I've renamed the "location"
>> *accessor* to "source-location".
>
> Thank you.
>
> It wasn’t my preferred solution¹ but I think it’s a good one.
>
> ¹ https://issues.guix.gnu.org/59423#15-lineno81
>
>> In the near future I want to migrate more service configurations to the
>> 'define-configuration' machinery, to benefit from its useful
>> self-validating property. For now I wouldn't feel at ease doing so
>> unless raw record matching (not yet using 'match-record') works the same
>> way, since we still have many occurrences making use of that (often via
>> match-lambda). For that reason, I prefer to not revert the record
>> layout until we've gotten rid of all the match-lambda matching record
>> fields directly (which will take some time).
>
> Right, especially given that ‘match-record’ was added in 2017. :-)
Hehe! I had started adapting all the match-lambda, and got overwhelmed
by the changes needed. So I think progressively (i.e., small) be easier
to review or revert in case of errors.
> We’ll have to discuss the implications of a possible move to
> ‘define-configuration’. For example, ‘define-configuration’ cannot
> report missing field values (for fields that lack a default value) at
> macro-expansion time, contrary to plain ‘define-record-type*’. Anyway,
> future work!
OK. That's optimization work rather than an impediment to migrate
though, right? If so, I think the value for users of having errors on
invalid field types outweighs run time efficiency :-).
--
Thanks,
Maxim
next prev parent reply other threads:[~2022-12-04 22:03 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-20 21:53 bug#59423: Invalid 'location' field generated in dovecot configuration Pierre Langlois
2022-11-22 8:10 ` Ludovic Courtès
2022-11-25 15:36 ` Maxim Cournoyer
2022-11-25 20:19 ` Pierre Langlois
2022-11-25 19:17 ` mirai
2022-11-25 20:06 ` Maxim Cournoyer
2022-11-25 20:25 ` Pierre Langlois
2022-11-25 20:50 ` Pierre Langlois
2022-11-25 21:09 ` Pierre Langlois
2022-11-26 2:54 ` Maxim Cournoyer
2022-11-26 19:32 ` Pierre Langlois
2022-11-27 2:33 ` Maxim Cournoyer
2022-11-28 15:01 ` Ludovic Courtès
2022-11-28 20:00 ` Maxim Cournoyer
2022-11-28 21:33 ` Ludovic Courtès
2022-11-29 1:58 ` Maxim Cournoyer
2022-12-02 9:30 ` Ludovic Courtès
2022-12-02 21:18 ` Ludovic Courtès
2022-12-03 3:05 ` Maxim Cournoyer
2022-12-04 16:53 ` Ludovic Courtès
2022-12-04 21:43 ` Maxim Cournoyer [this message]
2022-12-06 8:53 ` Ludovic Courtès
2022-12-01 20:29 ` Pierre Langlois
2022-11-26 23:17 ` Fredrik Salomonsson
2022-12-01 21:55 ` Pierre Langlois
2022-12-03 2:24 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu2a6e0d.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=59423-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=pierre.langlois@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.