From: Pierre Langlois <pierre.langlois@gmx.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: "Ludovic Courtès" <ludo@gnu.org>,
59423@debbugs.gnu.org,
"Pierre Langlois" <pierre.langlois@gmx.com>
Subject: bug#59423: Invalid 'location' field generated in dovecot configuration
Date: Thu, 01 Dec 2022 20:29:23 +0000 [thread overview]
Message-ID: <878rjqg8zh.fsf@gmx.com> (raw)
In-Reply-To: <87sfi2svb9.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3488 bytes --]
Hi Maxim,
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> Hi Ludovic,
>
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hi,
>>
>> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>>
>>>>> The issue seems to be with the serialization of the
>>>>> <namespace-configuration> object nested in the <dovecot-configuration>
>>>>> record. I tried this at the REPL:
>>>>>
>>>>> scheme@(guile-user)> ,m (gnu services mail)
>>>>> scheme@(gnu services mail)> (namespace-configuration (name "inbox"))
>>>>> $8 = #<<namespace-configuration> name: "inbox" type: "private"
>>>>> separator: "" prefix: "" location: "" inbox?: #f hidden?: #f
>>>>> list?: #t subscriptions?: #t mailboxes: () %location: #f>
>>>>> scheme@(gnu services mail)> (serialize-configuration $8 namespace-configuration-fields)
>>>>> name=inbox
>>>>> type=private
>>>>> separator=
>>>>> prefix=
>>>>> location=#f
>>>>
>>>> The location here should probably be empty rather than `#f' no? It looks
>>>> as though the value is coming from the internal %location, rather than
>>>> the user-provided location.
>>
>> Uh.
>>
>>>> I'll if I can find anything the macro, it looks quite complex to me :-).
>>>
>>> It's not only to you, if that helps. It's rather... intimidating ^^'.
>>
>> [...]
>>
>>> Ludovic, would you have an idea of where the %location field or its
>>> CONFIGURATION-location accessor come into play?
>>
>> We have this:
>>
>> (define-record-type* #,(id #'stem #'< #'stem #'>)
>> stem
>> #,(id #'stem #'make- #'stem)
>> #,(id #'stem #'stem #'?)
>> #,@(map (lambda (name getter def)
>> #`(#,name #,getter (default #,def)
>> (sanitize
>> #,(id #'stem #'validate- #'stem #'- name))))
>> #'(field ...)
>> #'(field-getter ...)
>> #'(field-default ...))
>> (%location #,(id #'stem #'stem #'-location)
>> (default (and=> (current-source-location)
>> source-properties->location))
>> (innate)))
>>
>> That generates two accessors called ‘namespace-configuration-location’.
>> The second one shadows the first one.
>
> Yes. You didn't address my question directly though, so let me ask it
> again: where is this %location field access (named "location") used? It
> seems nowhere. Thus, we can simply rename it without impacting
> anything, right (except theoretical usages in the wild, since in the
> API).
>
>> With commit 44554e7133aa60e1b453436be1e80394189cabd9, the second one
>> is the “wrong” one: ‘namespace-configuration-location’ now returns the
>> ‘%location’ field, not the user-specified ‘location’ field. (I
>> reported that issue in <https://issues.guix.gnu.org/48284>.)
>>
>> What do you think of reverting 44554e7133aa60e1b453436be1e80394189cabd9?
>
> No. If we revert something, it won't be that whole commit, but just the
> moving of the field in the define-configuration produced record.
If we don't have an obvious solution to the issue and it may need more
time, how do you feel about reverting the changes? Unless there is a
work around that could be applied until a nicer more permanent solution
is found (although those temporary fixes do tend to stick around
sometimes :-) ).
Thanks,
Pierre
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]
next prev parent reply other threads:[~2022-12-01 20:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-20 21:53 bug#59423: Invalid 'location' field generated in dovecot configuration Pierre Langlois
2022-11-22 8:10 ` Ludovic Courtès
2022-11-25 15:36 ` Maxim Cournoyer
2022-11-25 20:19 ` Pierre Langlois
2022-11-25 19:17 ` mirai
2022-11-25 20:06 ` Maxim Cournoyer
2022-11-25 20:25 ` Pierre Langlois
2022-11-25 20:50 ` Pierre Langlois
2022-11-25 21:09 ` Pierre Langlois
2022-11-26 2:54 ` Maxim Cournoyer
2022-11-26 19:32 ` Pierre Langlois
2022-11-27 2:33 ` Maxim Cournoyer
2022-11-28 15:01 ` Ludovic Courtès
2022-11-28 20:00 ` Maxim Cournoyer
2022-11-28 21:33 ` Ludovic Courtès
2022-11-29 1:58 ` Maxim Cournoyer
2022-12-02 9:30 ` Ludovic Courtès
2022-12-02 21:18 ` Ludovic Courtès
2022-12-03 3:05 ` Maxim Cournoyer
2022-12-04 16:53 ` Ludovic Courtès
2022-12-04 21:43 ` Maxim Cournoyer
2022-12-06 8:53 ` Ludovic Courtès
2022-12-01 20:29 ` Pierre Langlois [this message]
2022-11-26 23:17 ` Fredrik Salomonsson
2022-12-01 21:55 ` Pierre Langlois
2022-12-03 2:24 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rjqg8zh.fsf@gmx.com \
--to=pierre.langlois@gmx.com \
--cc=59423@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.