From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id SDRlHicZjWMoKgAAbAwnHQ (envelope-from ) for ; Sun, 04 Dec 2022 23:03:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id qLNiHicZjWPHhwAAauVa8A (envelope-from ) for ; Sun, 04 Dec 2022 23:03:19 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 363C8C8BE for ; Sun, 4 Dec 2022 23:03:19 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p1wmJ-0007ZB-Oq; Sun, 04 Dec 2022 16:44:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p1wmI-0007Yp-El for bug-guix@gnu.org; Sun, 04 Dec 2022 16:44:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p1wmI-00006a-6d for bug-guix@gnu.org; Sun, 04 Dec 2022 16:44:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p1wmH-00034p-Qz for bug-guix@gnu.org; Sun, 04 Dec 2022 16:44:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#59423: Invalid 'location' field generated in dovecot configuration Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 04 Dec 2022 21:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59423 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Pierre Langlois , 59423-done@debbugs.gnu.org Received: via spool by 59423-done@debbugs.gnu.org id=D59423.167019023511814 (code D ref 59423); Sun, 04 Dec 2022 21:44:01 +0000 Received: (at 59423-done) by debbugs.gnu.org; 4 Dec 2022 21:43:55 +0000 Received: from localhost ([127.0.0.1]:59950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1wmB-00034U-6z for submit@debbugs.gnu.org; Sun, 04 Dec 2022 16:43:55 -0500 Received: from mail-qk1-f171.google.com ([209.85.222.171]:45976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p1wm9-00034O-Di for 59423-done@debbugs.gnu.org; Sun, 04 Dec 2022 16:43:53 -0500 Received: by mail-qk1-f171.google.com with SMTP id v8so3685872qkg.12 for <59423-done@debbugs.gnu.org>; Sun, 04 Dec 2022 13:43:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=iHgWffcE54iIhHXlekEH+1MtpO0+9p7GY+zUPqndhlI=; b=dNGU9Mcvxi9j5cGBzHTsKgLjsyOtsIfcT3HiXqYS0X2/+gYMk7oteN665i0K/fu7Yr YolmZz+7ny90cCqtZykpEjxluDRC5dQNrIKNnYl52Y599AZi63vj7d9wfB7P5C/PFwpa bxI1lw3bhONzA6Cx7NqCNP0R7CMAV3wPWtxo9OISI6x45HlqZ9s7Og8MfAGOPr/LyGNv biDc2i33xTkh1wb0S9vAHje3earqquITxiZfp+cOQquFIPJ7Q2dmrEngy4z18GVugXWV NkY+usivNFssXF+t1OD3K6sHoJ+qXWGieI3OmqooS+8qibRuVbgnBeTcSH69EF/+vmkt aCbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=iHgWffcE54iIhHXlekEH+1MtpO0+9p7GY+zUPqndhlI=; b=548Cd763hh5y5NIu4EJxWiZioBiPVcfJbf1A55Zscn9q8OukhN7dNLhWfAArMlkhoT 4f1x0rTIOwnpqYWn989ufPqqySz6qJ7n+SI4nWPUuWwxPEWSH20Eo1HztkcmwfsxuSid 4O9AhGYf4qBYe0EpaEza3cQ1Qn+vhtIMJ+BTP/Y0kBVt0Tc2lwH3F4UcOB0cmXvg9+Pf khjJivlMlyf495mKISkQAnV4A8+b6dI29PH/EmyTqus9cDEuV7LnxP2vl54x028DXQaw 26tDRr0MA8A++Mj3I4TzUqeutXm0CcQDcRmnIkE3B4BMsV+wbfGHp8KGICbV6uAgeE0m wP/g== X-Gm-Message-State: ANoB5pk78yvF5xnFGCTjp52x+vcWVIBLLjGh0hzchjODh08Sxd3WxStm N7o1EtgJt+MMsSvVNOzr3jwlPQnCPX8= X-Google-Smtp-Source: AA0mqf6SieGm5fSvUWSswjkVSFc3Z7TLCSm6UwbKlHTXtSqqdzERWf/z4OoJqq9P2qeumrCButcOsw== X-Received: by 2002:a05:620a:178a:b0:6fc:b2d2:252c with SMTP id ay10-20020a05620a178a00b006fcb2d2252cmr7520611qkb.512.1670190227700; Sun, 04 Dec 2022 13:43:47 -0800 (PST) Received: from hurd (dsl-156-154.b2b2c.ca. [66.158.156.154]) by smtp.gmail.com with ESMTPSA id w21-20020a05620a0e9500b006e07228ed53sm10658209qkm.18.2022.12.04.13.43.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Dec 2022 13:43:47 -0800 (PST) From: Maxim Cournoyer References: <87y1s5wa4p.fsf@gmx.com> <87v8n2iytp.fsf@gmail.com> <875yf293ph.fsf@gmx.com> <87y1ry7o69.fsf@gmx.com> <87cz9a7n4y.fsf@gmx.com> <87fse6fmrq.fsf@gmail.com> <87cz995wwu.fsf@gmx.com> <87o7stw2gz.fsf@gmail.com> <87pmd7ceck.fsf@gnu.org> <87sfi2svb9.fsf@gmail.com> <8735a2ahmi.fsf@gnu.org> <87a64aseqm.fsf@gmail.com> <87iliuup80.fsf@gnu.org> <878rjpqzbi.fsf@gnu.org> <874judgpav.fsf@gmail.com> <87h6ybm7pk.fsf@gnu.org> Date: Sun, 04 Dec 2022 16:43:46 -0500 In-Reply-To: <87h6ybm7pk.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 04 Dec 2022 17:53:11 +0100") Message-ID: <87tu2a6e0d.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1670191399; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=iHgWffcE54iIhHXlekEH+1MtpO0+9p7GY+zUPqndhlI=; b=m6le5xzjEV3hRL4rYTsIT170x8R0oxwRpe3QOuyXkhI+jE2U3rPYV+/iut8LBGOyD61MeH u24On4lFrrT3zTYaArVCvZS8C758s/ChmWhr9XvEakQ2GmnU7P/alz/RaEjUiXrlNoT/xT 5k3EcbENURVYcZ4Rao8ECZn3e0F0Slegg0ux+PFtrH7yD8wb+kY1PjYGccxv+yx7bardVc PWWKk3qvuNXSmeDoUYNiwAGjf6QzkyrLtcVkrIlElx0K55N84OUPZ2QeZkEUJMGO4XcqOR fFzTNopNblRGZuXDTSJGArcZ/MBh5pvwOsQ3hu9XYUWdMWX1Gn0fK5hE1ok4sw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1670191399; a=rsa-sha256; cv=none; b=IXYeE/PGZR3PHZlWZMRZzQrcE9Qjsws4VG0yd6uguAbWyMciYWpIE0i9FUhJRAmbfd+qvn FpIZhQTHqsyO2KXHFkDLOEsM0JFDHdITg6o27/3P2aaaSftH9DbGyvqIhwrD2S+xMeDHSH zRE6RY0bJc6uOp8TM7is9O1iEv/OeqsrHxSH+WOJiGr9ajTdFQN1/K29RpF/M+YmpZpZmT 6pT7gPB4eG6IRGMtLwfIBvlHVsv+V5wTlR+zz30ZaIV04FBpASmgrIGkx2BQiprbUhilXY TOZCx/UAUM5J0klbMcWaFd984Ol20w+qnduWwjKjdrQvZDNneGMu/P6IJCOT5A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=dNGU9Mcv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.04 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=dNGU9Mcv; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 363C8C8BE X-Spam-Score: 6.04 X-Migadu-Scanner: scn1.migadu.com X-TUID: QYRksh11/GUA Hi Ludovic, Ludovic Court=C3=A8s writes: > Maxim Cournoyer skribis: > >> Thanks for this extra bit of information and for spotting this usage. I >> think "location" is likely to conflict for the general purpose >> 'define-configuration' generated records, so I've renamed the "location" >> *accessor* to "source-location". > > Thank you. > > It wasn=E2=80=99t my preferred solution=C2=B9 but I think it=E2=80=99s a = good one. > > =C2=B9 https://issues.guix.gnu.org/59423#15-lineno81 > >> In the near future I want to migrate more service configurations to the >> 'define-configuration' machinery, to benefit from its useful >> self-validating property. For now I wouldn't feel at ease doing so >> unless raw record matching (not yet using 'match-record') works the same >> way, since we still have many occurrences making use of that (often via >> match-lambda). For that reason, I prefer to not revert the record >> layout until we've gotten rid of all the match-lambda matching record >> fields directly (which will take some time). > > Right, especially given that =E2=80=98match-record=E2=80=99 was added in = 2017. :-) Hehe! I had started adapting all the match-lambda, and got overwhelmed by the changes needed. So I think progressively (i.e., small) be easier to review or revert in case of errors. > We=E2=80=99ll have to discuss the implications of a possible move to > =E2=80=98define-configuration=E2=80=99. For example, =E2=80=98define-con= figuration=E2=80=99 cannot > report missing field values (for fields that lack a default value) at > macro-expansion time, contrary to plain =E2=80=98define-record-type*=E2= =80=99. Anyway, > future work! OK. That's optimization work rather than an impediment to migrate though, right? If so, I think the value for users of having errors on invalid field types outweighs run time efficiency :-). --=20 Thanks, Maxim