all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Mark H Weaver <mhw@netris.org>
Cc: Simon Tournier <zimon.toutoune@gmail.com>,
	 Tobias Geerinckx-Rice <me@tobias.gr>,
	 Guix Devel <guix-devel@gnu.org>
Subject: Re: The package/inherit trap
Date: Mon, 07 Aug 2023 10:41:16 -0400	[thread overview]
Message-ID: <87sf8uewz7.fsf@gmail.com> (raw)
In-Reply-To: <87h6pbojgn.fsf@netris.org> (Mark H. Weaver's message of "Sun, 06 Aug 2023 19:10:21 -0400")

Hello,

Mark H Weaver <mhw@netris.org> writes:

> Simon Tournier <zimon.toutoune@gmail.com> writes:
>
>> Hi Tobias,
>>
>> On Tue, 07 Mar 2023 at 22:11, Tobias Geerinckx-Rice <me@tobias.gr> wrote:
>>
>>> However, merely documenting something is not enough when we have the
>>> chance to fix misleading naming, as we do here.  It would be nice to
>>> have, but orthogonal. 
>>
>> I would not say it is orthogonal because renaming would not have been
>> enough, at least for me, in order to get the difference with ’inherit’.
>>
>> For sure, it is a real trap. :-)  For instance,
>>
>>     $ git log --grep='package/inherit' --oneline | grep use
>>     5f83dd03a2 gnu: kodi/wayland: Do not use package/inherit.
>>     6ecf88a6a1 gnu: poppler-next: Don't use 'package/inherit'.
>>     5a5b729d66 gnu: abseil-cpp: Don't use 'package/inherit'.
>>     dbcf2b61b1 gnu: Fix erroneous uses of 'package/inherit'.
>>     2f97a666a5 gnu: python-urllib3: Don't use 'package/inherit' on replacement package.
>>     4163b6d855 gnu: avahi: Don't use package/inherit.
>>
>> and in the light of this discussion, 5f83dd03a2 seems incorrect, no?
>
> I agree that commit 5f83dd03a2 is incorrect.  'kodi/wayland' is quite
> clearly a case where 'package/inherit' should be used.

Would you be able to write a bit of doc explaining when both should be
used?  It's a common pitfalls among contributors, and I suspect few of
us have an understanding good enough to write it down in a manner clear
enough to be understood by new contributors.

-- 
Thanks,
Maxim


  reply	other threads:[~2023-08-07 14:41 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 13:06 [bug#61674] [PATCH 0/4] gnu: stellarium: Enable ShowMySky Sharlatan Hellseher
2023-02-21 13:07 ` [bug#61674] [PATCH 1/4] gnu: Add calcmysky Sharlatan Hellseher
2023-02-21 13:07   ` [bug#61674] [PATCH 2/4] gnu: qxlsx: Use Qt6 Sharlatan Hellseher
2023-02-21 13:07   ` [bug#61674] [PATCH 3/4] gnu: Add qxlsx-qt5 Sharlatan Hellseher
2023-02-21 13:07   ` [bug#61674] [PATCH 4/4] gnu: stellarium: Enable ShowMySky Sharlatan Hellseher
2023-02-26  0:37 ` [bug#61674] Sharlatan Hellseher
2023-02-26  0:44 ` [bug#61674] [PATCH 1/4] gnu: Add calcmysky Sharlatan Hellseher
2023-02-26  0:44   ` [bug#61674] [PATCH 2/4] gnu: qxlsx: Use Qt6 Sharlatan Hellseher
2023-02-26  0:44   ` [bug#61674] [PATCH 3/4] gnu: Add qxlsx-qt5 Sharlatan Hellseher
2023-02-27 21:15     ` [bug#61674] [PATCH 0/4] gnu: stellarium: Enable ShowMySky Ludovic Courtès
2023-02-26  0:44   ` [bug#61674] [PATCH 4/4] " Sharlatan Hellseher
2023-02-27 21:15     ` [bug#61674] [PATCH 0/4] " Ludovic Courtès
2023-02-26  2:55   ` [bug#61674] [PATCH 1/4] gnu: Add calcmysky Leo Famulari
2023-02-27 21:14   ` [bug#61674] [PATCH 0/4] gnu: stellarium: Enable ShowMySky Ludovic Courtès
2023-02-28 10:35     ` Simon Tournier
2023-03-03 10:49       ` Ludovic Courtès
2023-03-03 11:04         ` Simon Tournier
2023-03-03 15:54           ` Maxim Cournoyer
2023-03-03 18:19             ` Simon Tournier
2023-03-04  3:32               ` Maxim Cournoyer
2023-03-04 11:11                 ` Sharlatan Hellseher
2023-03-03 19:21             ` The package/inherit trap (was: gnu: stellarium: Enable ShowMySky.) Tobias Geerinckx-Rice
2023-03-04  3:44               ` The package/inherit trap Maxim Cournoyer
2023-03-07 11:46               ` The package/inherit trap (was: gnu: stellarium: Enable ShowMySky.) Simon Tournier
2023-03-07 16:43                 ` The package/inherit trap Maxim Cournoyer
2023-03-07 17:46                   ` Simon Tournier
2023-03-07 22:11                     ` Tobias Geerinckx-Rice
2023-03-08  9:07                       ` Simon Tournier
2023-07-31 20:17                         ` John Kehayias
2023-08-06 23:10                         ` Mark H Weaver
2023-08-07 14:41                           ` Maxim Cournoyer [this message]
2023-08-10 20:40                             ` Mark H Weaver
2023-08-10 21:27                               ` Mark H Weaver
2023-09-02 18:46                               ` Maxim Cournoyer
2023-08-07  0:00               ` The package/inherit trap (was: gnu: stellarium: Enable ShowMySky.) (
2023-08-07  6:29                 ` Attila Lendvai
2023-08-07 14:43                   ` The package/inherit trap Maxim Cournoyer
2023-02-28  0:12 ` [bug#61674] [PATCH v3 1/4] gnu: Add calcmysky Sharlatan Hellseher
2023-02-28  0:12   ` [bug#61674] [PATCH v3 2/4] gnu: qxlsx: Use Qt6 Sharlatan Hellseher
2023-02-28  0:12   ` [bug#61674] [PATCH v3 3/4] gnu: Add qxlsx-qt5 Sharlatan Hellseher
2023-02-28  0:12   ` [bug#61674] [PATCH v3 4/4] gnu: stellarium: Enable ShowMySky Sharlatan Hellseher
2023-03-07 10:39     ` bug#61674: [PATCH 0/4] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sf8uewz7.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=guix-devel@gnu.org \
    --cc=me@tobias.gr \
    --cc=mhw@netris.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.