From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id qFpuG60C0WQhJQAASxT56A (envelope-from ) for ; Mon, 07 Aug 2023 16:41:49 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4789::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id eHZBG60C0WQ9lQAA9RJhRA (envelope-from ) for ; Mon, 07 Aug 2023 16:41:49 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0747B50B50 for ; Mon, 7 Aug 2023 16:41:49 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=M2eO+5Sv; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1691419309; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=i3tb8pXzDz6SYu/vyKFCeYC3+TUroC1GZJ9/KnfR7oA=; b=pNwnzFDIzmmFBmp9Pvj0lr+9EvSkxe428NobySVtywrbkhLNN5i+jrFQqakvyhSwmYMyPh snOGOAow7nW4nzx+aj65qY0jPVIbUO/qYBGFHz48y0hrGhH0xL8EPmR9TwiRKHL1owMmAl zJNS+NZ4XrRDtFAjXScW/jjbbhSidMmgM+3bdZIRdNJTceOVKfa2k9AuHbjDC6vV570pKS pRJAZarUDwExw+N66S5ATs80w+KYpTdZFFIVdv8pCPBl+SwR+zh+D2XrW3sNi8+TSw+klW l0R2QZbObTHrIXjtVwtuPfpGrAGorUmRYOf19/v2/daM7Fgshdi34scUiEZJ/A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=M2eO+5Sv; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1691419309; a=rsa-sha256; cv=none; b=lonpG6uZ8DTdI7oP71YzOd6YHw7ER5G1uqL1Syox3Ue3JpV0taM0M+HEHjerxU6f1Ok9X+ 7tASuLiP5cf/0iOAeuBUpi/vimhyq4ZikjPufg5n48hJFczfvyNRrmXufbcs+46xVecxBV hiu47WZp8bJuEy6F/EnzUgDii4Zx8D2N6SlukS0rdpH035uXxQkwNwyoxHyTCrtaitfzMw a+uUGKpAojluuhm4HnZlSZHvgHMPdZO97Hl9lrDhVLHkVKwK5hlTQnfScpFj234N7fKzFa DcGBHuJaaJrn+OoEthvrmb8hb4FdHHWQmvGBOAj70bE+brU9fsOtxj9aCWCQaA== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qT1QC-0007np-5l; Mon, 07 Aug 2023 10:41:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qT1QA-0007nd-Dr for guix-devel@gnu.org; Mon, 07 Aug 2023 10:41:22 -0400 Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qT1Q8-0002tU-AN for guix-devel@gnu.org; Mon, 07 Aug 2023 10:41:22 -0400 Received: by mail-ot1-x332.google.com with SMTP id 46e09a7af769-6bca857accbso3962573a34.0 for ; Mon, 07 Aug 2023 07:41:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691419278; x=1692024078; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=i3tb8pXzDz6SYu/vyKFCeYC3+TUroC1GZJ9/KnfR7oA=; b=M2eO+5SvT+wOBx5cjP25zJUl2DtZNXxUO8xKF/k9Nrf2b558+1UcpMAZCHBxjZPb4/ iC9jMnqWyRb3PGWEnGPrHzH0WE6Mp0B/5kuFrBuxcUYCkIJzOKG9Mm734/6uQD1bZAnU Syqk51MSHB+kZ4/bQxYG7wlRWXxh1XC8rTKHOtXd+TXTIxTsUVOc/0wIAPyD75V/gm2z bPCuyTKPEbG9hWww2s3G4uSzGdM7IuYwTfE7v7qjYjyAP0sttE5l2bNwv/pYicH5fJ/R WkmLXCqVGn4TydtpsnuC2rbgULRUisty12yWnmRV6pQp8jIIgxdhRK2JnyBjrc5SSWWb 5CfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691419278; x=1692024078; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=i3tb8pXzDz6SYu/vyKFCeYC3+TUroC1GZJ9/KnfR7oA=; b=kcSfykojegyQIYSa/ELyf41eDA+o4COP23uQMsM1LBBIfzIHS8WfcfoDSZ3SWM+jMk 1cstvJyej1N9v0RwBluCi/wwKvt8RvsxkuJNv19OaEcwhLrGNbvO1Go4T1R6neuHMieZ 3xJ3wDWGTe0iYI7BmLOikZBlyr85Qlf3NM45ptZvYm5KgtovjYPWo1Im15rsr2tzoAtH MSSDSKTySgPokRGZ5ZA8ZfUaCEe5iuuk1udl9aBePJ4wadmb3I0gS8kktGrmHJaiKHae 1cpuw1w6h+eRbNHFUPZXDEwCksCLR65pClGCsU/MpLZvG5HRuw0hvy3ruJGgV29l3J8b vdWA== X-Gm-Message-State: AOJu0Yzn7hGgSP3IiyUbTdsTXec5v+KDtIaa5Y/DUzKzAvk+IGujYr7C uzvRIhInXeMV/TfxFVoC3mZ9lzPeBIE= X-Google-Smtp-Source: AGHT+IG8OS8lZEpiEjbz3fYbm2fzvakJxGAzyLnlexFKl5cTZC0pKwWTevH7R6D9xLpGoRm3QxGz+Q== X-Received: by 2002:a9d:730c:0:b0:6b9:9cc0:4854 with SMTP id e12-20020a9d730c000000b006b99cc04854mr8216453otk.32.1691419278268; Mon, 07 Aug 2023 07:41:18 -0700 (PDT) Received: from hurd (dsl-205-236-230-170.b2b2c.ca. [205.236.230.170]) by smtp.gmail.com with ESMTPSA id f3-20020ac84703000000b00403ff38d855sm2685359qtp.4.2023.08.07.07.41.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 07:41:17 -0700 (PDT) From: Maxim Cournoyer To: Mark H Weaver Cc: Simon Tournier , Tobias Geerinckx-Rice , Guix Devel Subject: Re: The package/inherit trap References: <20230221130600.18932-1-sharlatanus@gmail.com> <20230226004406.6215-1-sharlatanus@gmail.com> <87ilfmhkuh.fsf_-_@gnu.org> <87lekijcwi.fsf@gmail.com> <87v8jixg6u.fsf@gnu.org> <87o7p94yqk.fsf@gmail.com> <87jzzxy6l0.fsf@nckx> <86lek8dbsf.fsf@gmail.com> <87bkl4y0kh.fsf@gmail.com> <86o7p4a1yt.fsf@gmail.com> <0F2AA797-A329-4E6D-924E-AF5AB9F89064@tobias.gr> <86v8jb8vby.fsf@gmail.com> <87h6pbojgn.fsf@netris.org> Date: Mon, 07 Aug 2023 10:41:16 -0400 In-Reply-To: <87h6pbojgn.fsf@netris.org> (Mark H. Weaver's message of "Sun, 06 Aug 2023 19:10:21 -0400") Message-ID: <87sf8uewz7.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::332; envelope-from=maxim.cournoyer@gmail.com; helo=mail-ot1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Queue-Id: 0747B50B50 X-Migadu-Scanner: mx1.migadu.com X-Spam-Score: -8.04 X-Migadu-Spam-Score: -8.04 X-TUID: 088japuhS0+5 Hello, Mark H Weaver writes: > Simon Tournier writes: > >> Hi Tobias, >> >> On Tue, 07 Mar 2023 at 22:11, Tobias Geerinckx-Rice wrote: >> >>> However, merely documenting something is not enough when we have the >>> chance to fix misleading naming, as we do here. It would be nice to >>> have, but orthogonal.=20 >> >> I would not say it is orthogonal because renaming would not have been >> enough, at least for me, in order to get the difference with =E2=80=99in= herit=E2=80=99. >> >> For sure, it is a real trap. :-) For instance, >> >> $ git log --grep=3D'package/inherit' --oneline | grep use >> 5f83dd03a2 gnu: kodi/wayland: Do not use package/inherit. >> 6ecf88a6a1 gnu: poppler-next: Don't use 'package/inherit'. >> 5a5b729d66 gnu: abseil-cpp: Don't use 'package/inherit'. >> dbcf2b61b1 gnu: Fix erroneous uses of 'package/inherit'. >> 2f97a666a5 gnu: python-urllib3: Don't use 'package/inherit' on repla= cement package. >> 4163b6d855 gnu: avahi: Don't use package/inherit. >> >> and in the light of this discussion, 5f83dd03a2 seems incorrect, no? > > I agree that commit 5f83dd03a2 is incorrect. 'kodi/wayland' is quite > clearly a case where 'package/inherit' should be used. Would you be able to write a bit of doc explaining when both should be used? It's a common pitfalls among contributors, and I suspect few of us have an understanding good enough to write it down in a manner clear enough to be understood by new contributors. --=20 Thanks, Maxim