From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: Simon Tournier <zimon.toutoune@gmail.com>,
Guix Devel <guix-devel@gnu.org>
Subject: Re: The package/inherit trap
Date: Fri, 03 Mar 2023 22:44:26 -0500 [thread overview]
Message-ID: <87r0u52nad.fsf@gmail.com> (raw)
In-Reply-To: <87jzzxy6l0.fsf@nckx> (Tobias Geerinckx-Rice's message of "Fri, 03 Mar 2023 20:21:02 +0100")
Hi,
Tobias Geerinckx-Rice <me@tobias.gr> writes:
> Hi!
>
> Maxim Cournoyer 写道:
>> Simon Tournier <zimon.toutoune@gmail.com> writes:
>>> It is not clear for me why you choose one over the other. From my
>>> current understanding, I would be tempted to always use
>>> 'package/inherit' and never plain 'inherit'.
>>
>> I also got confused by that in the past;
>
> Same. I think it's a rite of passage. A questionable one.
>
>> The way I process it internally now is this:
>>
>> If the inheritance is for *same-source/same-version* variants of a
>> package, they should use package/inherit, as any security issues
>> found
>> in the parent package should also be applied to that package (since
>> they
>> use the same source). Otherwise, plain 'inherit' should be used
>> (e.g. for newer version variants).
>
> That about jives with my intuition.
>
> Judging by the (IMO) universal confusion this causes, it is (IMO)
> spectacularly poorly-named. A docstring doesn't fix that.
>
> Could we rename it to something like ‘package+replacements/inherit’?
> To me, that captures the spirit, without being overly longer.
That'd be better, I think. The more verbose name at least wouldn't let
one think, 'oh, some questionable syntax sugar for the lazy', like I did
in the past :-).
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-03-04 3:44 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 13:06 [bug#61674] [PATCH 0/4] gnu: stellarium: Enable ShowMySky Sharlatan Hellseher
2023-02-21 13:07 ` [bug#61674] [PATCH 1/4] gnu: Add calcmysky Sharlatan Hellseher
2023-02-21 13:07 ` [bug#61674] [PATCH 2/4] gnu: qxlsx: Use Qt6 Sharlatan Hellseher
2023-02-21 13:07 ` [bug#61674] [PATCH 3/4] gnu: Add qxlsx-qt5 Sharlatan Hellseher
2023-02-21 13:07 ` [bug#61674] [PATCH 4/4] gnu: stellarium: Enable ShowMySky Sharlatan Hellseher
2023-02-26 0:37 ` [bug#61674] Sharlatan Hellseher
2023-02-26 0:44 ` [bug#61674] [PATCH 1/4] gnu: Add calcmysky Sharlatan Hellseher
2023-02-26 0:44 ` [bug#61674] [PATCH 2/4] gnu: qxlsx: Use Qt6 Sharlatan Hellseher
2023-02-26 0:44 ` [bug#61674] [PATCH 3/4] gnu: Add qxlsx-qt5 Sharlatan Hellseher
2023-02-27 21:15 ` [bug#61674] [PATCH 0/4] gnu: stellarium: Enable ShowMySky Ludovic Courtès
2023-02-26 0:44 ` [bug#61674] [PATCH 4/4] " Sharlatan Hellseher
2023-02-27 21:15 ` [bug#61674] [PATCH 0/4] " Ludovic Courtès
2023-02-26 2:55 ` [bug#61674] [PATCH 1/4] gnu: Add calcmysky Leo Famulari
2023-02-27 21:14 ` [bug#61674] [PATCH 0/4] gnu: stellarium: Enable ShowMySky Ludovic Courtès
2023-02-28 10:35 ` Simon Tournier
2023-03-03 10:49 ` Ludovic Courtès
2023-03-03 11:04 ` Simon Tournier
2023-03-03 15:54 ` Maxim Cournoyer
2023-03-03 18:19 ` Simon Tournier
2023-03-04 3:32 ` Maxim Cournoyer
2023-03-04 11:11 ` Sharlatan Hellseher
2023-03-03 19:21 ` The package/inherit trap (was: gnu: stellarium: Enable ShowMySky.) Tobias Geerinckx-Rice
2023-03-04 3:44 ` Maxim Cournoyer [this message]
2023-03-07 11:46 ` Simon Tournier
2023-03-07 16:43 ` The package/inherit trap Maxim Cournoyer
2023-03-07 17:46 ` Simon Tournier
2023-03-07 22:11 ` Tobias Geerinckx-Rice
2023-03-08 9:07 ` Simon Tournier
2023-07-31 20:17 ` John Kehayias
2023-08-06 23:10 ` Mark H Weaver
2023-08-07 14:41 ` Maxim Cournoyer
2023-08-10 20:40 ` Mark H Weaver
2023-08-10 21:27 ` Mark H Weaver
2023-09-02 18:46 ` Maxim Cournoyer
2023-08-07 0:00 ` The package/inherit trap (was: gnu: stellarium: Enable ShowMySky.) (
2023-08-07 6:29 ` Attila Lendvai
2023-08-07 14:43 ` The package/inherit trap Maxim Cournoyer
2023-02-28 0:12 ` [bug#61674] [PATCH v3 1/4] gnu: Add calcmysky Sharlatan Hellseher
2023-02-28 0:12 ` [bug#61674] [PATCH v3 2/4] gnu: qxlsx: Use Qt6 Sharlatan Hellseher
2023-02-28 0:12 ` [bug#61674] [PATCH v3 3/4] gnu: Add qxlsx-qt5 Sharlatan Hellseher
2023-02-28 0:12 ` [bug#61674] [PATCH v3 4/4] gnu: stellarium: Enable ShowMySky Sharlatan Hellseher
2023-03-07 10:39 ` bug#61674: [PATCH 0/4] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0u52nad.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=guix-devel@gnu.org \
--cc=me@tobias.gr \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.