From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id WHL7K7m+AmTHgwEAbAwnHQ (envelope-from ) for ; Sat, 04 Mar 2023 04:44:57 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id gN2ZK7m+AmTuWAEA9RJhRA (envelope-from ) for ; Sat, 04 Mar 2023 04:44:57 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 65D0F26426 for ; Sat, 4 Mar 2023 04:44:57 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=AEPbFmj1; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1677901497; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=mlyM4kmDCbdVxQdpqcicoVgeW3EiEaVprNo/hspf6os=; b=cDJg1XEuxjuwsnQ+KTE3CBOX6JFc2GlvdoxyZhrSlgZK4G+Ku41i9qdZs/Vk29dqGS/odR mBkTN6RVnemyFFDLAwTTGJ+5zygxULTAVlc0CxOezwjpVfCu70k+BOlQ4DIGZrxhYKLoPr tBNQJy9ci+vCrB3w7ASMI2/EpDvJYgOin7E7OUpqQD8WrxNh5b0zwAHEp1dSS/yNw2kAxi H0wpVRk+8D7qsurefN37qEGFVYM97mNOrwEHklGmK+RKoRrGFqRi77nVAHMRRmig5+166P MV7xL3Dog2oma+E2h/qNRcUNewV03uthg4x2mrJFVxie0MW4J1KJ2I24oPnqNQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=AEPbFmj1; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=key1; d=yhetil.org; t=1677901497; a=rsa-sha256; cv=none; b=b03lF8WJDVM8cZif6awOAuxdlNLfB4E3S5YqmEXJeSgH/dqW5662N3np/XzHz78KpWNtah RFQL09I8Q2Eq2eWMhB8KmiEuXMxbtVjhPn7TD24BqvSfxayBopgEw2RYpGQ47rJF7ai6Mt 8B4p980ZApNwmsVnBoadu61/tpVlSYUbJW7zS/PSrTfJicwSFDav3KyRCfsM/3I89BU6ZX 93dx7sWBm5bShG2/eNU8ha3cSehyb97JOc3dt7dWzgxa/esH/o+Nn3XFZ5svfX87kcb9VR LVsRH19wtRguxCHcwkuDCCEBG2BvJWMsT+eEfs+0qp5uxXJwKFlua1WOte0l7Q== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYIoz-0006ud-6U; Fri, 03 Mar 2023 22:44:33 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYIox-0006tF-L7 for guix-devel@gnu.org; Fri, 03 Mar 2023 22:44:31 -0500 Received: from mail-qv1-xf32.google.com ([2607:f8b0:4864:20::f32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYIov-0007ea-Ru for guix-devel@gnu.org; Fri, 03 Mar 2023 22:44:31 -0500 Received: by mail-qv1-xf32.google.com with SMTP id o3so3133598qvr.1 for ; Fri, 03 Mar 2023 19:44:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=mlyM4kmDCbdVxQdpqcicoVgeW3EiEaVprNo/hspf6os=; b=AEPbFmj1z9r3dQuKovqB26czJ9vU5dXn9ySAHTquvuir+SZkjs3SfQ2B/Pptqt1KBW LggePiNKARswINSzQ1p3cfITufTNMUAy7f0uHqkNz5r2+UF0YMnI57Qgihd1cg1i2x0P LXfNalK+2sU5W7r6gpycuCJfqL++NX+n3LTwHz4LVQSbIrazxomPqSORgIouvt09v2f0 JfwEJYUyRXDHv4MoCL4aJcFZ/+YjwQRRy14afSbUk+xujNoJNM5cmpMg2sg0udC091Yi amaEAN14SE5VNWvYg2NEwGAKbjVc8j1hHOyQLUDAwKcpgfYjznMzC/Q2Oopjea3zhWdg 8eYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=mlyM4kmDCbdVxQdpqcicoVgeW3EiEaVprNo/hspf6os=; b=a9jw5YNArnMfVxJX+Ikwz9YZRF0uaQ9WtaJP7UtWPZJGWTgLveHGHUehpJIEgesmmR 86rvtCOnLfFIqkr1goIGCRe+X0wgvn0HXAxPHHF09Oa3jSuXfGkkVeQYgQ0TqRC6YwBw l+PEvY69q5OMPKdTxktpw6eIQKfRZVmGHSKHYqOWTtGwDS+10MhAN73onrxHAvxkRpZe OJAgOyyFPb/oJ2RIEmPXLUER17vWy/VIpM4Gv5XTUYWwOeqLPNK25Yai47wzAfvXPszT taaM/b0HbgGl9c0Ir8ldlFBKK42YBZD4t9tdAE8M+mv5GLXLs5p83Tw7hGpffklAEBay yqHQ== X-Gm-Message-State: AO0yUKUFwqSNcf0cHUCsWA2ntMHB7ha2IvnAIM3F3CMPpjHY7+EP/pg6 MW/X1cfG0o5yfe3zOtcGN75O4nWlX6PXleIV X-Google-Smtp-Source: AK7set9MnnHeneWuPjIjdRe+4lp+Gl3li2TG4YRQgWUBK7gawuLfPWapZR/wunfXFzmBnb6nvjaVtQ== X-Received: by 2002:ad4:5ba9:0:b0:572:6e81:ae89 with SMTP id 9-20020ad45ba9000000b005726e81ae89mr6470034qvq.40.1677901467740; Fri, 03 Mar 2023 19:44:27 -0800 (PST) Received: from hurd (dsl-10-129-180.b2b2c.ca. [72.10.129.180]) by smtp.gmail.com with ESMTPSA id f62-20020a37d241000000b007339c5114a9sm2990596qkj.103.2023.03.03.19.44.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Mar 2023 19:44:27 -0800 (PST) From: Maxim Cournoyer To: Tobias Geerinckx-Rice Cc: Simon Tournier , Guix Devel Subject: Re: The package/inherit trap References: <20230221130600.18932-1-sharlatanus@gmail.com> <20230226004406.6215-1-sharlatanus@gmail.com> <87ilfmhkuh.fsf_-_@gnu.org> <87lekijcwi.fsf@gmail.com> <87v8jixg6u.fsf@gnu.org> <87o7p94yqk.fsf@gmail.com> <87jzzxy6l0.fsf@nckx> Date: Fri, 03 Mar 2023 22:44:26 -0500 In-Reply-To: <87jzzxy6l0.fsf@nckx> (Tobias Geerinckx-Rice's message of "Fri, 03 Mar 2023 20:21:02 +0100") Message-ID: <87r0u52nad.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::f32; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qv1-xf32.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Spam-Score: -8.42 X-Spam-Score: -8.42 X-Migadu-Scanner: scn0.migadu.com X-Migadu-Queue-Id: 65D0F26426 List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-TUID: oZTzDhXFevOt Hi, Tobias Geerinckx-Rice writes: > Hi! > > Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A >> Simon Tournier writes: >>> It is not clear for me why you choose one over the other. From my >>> current understanding, I would be tempted to always use >>> 'package/inherit' and never plain 'inherit'. >> >> I also got confused by that in the past; > > Same. I think it's a rite of passage. A questionable one. > >> The way I process it internally now is this: >> >> If the inheritance is for *same-source/same-version* variants of a >> package, they should use package/inherit, as any security issues >> found >> in the parent package should also be applied to that package (since >> they >> use the same source). Otherwise, plain 'inherit' should be used >> (e.g. for newer version variants). > > That about jives with my intuition. > > Judging by the (IMO) universal confusion this causes, it is (IMO) > spectacularly poorly-named. A docstring doesn't fix that. > > Could we rename it to something like =E2=80=98package+replacements/inheri= t=E2=80=99? > To me, that captures the spirit, without being overly longer. That'd be better, I think. The more verbose name at least wouldn't let one think, 'oh, some questionable syntax sugar for the lazy', like I did in the past :-). --=20 Thanks, Maxim