From: Hilton Chain via Guix-patches via <guix-patches@gnu.org>
To: Thomas Ieong <th.ieong@free.fr>
Cc: 61946@debbugs.gnu.org
Subject: [bug#61946] Go generated files
Date: Thu, 10 Aug 2023 20:12:17 +0800 [thread overview]
Message-ID: <87r0objdum.wl-hako@ultrarare.space> (raw)
In-Reply-To: <87mt4sjjbo.fsf@free.fr>
Hi Thomas,
> I forgot to check for generated files in the go packages.
> I did just that and there is indeed one file hash.go that is generated
> in the parse and minify package.
>
> Taking care of this and resending later.
go-github-com-tdewolff-minify-v2 has been available in Guix for a
while (but not the minify command and its dependency). I have sent a
patchset [1] to generate hash.go at build time. Can you update the
series to base on it and current Guix?
And I think dependencies not added to go-github-com-tdewolff-minify-v2
are only required by minify command, so there's no need to touch
definition of the former, inherit and modify is sufficient. What do
you think?
Thanks
[1]: <https://issues.guix.gnu.org/65204>
next prev parent reply other threads:[~2023-08-10 12:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 22:55 [bug#61946] [PATCH 0/6] gnu: golang: Add minify Thomas Ieong
2023-03-03 23:01 ` [bug#61946] [PATCH 1/6] gnu: Add go-github-com-djherbis-atime Thomas Ieong
2023-03-03 23:01 ` [bug#61946] [PATCH 2/6] gnu: Add go-github-com-matryer-try Thomas Ieong
2023-03-03 23:01 ` [bug#61946] [PATCH 3/6] gnu: Add go-github-com-tdewolff-parse-v2 Thomas Ieong
2023-03-03 23:01 ` [bug#61946] [PATCH 4/6] gnu: Add go-github-com-tdewolff-test Thomas Ieong
2023-03-03 23:01 ` [bug#61946] [PATCH 5/6] gnu: Add go-github-com-tdewolff-minify-v2 Thomas Ieong
2023-03-03 23:01 ` [bug#61946] [PATCH 6/6] gnu: Add minify Thomas Ieong
2023-03-04 21:30 ` [bug#61946] Go generated files Thomas Ieong
2023-08-10 12:12 ` Hilton Chain via Guix-patches via [this message]
2024-01-30 23:17 ` bug#61946: [PATCH 0/6] gnu: golang: Add minify Sharlatan Hellseher
2024-02-01 3:10 ` [bug#61946] " Hilton Chain via Guix-patches via
2024-02-01 20:54 ` Sharlatan Hellseher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0objdum.wl-hako@ultrarare.space \
--to=guix-patches@gnu.org \
--cc=61946@debbugs.gnu.org \
--cc=hako@ultrarare.space \
--cc=th.ieong@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.