all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Sharlatan Hellseher <sharlatanus@gmail.com>
To: 61946-done@debbugs.gnu.org
Cc: Ricardo Wurmus <rekado@elephly.net>,
	Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: bug#61946: [PATCH 0/6] gnu: golang: Add minify
Date: Tue, 30 Jan 2024 23:17:29 +0000	[thread overview]
Message-ID: <87v87as96e.fsf@gmail.com> (raw)
In-Reply-To: <cover.1677883649.git.th.ieong@free.fr>

[-- Attachment #1: Type: text/plain, Size: 1398 bytes --]


Hi Thomas and Hilton,

I've tried to resolved all highlights which Hilton pointed out and from
some investigation I've left with 3 pushed patches.

- present [3/3]
  - [X] go-github-com-tdewolff-parse-v2
  - [X] go-github-com-tdewolff-test
  - [X] go-github-com-tdewolff-minify-v2

- added to golang-xyz.scm [2/2]
  - [X] go-github-com-djherbis-atime
  - [X] go-github-com-matryer-try

And the minify looks like this with inherit and modification:

--8<---------------cut here---------------start------------->8---
(define-public minify
  (package
    (inherit go-github-com-tdewolff-minify-v2)
    (name "minify")
    (arguments
     (substitute-keyword-arguments
         (package-arguments go-github-com-tdewolff-minify-v2)
       ((#:install-source? _ #t) #f)
       ((#:import-path _ "github.com/tdewolff/minify/v2")
        "github.com/tdewolff/minify/cmd/minify")))
    (inputs
     (list go-github-com-djherbis-atime
           go-github-com-dustin-go-humanize
           go-github-com-fsnotify-fsnotify
           go-github-com-matryer-try
           go-github-com-spf13-pflag))))
--8<---------------cut here---------------end--------------->8---

Maxim or Ricardo, 

Pinging you here as following, I've built it few times locally and
everything passed just fine, for some reason CI feel bad.
https://ci.guix.gnu.org/eval/1086875

Thanks,
Oleg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  parent reply	other threads:[~2024-01-30 23:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03 22:55 [bug#61946] [PATCH 0/6] gnu: golang: Add minify Thomas Ieong
2023-03-03 23:01 ` [bug#61946] [PATCH 1/6] gnu: Add go-github-com-djherbis-atime Thomas Ieong
2023-03-03 23:01 ` [bug#61946] [PATCH 2/6] gnu: Add go-github-com-matryer-try Thomas Ieong
2023-03-03 23:01 ` [bug#61946] [PATCH 3/6] gnu: Add go-github-com-tdewolff-parse-v2 Thomas Ieong
2023-03-03 23:01 ` [bug#61946] [PATCH 4/6] gnu: Add go-github-com-tdewolff-test Thomas Ieong
2023-03-03 23:01 ` [bug#61946] [PATCH 5/6] gnu: Add go-github-com-tdewolff-minify-v2 Thomas Ieong
2023-03-03 23:01 ` [bug#61946] [PATCH 6/6] gnu: Add minify Thomas Ieong
2023-03-04 21:30 ` [bug#61946] Go generated files Thomas Ieong
2023-08-10 12:12 ` Hilton Chain via Guix-patches via
2024-01-30 23:17 ` Sharlatan Hellseher [this message]
2024-02-01  3:10   ` [bug#61946] [PATCH 0/6] gnu: golang: Add minify Hilton Chain via Guix-patches via
2024-02-01 20:54 ` Sharlatan Hellseher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v87as96e.fsf@gmail.com \
    --to=sharlatanus@gmail.com \
    --cc=61946-done@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.